March 2021 - Accel-config

[PATCH 0/5] accel-config: Add wq ats_disable support

by Xiaochen Shen

Upstream kernel 5.11 introduced ATS disable knob for work queues in commit 92de5fa2dc39 ("dmaengine: idxd: add ATS disable knob for work queues"). Accel-config needs to add support to match kernel driver change. Add wq ats_disable support in library, configuration file, json interface, and config-wq command. Add unit test and documentation for wq option ats_disable. Xiaochen Shen (5): accel-config: Add ats_disable wq function in lib accel-config: Add ats_disable in config and json accel-config: Add ats_disable attr to config-wq command accel-config: Add ats_disable unit test accel-config: Add documentation for wq option ats-disable Documentation/accfg/accel-config-config-wq.txt | 6 ++++++ accfg/config.c | 1 + accfg/config_attr.c | 16 ++++++++++++++++ accfg/lib/libaccel-config.sym | 6 ++++++ accfg/lib/libaccfg.c | 3 +++ accfg/lib/private.h | 1 + accfg/libaccel_config.h | 3 +++ test/dsa.c | 1 + test/dsa.h | 1 + test/libaccfg.c | 12 ++++++++++++ util/json.c | 4 ++++ 11 files changed, 54 insertions(+) -- 1.8.3.1

1 year, 2 months

3
17
0 / 0

[ANNOUNCE] accel-config-v3.1 release

by Thomas, Ramesh

Hello accel-config users! I am pleased to announce accel-config-v3.1 stable release. Changes: - Improved error messages and return values - Fix incorrect error return value from tool - Use portable data types and fix build issues in 32 bit targets - Allow -1 special value for wq->groupid and fix related error messages - Fix incorrect manpage text for config-wq - Remove duplicate functions from dsa test - Remove reference to non-interface header in interface header - Remove non-interface header from packaging You can clone this version using git from: https://github.com/intel/idxd-config.git Branch: stable Tag: accel-config-v3.1 https://github.com/intel/idxd-config/releases/tag/accel-config-v3.1 Link to stable branch: https://github.com/intel/idxd-config/tree/stable The zip and tar.gz of source code can be downloaded from: https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.1.zip https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.1.... Regards, Ramesh

1 year, 6 months

1
0
0 / 0

[PATCH] accel-config: Remove non-interface headers from packaging

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Non interface files were getting included into interface files causing compilation errors. Other non-interface files were getting included into packaging. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> Reported-by: Ziye Yang <ziye.yang(a)intel.com> --- accfg/lib/Makefile.am | 2 +- accfg/libaccel_config.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/accfg/lib/Makefile.am b/accfg/lib/Makefile.am index 2560314..64610e1 100644 --- a/accfg/lib/Makefile.am +++ b/accfg/lib/Makefile.am @@ -3,7 +3,7 @@ include $(top_srcdir)/Makefile.am.in %.pc: %.pc.in Makefile $(SED_PROCESS) -pkginclude_HEADERS = ../libaccel_config.h ../accfg.h +pkginclude_HEADERS = ../libaccel_config.h lib_LTLIBRARIES = libaccel-config.la DISTCLEANFILES = config.h diff --git a/accfg/libaccel_config.h b/accfg/libaccel_config.h index b7b64c4..94aef80 100644 --- a/accfg/libaccel_config.h +++ b/accfg/libaccel_config.h @@ -11,7 +11,6 @@ #include <errno.h> #include <limits.h> #include <uuid/uuid.h> -#include <util/filter.h> #ifdef __cplusplus extern "C" { -- 2.26.2

1 year, 6 months

2
1
0 / 0

[PATCH v3 0/4] Add support for ABI change in driver

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> v3: - Get driver unbind path from symlink in device/driver to support cases where devices get auto-bound v2: - Fixed naming of driver bind paths to not incorrectly use "portal" - Reworded commit messages correcting use of "portal" v1: (reworded) The new ABI changes the way devices are enumerated in sysfs and the device portals used to bind and unbind wqs to driver. These patches add support for the new ABI as well as compatibility with the ones in older kernels. Following are the modes that are supported. 1. New ABI: - Both iax and dsa devices will be in same bus /sys/bus/dsa - Different device portals for "user", "kernel" and "mdev" type wqs 2. Kernel 5.11 and 5.12: - iax and dsa will be in 2 separate buses - Bus, device and device portal names are same 3. Older kernels : - Has only dsa bus 4. OSV having kernel with CONFIG_INTEL_IDXD_COMPAT enabled: - Only one dsa bus - Both iax and dsa devices will be on dsa bus. - Only one device portal for all wq types Following are the changes added. - Detect compatibility mode during init and store bus type in device contexts. - Currently enumeration assumes device, bus and driver have the same name and relies on that to construct driver bind paths. Change it to dynamically construct the paths based on compatibility mode that was detected during init. Ramesh Thomas (4): accel-config: Fix some indentation and coding style issues accel-config: Add compatibility mode detection accel-config: Store bus type in device context accel-config: Add support for new device bind paths accfg/lib/libaccfg.c | 109 ++++++++++++++++++++++++++++++---------- accfg/lib/private.h | 70 +++++++++++++------------- accfg/libaccel_config.h | 37 +++++++------- util/sysfs.c | 5 +- util/sysfs.h | 13 ++--- 5 files changed, 147 insertions(+), 87 deletions(-) -- 2.26.2

1 year, 6 months

2
5
0 / 0

[PATCH v2 0/4] Add support for ABI change in driver

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> v2: - Fixed naming of driver bind paths to not incorrectly use "portal" - Reworded commit messages correcting use of "portal" v1: (reworded) The new ABI changes the way devices are enumerated in sysfs and the device portals used to bind and unbind wqs to driver. These patches add support for the new ABI as well as compatibility with the ones in older kernels. Following are the modes that are supported. 1. New ABI: - Both iax and dsa devices will be in same bus /sys/bus/dsa - Different device portals for "user", "kernel" and "mdev" type wqs 2. Kernel 5.11 and 5.12: - iax and dsa will be in 2 separate buses - Bus, device and device portal names are same 3. Older kernels : - Has only dsa bus 4. OSV having kernel with CONFIG_INTEL_IDXD_COMPAT enabled: - Only one dsa bus - Both iax and dsa devices will be on dsa bus. - Only one device portal for all wq types Following are the changes added. - Detect compatibility mode during init and store bus type in device contexts. - Currently enumeration assumes device, bus and driver have the same name and relies on that to construct driver bind paths. Change it to dynamically construct the paths based on compatibility mode that was detected during init. Ramesh Thomas (4): accel-config: Fix some indentation and coding style issues accel-config: Add compatibility mode detection accel-config: Store bus type in device context accel-config: Add support for new device bind paths accfg/lib/libaccfg.c | 77 +++++++++++++++++++++++++++++------------ accfg/lib/private.h | 70 +++++++++++++++++++------------------ accfg/libaccel_config.h | 37 ++++++++++---------- util/sysfs.c | 5 +-- util/sysfs.h | 13 +++---- 5 files changed, 119 insertions(+), 83 deletions(-) -- 2.26.2

1 year, 6 months

2
5
0 / 0

[PATCH 0/2] Fix some group id relaed issues

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> While configuring wqs and engines a special value of -1 for group id is used to dissociate those wqs and engines from groups. config-wq was not accepting -1 due to a bug and config-wq, though accepted it, printed an incorrect error message if invalid group id was passed. Ramesh Thomas (2): accel-config: Allow -1 wq->group-id accel-config: Fix an incorrect error message related to engine->group-id accfg/config_attr.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 2.26.2

1 year, 6 months

2
3
0 / 0

[PATCH] accel-config: Fix an incorrect man page text

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> config-wq manpage example was incorrectly referring to "config-device" Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> Reported-by: Lucas Van <Lucas.Van(a)intel.com> --- Documentation/accfg/accel-config-config-wq.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/accfg/accel-config-config-wq.txt b/Documentation/accfg/accel-config-config-wq.txt index 9fc2adf..aa4b0ab 100644 --- a/Documentation/accfg/accel-config-config-wq.txt +++ b/Documentation/accfg/accel-config-config-wq.txt @@ -14,7 +14,7 @@ SYNOPSIS EXAMPLE ------- -accel-config config-devie dsa0/wq0.0 --wq-size=16 +accel-config config-wq dsa0/wq0.0 --wq-size=16 OPTIONS -------- -- 2.26.2

1 year, 6 months

2
1
0 / 0

[PATCH v1 0/4] Add support for ABI change in driver

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> The new ABI changes the way devices are enumerated in sysfs and the driver portals used to bind and unbind. These patches add support for the new ABI as well as compatibility with the ones in older kernels. Following are the modes that are supported. 1. New ABI: - Both iax and dsa devices will be in same bus /sys/bus/dsa - Different driver portals for "user", "kernel" and "mdev" type wqs 2. Kernel 5.11 and 5.12: - iax and dsa will be in 2 separate buses - Bus, device and driver portal names are same 3. Older kernels : - Has only dsa bus 4. OSV having kernel with CONFIG_INTEL_IDXD_COMPAT enabled: - Only one dsa bus - Both iax and dsa devices will be on dsa bus. - Only one driver portal for all wq types Following are the changes added. - Detect compatibility mode during init and store bus, driver and portal details in device contexts. - Currently enumeration assumes device, bus and driver have the same name and relies on that to construct paths. Change it to dynamically construct paths based on compatibility mode that was detected during init. Ramesh Thomas (4): accel-config: Fix some indentation and coding style issues accel-config: Add compatibility mode detection accel-config: Store bus type in device context accel-config: Add support for new driver portals accfg/lib/libaccfg.c | 80 +++++++++++++++++++++++++++++------------ accfg/lib/private.h | 70 ++++++++++++++++++------------------ accfg/libaccel_config.h | 37 +++++++++---------- util/sysfs.c | 5 +-- util/sysfs.h | 13 +++---- 5 files changed, 122 insertions(+), 83 deletions(-) -- 2.26.2

1 year, 6 months

3
6
0 / 0

[PATCH 1/1] accel-config: Fix idxd modprobe issue with idxd_mdev for user test

by Tony Zhu

User test will clean the idxd module in the memory moving tests. As idxd_mdev is supported and it depends on idxd, should change the clean as idxd_mdev. To improve the robust and compatibility to old kernel, we add the condition to check if the module is loaded and keep idxd reset. Signed-off-by: Tony Zhu <tony.zhu(a)intel.com> --- test/common | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test/common b/test/common index a60bec2..4bd4ed3 100644 --- a/test/common +++ b/test/common @@ -99,7 +99,14 @@ check_prereq() # _cleanup() { - modprobe -r idxd + lsmod | grep -q "idxd_mdev" && { + modprobe -r idxd_mdev + sleep 1 + } + lsmod | grep -q "idxd" && { + modprobe -r idxd + sleep 1 + } modprobe idxd } @@ -158,4 +165,4 @@ wq_mode2name() echo "UNKNOWN" ;; esac -} \ No newline at end of file +} -- 2.27.0

1 year, 6 months

1
0
0 / 0

[PATCH 1/1] accel-config: Fix idxd modprobe issue with idxd_mdev for user test

by Tony Zhu

User test will clean the idxd module in the memory moving tests. As idxd_mdev is supported and it depends on idxd, should change the clean as idxd_mdev. To improve the robust and compatibility to old kernel, we add the condition to check if the module is loaded and keep idxd reset. Signed-off-by: Tony Zhu <tony.zhu(a)intel.com> --- test/common | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/test/common b/test/common index a60bec2..d4041e3 100644 --- a/test/common +++ b/test/common @@ -99,8 +99,16 @@ check_prereq() # _cleanup() { - modprobe -r idxd - modprobe idxd + lsmod | grep -q "idxd_mdev" && { + modprobe -r idxd_mdev + sleep 1 + modprobe idxd_mdev + } + lsmod | grep -q "idxd" && { + modprobe -r idxd + sleep 1 + modprobe idxd + } } # json2var @@ -158,4 +166,4 @@ wq_mode2name() echo "UNKNOWN" ;; esac -} \ No newline at end of file +} -- 2.27.0

1 year, 6 months

3
2
0 / 0

2022

2021

2020

Accel-config March 2021