May 2021 - Accel-config

[PATCH 0/5] accel-config: Add wq ats_disable support

by Xiaochen Shen

Upstream kernel 5.11 introduced ATS disable knob for work queues in commit 92de5fa2dc39 ("dmaengine: idxd: add ATS disable knob for work queues"). Accel-config needs to add support to match kernel driver change. Add wq ats_disable support in library, configuration file, json interface, and config-wq command. Add unit test and documentation for wq option ats_disable. Xiaochen Shen (5): accel-config: Add ats_disable wq function in lib accel-config: Add ats_disable in config and json accel-config: Add ats_disable attr to config-wq command accel-config: Add ats_disable unit test accel-config: Add documentation for wq option ats-disable Documentation/accfg/accel-config-config-wq.txt | 6 ++++++ accfg/config.c | 1 + accfg/config_attr.c | 16 ++++++++++++++++ accfg/lib/libaccel-config.sym | 6 ++++++ accfg/lib/libaccfg.c | 3 +++ accfg/lib/private.h | 1 + accfg/libaccel_config.h | 3 +++ test/dsa.c | 1 + test/dsa.h | 1 + test/libaccfg.c | 12 ++++++++++++ util/json.c | 4 ++++ 11 files changed, 54 insertions(+) -- 1.8.3.1

1 year, 2 months

3
17
0 / 0

[ANNOUNCE] accel-config-v3.2 release

by Thomas, Ramesh

Hello accel-config users! I am pleased to announce accel-config-v3.2 stable release. Changes: - Adds support for new device bind paths retaining compatibility with older kernels - Adds support for UACCE interface to access char device - Adds debian packaging support Fixes: - Refactored filtering, config and listing code fixing several issues in those areas - Support all 256 bits of op_cap - Fix incorrect return values - Made rmoving all mdevs more intuitive You can clone this version using git from: https://github.com/intel/idxd-config.git Branch: stable Tag: accel-config-v3.2 https://github.com/intel/idxd-config/releases/tag/accel-config-v3.2 Link to stable branch: https://github.com/intel/idxd-config/tree/stable The zip and tar.gz of source code can be downloaded from: https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.2.zip https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.2.... Regards, Ramesh

1 year, 4 months

1
0
0 / 0

[PATCH] accel-config: Refactor handling of cdev_minor at wq enable/disable

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> cdev_minor depends on wq being enabled, of type "user" and in non uacce mode. Update the cached value of cdev_minor when wq state changes by reading sysfs. If the read fails, a negative value will be stored indicating it is not valid for the current state of the wq. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/lib/libaccfg.c | 64 ++++++-------------------------------------- 1 file changed, 8 insertions(+), 56 deletions(-) diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index 0796f08..1463a4d 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -1925,62 +1925,16 @@ ACCFG_EXPORT int accfg_wq_priority_boundary(struct accfg_wq *wq) static int accfg_wq_retrieve_cdev_minor(struct accfg_wq *wq) { + int dfd; struct accfg_ctx *ctx = accfg_wq_get_ctx(wq); - char *path = wq->wq_buf; - char buf[SYSFS_ATTR_SIZE]; - int rc; - - rc = sprintf(wq->wq_buf, "%s/%s", wq->wq_path, "cdev_minor"); - if (rc < 0) - return -errno; - - if (sysfs_read_attr(ctx, path, buf) < 0) { - err(ctx, "%s: retrieve cdev minor failed: '%s': %s\n", - __func__, wq->wq_path, strerror(errno)); - return -errno; - } - - wq->cdev_minor = atoi(buf); - return 0; -} -static int accfg_wq_post_enable(struct accfg_wq *wq) -{ - enum accfg_wq_type type; - int rc; - - type = accfg_wq_get_type(wq); - - if (type == ACCFG_WQT_USER) { - rc = accfg_wq_retrieve_cdev_minor(wq); - if (rc < 0) - return rc; - } - - return 0; -} - -static int accfg_wq_post_disable(struct accfg_wq *wq) -{ - enum accfg_wq_type type; - - type = accfg_wq_get_type(wq); - - if (type == ACCFG_WQT_USER) - wq->cdev_minor = -1; + dfd = open(wq->wq_path, O_PATH); + if (dfd < 0) + return -ENXIO; - return 0; -} + wq->cdev_minor = accfg_get_param_long(ctx, dfd, "cdev_minor"); -static int accfg_wq_control_post_processing(struct accfg_wq *wq, - enum accfg_control_flag flag) -{ - if (flag == ACCFG_WQ_ENABLE) - return accfg_wq_post_enable(wq); - else if (flag == ACCFG_WQ_DISABLE) - return accfg_wq_post_disable(wq); - else - return -EINVAL; + close(dfd); return 0; } @@ -2052,10 +2006,8 @@ static int accfg_wq_control(struct accfg_wq *wq, enum accfg_control_flag flag, return -ENXIO; } - /* post processing */ - rc = accfg_wq_control_post_processing(wq, flag); - if (rc < 0) - return rc; + if (accfg_wq_retrieve_cdev_minor(wq)) + return -ENXIO; return 0; } -- 2.26.3

1 year, 4 months

2
1
0 / 0

[PATCH v1 1/2] accel-config: Remove cdev related code

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> cdev major/minor method of opening idxd char dev will be deprecated. Currently even in non uacce mode the char dev is opened using the device name at /dev/dsa that is returned by accfg_wq_get_user_dev_path() Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/lib/libaccel-config.sym | 2 - accfg/lib/libaccfg.c | 80 ----------------------------------- accfg/lib/private.h | 2 - accfg/libaccel_config.h | 2 - util/json.c | 11 ----- 5 files changed, 97 deletions(-) diff --git a/accfg/lib/libaccel-config.sym b/accfg/lib/libaccel-config.sym index aecc98b..3e86274 100644 --- a/accfg/lib/libaccel-config.sym +++ b/accfg/lib/libaccel-config.sym @@ -28,7 +28,6 @@ LIBACCFG_1 { accfg_device_get_state; accfg_device_get_max_tokens; accfg_device_get_max_batch_size; - accfg_device_get_cdev_major; accfg_device_is_active; accfg_device_get_token_limit; accfg_device_set_token_limit; @@ -69,7 +68,6 @@ LIBACCFG_1 { accfg_wq_get_size; accfg_wq_get_block_on_fault; accfg_wq_get_state; - accfg_wq_get_cdev_minor; accfg_wq_get_type; accfg_wq_get_threshold; accfg_wq_set_size; diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index 0796f08..f0f6bb2 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -581,7 +581,6 @@ static void *add_device(void *parent, int id, const char *ctl_base, "pasid_enabled"); device->max_tokens = accfg_get_param_long(ctx, dfd, "max_tokens"); device->token_limit = accfg_get_param_long(ctx, dfd, "token_limit"); - device->cdev_major = accfg_get_param_long(ctx, dfd, "cdev_major"); device->version = accfg_get_param_unsigned_llong(ctx, dfd, "version"); device->device_path = realpath(ctl_base, NULL); close(dfd); @@ -727,7 +726,6 @@ static void *add_wq(void *parent, int id, const char *wq_base, "block_on_fault"); wq->mode = accfg_get_param_str(ctx, dfd, "mode"); wq->state = accfg_get_param_str(ctx, dfd, "state"); - wq->cdev_minor = accfg_get_param_long(ctx, dfd, "cdev_minor"); wq_type = accfg_get_param_str(ctx, dfd, "type"); wq->name = accfg_get_param_str(ctx, dfd, "name"); wq->threshold = accfg_get_param_long(ctx, dfd, "threshold"); @@ -1378,12 +1376,6 @@ ACCFG_EXPORT unsigned int accfg_device_get_token_limit( return device->token_limit; } -ACCFG_EXPORT unsigned int accfg_device_get_cdev_major( - struct accfg_device *device) -{ - return device->cdev_major; -} - ACCFG_EXPORT unsigned int accfg_device_get_version( struct accfg_device *device) { @@ -1859,11 +1851,6 @@ ACCFG_EXPORT const char *accfg_wq_get_devname(struct accfg_wq *wq) return devpath_to_devname(wq->wq_path); } -ACCFG_EXPORT int accfg_wq_get_cdev_minor(struct accfg_wq *wq) -{ - return wq->cdev_minor; -} - ACCFG_EXPORT enum accfg_wq_type accfg_wq_get_type(struct accfg_wq *wq) { return wq->type; @@ -1923,68 +1910,6 @@ ACCFG_EXPORT int accfg_wq_priority_boundary(struct accfg_wq *wq) return 0; } -static int accfg_wq_retrieve_cdev_minor(struct accfg_wq *wq) -{ - struct accfg_ctx *ctx = accfg_wq_get_ctx(wq); - char *path = wq->wq_buf; - char buf[SYSFS_ATTR_SIZE]; - int rc; - - rc = sprintf(wq->wq_buf, "%s/%s", wq->wq_path, "cdev_minor"); - if (rc < 0) - return -errno; - - if (sysfs_read_attr(ctx, path, buf) < 0) { - err(ctx, "%s: retrieve cdev minor failed: '%s': %s\n", - __func__, wq->wq_path, strerror(errno)); - return -errno; - } - - wq->cdev_minor = atoi(buf); - return 0; -} - -static int accfg_wq_post_enable(struct accfg_wq *wq) -{ - enum accfg_wq_type type; - int rc; - - type = accfg_wq_get_type(wq); - - if (type == ACCFG_WQT_USER) { - rc = accfg_wq_retrieve_cdev_minor(wq); - if (rc < 0) - return rc; - } - - return 0; -} - -static int accfg_wq_post_disable(struct accfg_wq *wq) -{ - enum accfg_wq_type type; - - type = accfg_wq_get_type(wq); - - if (type == ACCFG_WQT_USER) - wq->cdev_minor = -1; - - return 0; -} - -static int accfg_wq_control_post_processing(struct accfg_wq *wq, - enum accfg_control_flag flag) -{ - if (flag == ACCFG_WQ_ENABLE) - return accfg_wq_post_enable(wq); - else if (flag == ACCFG_WQ_DISABLE) - return accfg_wq_post_disable(wq); - else - return -EINVAL; - - return 0; -} - static bool accfg_wq_state_expected(struct accfg_wq *wq, enum accfg_control_flag flag) { @@ -2052,11 +1977,6 @@ static int accfg_wq_control(struct accfg_wq *wq, enum accfg_control_flag flag, return -ENXIO; } - /* post processing */ - rc = accfg_wq_control_post_processing(wq, flag); - if (rc < 0) - return rc; - return 0; } diff --git a/accfg/lib/private.h b/accfg/lib/private.h index 7f3162e..dc12388 100644 --- a/accfg/lib/private.h +++ b/accfg/lib/private.h @@ -50,7 +50,6 @@ struct accfg_device { int configurable; int max_tokens; unsigned int token_limit; - unsigned int cdev_major; unsigned int version; uint64_t max_transfer_size; uint64_t opcap; @@ -118,7 +117,6 @@ struct accfg_wq { int priv; int priority; int block_on_fault; - int cdev_minor; unsigned int threshold; char *mode; char *name; diff --git a/accfg/libaccel_config.h b/accfg/libaccel_config.h index 5b37790..44fb38c 100644 --- a/accfg/libaccel_config.h +++ b/accfg/libaccel_config.h @@ -183,7 +183,6 @@ enum accfg_device_state accfg_device_get_state(struct accfg_device *device); unsigned int accfg_device_get_max_tokens(struct accfg_device *device); unsigned int accfg_device_get_max_batch_size(struct accfg_device *device); unsigned int accfg_device_get_token_limit(struct accfg_device *device); -unsigned int accfg_device_get_cdev_major(struct accfg_device *device); unsigned int accfg_device_get_version(struct accfg_device *device); int accfg_device_get_clients(struct accfg_device *device); int accfg_device_set_token_limit(struct accfg_device *dev, int val); @@ -258,7 +257,6 @@ int accfg_wq_get_priority(struct accfg_wq *wq); unsigned int accfg_wq_get_priv(struct accfg_wq *wq); int accfg_wq_get_block_on_fault(struct accfg_wq *wq); enum accfg_wq_state accfg_wq_get_state(struct accfg_wq *wq); -int accfg_wq_get_cdev_minor(struct accfg_wq *wq); const char *accfg_wq_get_type_name(struct accfg_wq *wq); enum accfg_wq_type accfg_wq_get_type(struct accfg_wq *wq); unsigned int accfg_wq_get_max_batch_size(struct accfg_wq *wq); diff --git a/util/json.c b/util/json.c index 4fb43d2..d1015c3 100644 --- a/util/json.c +++ b/util/json.c @@ -324,11 +324,6 @@ struct json_object *util_device_to_json(struct accfg_device *device, json_object_object_add(jdevice, "pasid_enabled", jobj); } - jobj = json_object_new_int(accfg_device_get_cdev_major(device)); - if (!jobj) - goto err; - json_object_object_add(jdevice, "cdev_major", jobj); - jobj = json_object_new_int(accfg_device_get_clients(device)); if (!jobj) goto err; @@ -439,12 +434,6 @@ struct json_object *util_wq_to_json(struct accfg_wq *wq, if (jobj) json_object_object_add(jaccfg, "max_transfer_size", jobj); - if (!(flags & UTIL_JSON_SAVE) && accfg_wq_get_cdev_minor(wq) >= 0) { - jobj = json_object_new_int(accfg_wq_get_cdev_minor(wq)); - if (jobj) - json_object_object_add(jaccfg, "cdev_minor", jobj); - } - jobj = json_object_new_string(wq_type_str[accfg_wq_get_type(wq)]); if (jobj) json_object_object_add(jaccfg, "type", jobj); -- 2.26.3

1 year, 4 months

4
9
0 / 0

[PATCH v1] accel-config: Update with new driver name changes

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Update with driver name changes for wqs in idxd kernel module. "idxd-kernel-portal" changes to "dmaengine", "idxd-user-portal" changes to "user" and "idxd-mdev-portal" changes to "mdev". Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/lib/libaccfg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index 12a97f5..0796f08 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -36,9 +36,9 @@ (d)->bus_type_str : accfg_wq_device_portals[(w)->type]) char *accfg_wq_device_portals[] = { - [ACCFG_WQT_KERNEL] = "idxd-kernel-portal", - [ACCFG_WQT_USER] = "idxd-user-portal", - [ACCFG_WQT_MDEV] = "idxd-mdev-portal", + [ACCFG_WQT_KERNEL] = "dmaengine", + [ACCFG_WQT_USER] = "user", + [ACCFG_WQT_MDEV] = "mdev", NULL }; -- 2.26.3

1 year, 4 months

2
1
0 / 0

[PATCH v1 0/2] Make remove-mdev command more intuitive

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> remove-mdev has an option to remove all mdevs if null uuid is passed as parameter. Null uuid is not easy for user to type in because it is long and needs to be in the uuid format. Change the command to take "all" as a special parameter value to indicate removal of all mdeves. Ramesh Thomas (2): accel-config: Make remove-mdev cmd "remove all" option more intuitive accel-config: Update manpages with change to remove-mdev command Documentation/accfg/accel-config-remove-mdev.txt | 5 ++--- accfg/mdev.c | 6 ++++-- 2 files changed, 6 insertions(+), 5 deletions(-) -- 2.26.3

1 year, 4 months

2
3
0 / 0

[PATCH v1 0/6] Update API to get 256 bits op_cap

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Remove existing API that assumes op_cap is 64 bits. New API returns 256 bits. Update json implementation to use the new API and print 256 bits. Fix some issues found in other areas of code during implementation. Ramesh Thomas (6): accel-config: Remove duplicated function accel-config: Fix an inconsistent error return value accel-config: Free some allocated memory that were not being freed accel-config: Remove existing op_cap API to be replaced with new one accel-config: Add new API to support 256 bits op_cap accel-config: Call new op_cap API in json implementation accfg/lib/libaccel-config.sym | 7 +++-- accfg/lib/libaccfg.c | 56 ++++++++++++++++++++++++++--------- accfg/libaccel_config.h | 7 ++++- accfg/list.c | 2 +- util/json.c | 35 +++++++--------------- util/json.h | 2 -- 6 files changed, 64 insertions(+), 45 deletions(-) -- 2.26.3

1 year, 4 months

2
7
0 / 0

[PATCH v1 0/8] Fix bugs in filter, list, config, enable areas

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> These patches fixes many of the bugs that were seen due to the addition of iax. While fixing the reqported issues found that the existing code was using assumptions that are obsolete. Many parts of the filter, list, config and enable/disable areas have been rewritten considering latest design changes. This simplifies the implementation and would make future maintenance easier. Ramesh Thomas (8): accel-config: Fix some indentation and coding convention errors accel-config: Fix wrong return values in functions accel-config: Rewrite filter functions accel-config: Rewrite listing functions accel-config: Rewrite device selection using new filter functions accel-config: Skip negative fields in listings accel-config: Return error if no args accel-config: Do not return error if help was specifically called accfg/accel-config.c | 2 +- accfg/config_attr.c | 154 +++++------------- accfg/enable.c | 106 +++++------- accfg/list.c | 278 +++++++++++++++---------------- util/filter.c | 379 +++++++++++++++++++++---------------------- util/filter.h | 42 ++--- util/json.c | 36 ++-- util/json.h | 1 - util/parse-options.c | 6 +- 9 files changed, 436 insertions(+), 568 deletions(-) -- 2.26.3

1 year, 4 months

2
9
0 / 0

2022

2021

2020

Accel-config May 2021