July 2021 - Accel-config

by Thomas, Ramesh

Hello accel-config users! I am pleased to announce accel-config-v3.4.1 stable release. This is a bug fix release with changes in traffic-class configuration Changes: - Bug fix related to traffic-class in listing - Ignore or return error if traffic-class is configured in device rev < 0x200 You can clone this version using git from: https://github.com/intel/idxd-config.git Branch: stable Tag: accel-config-v3.4.1 https://github.com/intel/idxd-config/releases/tag/accel-config-v3.4.1 Link to stable branch: https://github.com/intel/idxd-config/tree/stable The zip and tar.gz of source code can be downloaded from: https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.4.... https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.4.... Regards, Ramesh

9 months, 3 weeks

1
0
0 / 0

[PATCH 0/2] Do not set traffic_class if dev ver < 200

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> config-group command return error and load-config silently ignores setting of traffic_class attributes if device version < 0x200 Ramesh Thomas (2): accel-config: Do not allow configuring traffic_class for dev ver < 0x200 accel-config: Ignore traffic_class in load-config if dev ver < 0x200 accfg/config.c | 21 +++++++++++++++++++-- accfg/config_attr.c | 9 +++++++++ 2 files changed, 28 insertions(+), 2 deletions(-) -- 2.26.3

9 months, 3 weeks

2
3
0 / 0

[PATCH] accel-config: Fix a bug in list command

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> The check for ACCFG_DEVICE_IAX to avoid reading some dsa device specific attributes was misplaced. It excluded lines that should be included while included reading of traffic_class_a which should be read even for iax devices. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/list.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/accfg/list.c b/accfg/list.c index d03cf30..7fec813 100644 --- a/accfg/list.c +++ b/accfg/list.c @@ -66,11 +66,12 @@ static struct json_object *group_to_json(struct accfg_group *group, goto err; json_object_object_add(jgroup, "dev", jobj); - jobj = json_object_new_int(accfg_group_get_tokens_reserved(group)); - if (!jobj) - goto err; if (accfg_device_get_type(dev) != ACCFG_DEVICE_IAX) { + jobj = json_object_new_int(accfg_group_get_tokens_reserved(group)); + if (!jobj) + goto err; + json_object_object_add(jgroup, "tokens_reserved", jobj); jobj = json_object_new_int(accfg_group_get_use_token_limit(group)); if (!jobj) @@ -82,12 +83,13 @@ static struct json_object *group_to_json(struct accfg_group *group, goto err; json_object_object_add(jgroup, "tokens_allowed", jobj); - jobj = json_object_new_int(accfg_group_get_traffic_class_a( - group)); - if (!jobj) - goto err; } + jobj = json_object_new_int(accfg_group_get_traffic_class_a( + group)); + if (!jobj) + goto err; + json_object_object_add(jgroup, "traffic_class_a", jobj); jobj = json_object_new_int(accfg_group_get_traffic_class_b( group)); -- 2.26.3

9 months, 3 weeks

2
1
0 / 0

[ANNOUNCE] accel-config-v3.4 release

by Thomas, Ramesh

Hello accel-config users! I am pleased to announce accel-config-v3.4 stable release. Changes: - Add per-wq ATS disable support - Add extended error status reporting - Created local copy of UAPI header file idxd.h from /usr/include - Bug fixes You can clone this version using git from: https://github.com/intel/idxd-config.git Branch: stable Tag: accel-config-v3.4 https://github.com/intel/idxd-config/releases/tag/accel-config-v3.4 Link to stable branch: https://github.com/intel/idxd-config/tree/stable The zip and tar.gz of source code can be downloaded from: https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.4.zip https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.4.... Regards, Ramesh

9 months, 4 weeks

1
0
0 / 0

[PATCH] accel-config: Set wq name after setting mdev type

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Setting mdev type resets the name. After setting mdev set the name again from the template. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- test/libaccfg.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/libaccfg.c b/test/libaccfg.c index 57d97f2..516adbc 100644 --- a/test/libaccfg.c +++ b/test/libaccfg.c @@ -764,7 +764,8 @@ static int mdev_test(struct accfg_ctx *ctx, struct accfg_device *device, return 0; } -static int set_mdev_type(struct accfg_ctx *ctx, struct accfg_wq *wq) +static int set_mdev_type(struct accfg_ctx *ctx, struct accfg_wq *wq, + struct wq_parameters *wq_param) { int rc; @@ -772,6 +773,10 @@ static int set_mdev_type(struct accfg_ctx *ctx, struct accfg_wq *wq) if (rc) fprintf(stderr, "Error setting mdev type\n"); + rc = accfg_wq_set_str_name(wq, wq_param->name); + if (rc) + fprintf(stderr, "Error setting name for mdev type wq\n"); + return rc; } @@ -810,7 +815,7 @@ static int test_mdev_1swq(struct accfg_ctx *ctx) if (rc) return rc; - rc = set_mdev_type(ctx, test_ctx.wq[2]); + rc = set_mdev_type(ctx, test_ctx.wq[2], test_ctx.wq_param[2]); if (rc) return rc; @@ -843,7 +848,7 @@ static int test_mdev_1dwq(struct accfg_ctx *ctx) if (rc) return rc; - rc = set_mdev_type(ctx, test_ctx.wq[3]); + rc = set_mdev_type(ctx, test_ctx.wq[3], test_ctx.wq_param[3]); if (rc) return rc; -- 2.26.3

10 months

2
1
0 / 0

[PATCH 0/2] Keep a local copy of UAPI header file

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Use a local copy of the UAPI header file to avoid dependency on kernel version in build system. Ramesh Thomas (2): accel-config: Duplicate the UAPI header file locally accel-config: Change path of idxd.h to local copy accfg/idxd.h | 325 +++++++++++++++++++++++++++++++++++++++++++ accfg/lib/libaccfg.c | 2 +- test/dsa.c | 2 +- test/dsa.h | 2 +- test/libaccfg.c | 2 +- test/prep.c | 2 +- 6 files changed, 330 insertions(+), 5 deletions(-) create mode 100644 accfg/idxd.h -- 2.26.3

10 months

2
3
0 / 0

[PATCH] accel-config: Replicate driver error codes in idxd.h in library

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Duplicate the driver error code related constants defined in idxd.h in library to avoid dependency on kernel versions. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/lib/libaccfg.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index f21cab5..1a06d9c 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -27,7 +27,6 @@ #include <accfg/libaccel_config.h> #include <fnmatch.h> #include "private.h" -#include <linux/idxd.h> #define MDEV_POSTFIX "mdev_supported_types" #define IDXD_DRIVER_BIND_PATH "/sys/bus/dsa/drivers/idxd" @@ -74,6 +73,29 @@ enum { ACCFG_CMD_STATUS_ERROR = 0x80010000, }; +/* driver error codes from kernel idxd.h */ +enum idxd_scmd_stat { + IDXD_SCMD_DEV_ENABLED = 0x80000010, + IDXD_SCMD_DEV_NOT_ENABLED = 0x80000020, + IDXD_SCMD_WQ_ENABLED = 0x80000021, + IDXD_SCMD_DEV_DMA_ERR = 0x80020000, + IDXD_SCMD_WQ_NO_GRP = 0x80030000, + IDXD_SCMD_WQ_NO_NAME = 0x80040000, + IDXD_SCMD_WQ_NO_SVM = 0x80050000, + IDXD_SCMD_WQ_NO_THRESH = 0x80060000, + IDXD_SCMD_WQ_PORTAL_ERR = 0x80070000, + IDXD_SCMD_WQ_RES_ALLOC_ERR = 0x80080000, + IDXD_SCMD_PERCPU_ERR = 0x80090000, + IDXD_SCMD_DMA_CHAN_ERR = 0x800a0000, + IDXD_SCMD_CDEV_ERR = 0x800b0000, + IDXD_SCMD_WQ_NO_SWQ_SUPPORT = 0x800c0000, + IDXD_SCMD_WQ_NONE_CONFIGURED = 0x800d0000, + IDXD_SCMD_WQ_NO_SIZE = 0x800e0000, +}; + +#define IDXD_SCMD_SOFTERR_MASK 0x80000000 +#define IDXD_SCMD_SOFTERR_SHIFT 16 + #define SCMD_STAT(x) (((x) & ~IDXD_SCMD_SOFTERR_MASK) >> \ IDXD_SCMD_SOFTERR_SHIFT) -- 2.26.3

10 months

3
9
0 / 0

[PATCH] accel-config: Fix ats_disable unit test

by Xiaochen Shen

Don't fail test if per wq ats disable is not supported. Fixes: 7de00a1e1a58 ("accel-config: Add ats_disable unit test") Signed-off-by: Xiaochen Shen <xiaochen.shen(a)intel.com> --- test/libaccfg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/libaccfg.c b/test/libaccfg.c index 7849d63..1816f8e 100644 --- a/test/libaccfg.c +++ b/test/libaccfg.c @@ -254,10 +254,14 @@ static int config_wq(struct accfg_ctx *ctx, struct accfg_device *device, SET_ERR(rc, accfg_wq_set_max_batch_size(wq, wq_param->max_batch_size)); SET_ERR(rc, accfg_wq_set_max_transfer_size(wq, wq_param->max_transfer_size)); - SET_ERR(rc, accfg_wq_set_ats_disable(wq, wq_param->ats_disable)); if (wq_param->threshold) SET_ERR(rc, accfg_wq_set_threshold(wq, wq_param->threshold)); + SET_ERR(rc, accfg_wq_set_ats_disable(wq, wq_param->ats_disable)); + /* Don't fail test if per wq ats disable is not supported */ + if (rc == -EOPNOTSUPP) + rc = 0; + return rc; } -- 1.8.3.1

10 months, 1 week

2
1
0 / 0

[PATCH] accel-config: Provide compatibility for legacy mode driver names

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Check for presence of /sys/bus/dsa/drivers/idxd and use legacy driver names if not present. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- accfg/lib/libaccfg.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index f21cab5..592c22c 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -36,6 +36,13 @@ #define IDXD_WQ_DEVICE_PORTAL(d, w) ((d)->ctx->compat ? \ (d)->bus_type_str : accfg_wq_device_portals[(w)->type]) +char *accfg_wq_device_portals_legacy[] = { + [ACCFG_WQT_KERNEL] = "idxd-kernel-portal", + [ACCFG_WQT_USER] = "idxd-user-portal", + [ACCFG_WQT_MDEV] = "idxd-mdev-portal", + NULL +}; + char *accfg_wq_device_portals[] = { [ACCFG_WQT_KERNEL] = "dmaengine", [ACCFG_WQT_USER] = "user", @@ -398,8 +405,15 @@ ACCFG_EXPORT int accfg_new(struct accfg_ctx **ctx) c->refcount = 1; log_init(&c->ctx, "libaccfg", "ACCFG_LOG"); c->timeout = 5000; - if (access(IDXD_DRIVER_BIND_PATH, R_OK)) + if (access(IDXD_DRIVER_BIND_PATH, R_OK)) { c->compat = true; + accfg_wq_device_portals[ACCFG_WQT_KERNEL] = + accfg_wq_device_portals_legacy[ACCFG_WQT_KERNEL]; + accfg_wq_device_portals[ACCFG_WQT_USER] = + accfg_wq_device_portals_legacy[ACCFG_WQT_USER]; + accfg_wq_device_portals[ACCFG_WQT_MDEV] = + accfg_wq_device_portals_legacy[ACCFG_WQT_MDEV]; + } list_head_init(&c->devices); -- 2.26.3

10 months, 1 week

3
3
0 / 0

[PATCH v4 0/3] Add support to get enhanced details of error

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Add support to take a snapshot of error details containing hw/sw error code and associated devices. Added new API to retreive the saved information. Using the new API accel-config prints a more detailed error message at exit. v2: Use masks and other constants defined in idxd.h Clear cmd_status during device initialization v3: Specify if the error is from driver or library v4: Specify if the error is platform configuration error Don't fail if clearing cmd_status is RO to support older drivers Ramesh Thomas (3): accel-config: Add APIs to get details of last error and associated devices accel-config: Print details of error at exit using new last_error API accel-config: Reset cmd_status during device init accfg/accel-config.c | 25 ++++- accfg/enable.c | 25 +---- accfg/lib/libaccel-config.sym | 6 ++ accfg/lib/libaccfg.c | 187 ++++++++++++++++++++++++++++++---- accfg/lib/private.h | 9 ++ accfg/libaccel_config.h | 9 +- 6 files changed, 219 insertions(+), 42 deletions(-) -- 2.26.3

10 months, 1 week

2
4
0 / 0

2022

2021

2020

Accel-config July 2021