July 2021 - Accel-config

[PATCH 1/1] accel-config: Remove traffic class setting from config file

by Tony Zhu

Driver set GRPCFG traffic class to value of 1 for best performance on current generation of accelerators. Remove the traffic class in config file. Signed-off-by: Tony Zhu <tony.zhu(a)intel.com> --- test/configs/2g2q_user_1.conf | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/configs/2g2q_user_1.conf b/test/configs/2g2q_user_1.conf index 32a033a..7c55e72 100644 --- a/test/configs/2g2q_user_1.conf +++ b/test/configs/2g2q_user_1.conf @@ -8,8 +8,6 @@ "tokens_reserved":0, "use_token_limit":0, "tokens_allowed":8, - "traffic_class_a":0, - "traffic_class_b":1, "grouped_workqueues":[ { "dev":"wq0.0", @@ -39,8 +37,6 @@ "tokens_reserved":0, "use_token_limit":0, "tokens_allowed":8, - "traffic_class_a":0, - "traffic_class_b":1, "grouped_workqueues":[ { "dev":"wq0.1", @@ -70,16 +66,12 @@ "tokens_reserved":0, "use_token_limit":0, "tokens_allowed":8, - "traffic_class_a":0, - "traffic_class_b":1 }, { "dev":"group0.3", "tokens_reserved":0, "use_token_limit":0, "tokens_allowed":8, - "traffic_class_a":0, - "traffic_class_b":1 } ] } -- 2.17.1

11 months, 2 weeks

2
1
0 / 0

[PATCH v3 0/3] Add support to get enhanced details of error

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Add support to take a snapshot of error details containing hw/sw error code and associated devices. Added new API to retreive the saved information. Using the new API accel-config prints a more detailed error message at exit. v2: Use masks and other constants defined in idxd.h Clear cmd_status during device initialization v3: Specify if the error is from driver or library Ramesh Thomas (3): accel-config: Add APIs to get details of last error and associated devices accel-config: Print details of error at exit using new last_error API accel-config: Reset cmd_status during device init accfg/accel-config.c | 25 ++++- accfg/enable.c | 25 +---- accfg/lib/libaccel-config.sym | 6 ++ accfg/lib/libaccfg.c | 183 ++++++++++++++++++++++++++++++---- accfg/lib/private.h | 9 ++ accfg/libaccel_config.h | 9 +- 6 files changed, 215 insertions(+), 42 deletions(-) -- 2.26.3

11 months, 3 weeks

2
4
0 / 0

[PATCH v2 0/3] Add support to get enhanced details of error

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Add support to take a snapshot of error details containing hw/sw error code and associated devices. Added new API to retreive the saved information. Using the new API accel-config prints a more detailed error message at exit. v2: Use masks and other constants defined in idxd.h Clear cmd_status during device initialization Ramesh Thomas (3): accel-config: Add APIs to get details of last error and associated devices accel-config: Print details of error at exit using new last_error API accel-config: Reset cmd_status during device init accfg/accel-config.c | 25 ++++- accfg/enable.c | 25 +---- accfg/lib/libaccel-config.sym | 6 ++ accfg/lib/libaccfg.c | 183 ++++++++++++++++++++++++++++++---- accfg/lib/private.h | 9 ++ accfg/libaccel_config.h | 9 +- 6 files changed, 215 insertions(+), 42 deletions(-) -- 2.26.3

11 months, 3 weeks

3
6
0 / 0

[PATCH v2] accel-config: Do not set group traffic class for hw ver < 0x200

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> A default value will be set by driver for hw versions < 0x200 Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- v2: Use enum for device versions accfg/libaccel_config.h | 5 +++++ test/libaccfg.c | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/accfg/libaccel_config.h b/accfg/libaccel_config.h index a74571c..f8b9bf9 100644 --- a/accfg/libaccel_config.h +++ b/accfg/libaccel_config.h @@ -27,6 +27,11 @@ extern "C" { #define WQ_PRIORITY_LIMIT 15 #define UUID_ZERO "00000000-0000-0000-0000-000000000000" +enum accfg_device_version { + ACCFG_DEVICE_VERSION_1 = 0x100, + ACCFG_DEVICE_VERSION_2 = 0x200, +}; + /* no need to save device state */ enum accfg_device_type { ACCFG_DEVICE_DSA = 0, diff --git a/test/libaccfg.c b/test/libaccfg.c index c37b71c..7849d63 100644 --- a/test/libaccfg.c +++ b/test/libaccfg.c @@ -186,6 +186,10 @@ static int config_group(struct accfg_ctx *ctx, struct accfg_device *device, group_param->tokens_allowed)); SET_ERR(rc, accfg_group_set_use_token_limit(group, group_param->use_token_limit)); + + if (accfg_device_get_version(device) < ACCFG_DEVICE_VERSION_2) + return rc; + SET_ERR(rc, accfg_group_set_traffic_class_a(group, group_param->traffic_class_a)); SET_ERR(rc, accfg_group_set_traffic_class_b(group, @@ -217,6 +221,9 @@ static int check_group(struct accfg_ctx *ctx, struct accfg_device *device, return -EINVAL; } + if (accfg_device_get_version(device) < ACCFG_DEVICE_VERSION_2) + return 0; + if (group_param->traffic_class_a != accfg_group_get_traffic_class_a(group)) { fprintf(stderr, "%s failed on traffic_class_a\n", __func__); -- 2.26.3

11 months, 3 weeks

2
1
0 / 0

[PATCH] accel-config: Do not set group traffic class for hw ver < 0x200

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> A default value will be set by driver for hw versions < 0x200 Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- test/libaccfg.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/libaccfg.c b/test/libaccfg.c index c37b71c..1d68781 100644 --- a/test/libaccfg.c +++ b/test/libaccfg.c @@ -186,6 +186,10 @@ static int config_group(struct accfg_ctx *ctx, struct accfg_device *device, group_param->tokens_allowed)); SET_ERR(rc, accfg_group_set_use_token_limit(group, group_param->use_token_limit)); + + if (accfg_device_get_version(device) < 0x200) + return rc; + SET_ERR(rc, accfg_group_set_traffic_class_a(group, group_param->traffic_class_a)); SET_ERR(rc, accfg_group_set_traffic_class_b(group, @@ -217,6 +221,9 @@ static int check_group(struct accfg_ctx *ctx, struct accfg_device *device, return -EINVAL; } + if (accfg_device_get_version(device) < 0x200) + return 0; + if (group_param->traffic_class_a != accfg_group_get_traffic_class_a(group)) { fprintf(stderr, "%s failed on traffic_class_a\n", __func__); -- 2.26.3

11 months, 3 weeks

2
1
0 / 0

[PATCH 0/2] Add support to get enhanced details of error

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Add support to take a snapshot of error details containing hw/sw error code and associated devices. Added new API to retreive the saved information. Using the new API accel-config prints a more detailed error message at exit. Ramesh Thomas (2): accel-config: Add APIs to get details of last error and associated devices accel-config: Print details of error at exit using new last_error API accfg/accel-config.c | 25 +++++- accfg/enable.c | 25 +----- accfg/lib/libaccel-config.sym | 10 +++ accfg/lib/libaccfg.c | 156 ++++++++++++++++++++++++++++++---- accfg/lib/private.h | 9 ++ accfg/libaccel_config.h | 9 +- 6 files changed, 192 insertions(+), 42 deletions(-) -- 2.26.3

11 months, 3 weeks

3
6
0 / 0

[PATCH 0/5] accel-config: Add wq ats_disable support

by Xiaochen Shen

Upstream kernel 5.11 introduced ATS disable knob for work queues in commit 92de5fa2dc39 ("dmaengine: idxd: add ATS disable knob for work queues"). Accel-config needs to add support to match kernel driver change. Add wq ats_disable support in library, configuration file, json interface, and config-wq command. Add unit test and documentation for wq option ats_disable. Xiaochen Shen (5): accel-config: Add ats_disable wq function in lib accel-config: Add ats_disable in config and json accel-config: Add ats_disable attr to config-wq command accel-config: Add ats_disable unit test accel-config: Add documentation for wq option ats-disable Documentation/accfg/accel-config-config-wq.txt | 6 ++++++ accfg/config.c | 1 + accfg/config_attr.c | 16 ++++++++++++++++ accfg/lib/libaccel-config.sym | 6 ++++++ accfg/lib/libaccfg.c | 3 +++ accfg/lib/private.h | 1 + accfg/libaccel_config.h | 3 +++ test/dsa.c | 1 + test/dsa.h | 1 + test/libaccfg.c | 12 ++++++++++++ util/json.c | 4 ++++ 11 files changed, 54 insertions(+) -- 1.8.3.1

11 months, 3 weeks

3
17
0 / 0

[PATCH] accel-config: Fix a bug in unit test

by ramesh.thomas＠intel.com

From: Ramesh Thomas <ramesh.thomas(a)intel.com> Configuring wq as "mdev" type when mdev support is not present fails at configuration tests. Set the wq type as "user" in the template configs and set type as "mdev" only in the mdev tests. Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com> --- test/libaccfg.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/test/libaccfg.c b/test/libaccfg.c index 93229c6..e5676eb 100644 --- a/test/libaccfg.c +++ b/test/libaccfg.c @@ -94,7 +94,7 @@ static struct wq_parameters wq02_param = { .max_batch_size = (1 << 8), .max_transfer_size = (1l << 30), .mode = "shared", - .type = "mdev", + .type = "user", .name = "guest1" }; @@ -106,7 +106,7 @@ static struct wq_parameters wq03_param = { .max_batch_size = (1 << 9), .max_transfer_size = (1l << 31), .mode = "dedicated", - .type = "mdev", + .type = "user", .name = "guest2" }; @@ -246,7 +246,7 @@ static int config_wq(struct accfg_ctx *ctx, struct accfg_device *device, if (wq_param->threshold) SET_ERR(rc, accfg_wq_set_threshold(wq, wq_param->threshold)); - return 0; + return rc; } static int check_wq(struct accfg_ctx *ctx, struct accfg_device *device, @@ -744,6 +744,17 @@ static int mdev_test(struct accfg_ctx *ctx, struct accfg_device *device, return 0; } +static int set_mdev_type(struct accfg_ctx *ctx, struct accfg_wq *wq) +{ + int rc; + + rc = accfg_wq_set_str_type(wq, "mdev"); + if (rc) + fprintf(stderr, "Error setting mdev type\n"); + + return rc; +} + static int enable_wq(struct accfg_ctx *ctx, struct accfg_device *device, struct accfg_wq *wq) { @@ -779,6 +790,10 @@ static int test_mdev_1swq(struct accfg_ctx *ctx) if (rc) return rc; + rc = set_mdev_type(ctx, test_ctx.wq[2]); + if (rc) + return rc; + rc = enable_wq(ctx, test_ctx.device, test_ctx.wq[2]); if (rc) return rc; @@ -808,6 +823,10 @@ static int test_mdev_1dwq(struct accfg_ctx *ctx) if (rc) return rc; + rc = set_mdev_type(ctx, test_ctx.wq[3]); + if (rc) + return rc; + rc = enable_wq(ctx, test_ctx.device, test_ctx.wq[3]); if (rc) return rc; -- 2.26.3

11 months, 4 weeks

2
1
0 / 0

[ANNOUNCE] accel-config-v3.3 release

by Thomas, Ramesh

Hello accel-config users! I am pleased to announce accel-config-v3.3 stable release. Changes: - Update driver name changes - Rewrite unit test removing hardcoding and other enhancements - Bug fixes You can clone this version using git from: https://github.com/intel/idxd-config.git Branch: stable Tag: accel-config-v3.3 https://github.com/intel/idxd-config/releases/tag/accel-config-v3.3 Link to stable branch: https://github.com/intel/idxd-config/tree/stable The zip and tar.gz of source code can be downloaded from: https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.3.zip https://github.com/intel/idxd-config/archive/refs/tags/accel-config-v3.3.... Regards, Ramesh

1 year

1
0
0 / 0

2022

2021

2020

Accel-config July 2021