On 11/06/2017 03:46 PM, Marco Gigante wrote:
I'm new to connman. I'm writing here to ask for informations about
proposing modifications to connman.
I made changes to connman for a project I'm working on, which
to send a fixed hostname in connman dhcp requests during network
interface configuration (regardless of the actual system hostname).
My system hostname may change since its startup, so I added a
configuration option to put into main.conf to have a fixed hostname into
It's a while since since I touched that code. So my knowledge is a bit
rusty. I suspect you know the details better than me. So bear with me :)
So I checked what we currently do. If I am not completely mistaken we
extract the hostname and domain name at ConnMan startup time in the
loopback plugin. There is no tracking if the hostname changes over time.
And then we have some code for "org.freedesktop.hostname1"
(src/machine.c) in place. Which just extracts the machine type. This
code is able to track hostname changes provided
org.freedesktop.hostname1 is doing its job.
I rather like to avoid adding the hostname setting into connman config
file. It would be better to extract this from the main source.
So I suggest to extend the src/machine.c code instead. Provided this
works. Probably loopback.c should only used as fallback if
org.freedesktop.hostname1 is not working.
Can such a modification be of any interest? I would be more than
to send a patch so you can evaluate it.
Yes, of course. Having some patches (even though they might just be a
prove of concept) are usually much better to understand and to discuss.
I also want to ask whether I can eventually send the git
directly to this ML or I have to follow some other procedure.
Yes, 'git send-email' is the preferred contribution way on this mailing
list. Same procedures and etiquette as on LKML :)