5:04 p.m.
Hi Bernhard,
I gave the patch a short test and it seems to break my PSK setup.
First of all p2p technology disappears with this path and second no
network is shown at all. I am not sure what's going wrong because the
patch doesn't look that dangerous. I don't have time to look at it today.
Does it work for you on normal non EAP networks?
a few bikeshedding comments below:
On 12/02/2016 10:22 AM, Bernhard Lichtinger wrote:
subject_match, altsubject_match, domain_suffix_match,
domain_match
they are used for 802.1X aka. enterprise-wpa to check
the authentication server's certificate in order to
prevent MITM attacks using a valid certificate issued
by the same root-CA as configured by CACertFile.
If you are at it, you could make it a bit wider and break the lines
a bit nicer. Looks a bit out of normal (bikeshedding! :))
@@ -4651,6 +4727,10 @@ static void service_free(gpointer user_data)
g_free(service->anonymous_identity);
g_free(service->agent_identity);
g_free(service->ca_cert_file);
+ g_free(service->subject_match);
+ g_free(service->altsubject_match);
+ g_free(service->domain_suffix_match);
+ g_free(service->domain_match);
indention not correct.
cheers,
daniel