> Nah, I didn't read it correctly when giving a quick glance. I
to move the whole functionality into a function and just call it from
the loop. If it returns success leave the loop otherwise continue
looping. This is just a bit too easy to get it wrong as it stands now.
You are right. It has become a complex code even before this patch. To
do what you say will make it more clear/readable but unfortunately I am
currently quite busy to modify and retest all again.
If it is not easy to read, it is usually and pretty good sign that it
might be too complex. I completely understand that everyone is quite
busy but I still hope you can convince your manager that it is worth
getting this right upstream.
On the other hand, I found that it is required to initialize the
variable berr (previously bridge_error) because it could be evaluated
without being assigned in case of one of these two actions fail:
info->ssid = ssid_ap_init(identifier, passphrase);
wifi->tethering_param->ssid = ssid_ap_init(identifier, passphrase);
I see. Yeah, let's fix this later. I have a question which I ask on your