Hi Daniel,

Den ons 22 jan. 2020 kl 11:27 skrev Daniel Wagner <wagi@monom.org>:
Hi Richard,

On Wed, Jan 22, 2020 at 10:35:37AM +0100, Richard Röjfors wrote:
> I have experienced a new issue after the openvpn rework.
> Now if running over a cellular connection and if that connection  goes up
> and down "rapidly", (fast enough for openvpn still being connection when it
> goes down).
> We can end up in a state where the VPN is not brought up when
> the connection goes up again.
> This did not happen on 038eb34a9e56e54f710c8a4fb2d407cfed62fdac,
> but happens on 2b5f5024728c2911dfd8cda71fece603cab81d05

For the OpenVPN plugin these are the commits

2b5f5024728c ("openvpn: Use correct error value in VPN agent credential reply")

I hardly see that this could be the root cause, we don't use any agent.
be1b90c6db3d ("openvpn: Rewrite plugin to support VPN agent and encrypted private keys")

This one is of course suspicious ;)
3c58f7325a5b ("vpn: Remove Host check in plugins")

I don't think this can cause it...

Could you try to revert the first two and see if you still have the
problem. There are plenty of changes in the vpn core code between the
two version you tested. So first I'd like to rule out that the
rewrite of the plugin is the problem.

Please also provide logs.

I need to do some filtering before I could provide logs.
What I have seen is that openvpn was never finished connecting and it always says "init_instance" when getting the SIGTERM:

Jan 10 18:59:31 info connman-vpnd[502]: pid 21413 was not killed, retrying after 2 sec
Jan 10 18:59:31 notice openvpn[21413]: SIGTERM[hard,init_instance] received, process exiting
While the log from a previous stop (after which the VPN was brought up again) looks like:
Jan 10 18:59:22 notice openvpn[820]: SIGTERM[hard,] received, process exiting