On Fri, 2016-10-28 at 12:20 +0530, Saurav Babu wrote:
Yes, with this patch only calls from autoconnect will be blocked
because old service will never be disconnected until connection is
initiated for new hidden AP.
> Maybe you should try to teach autoconnect not to call
> __connman_service_connect() when we try to connect to a hidden AP?
> In my eyes it makes more sense to teach autoconnect not to do
> stupid stuff instead of blocking it somewhere else.
This needs very thorough testing as all the other corner cases covered
by the current code can break. There most likely was a reason that the
test was done only when receiving the D-Bus method call.
This patch gives me flexibility that old service is not disconnected
until new hidden service is found in scan list. There is a scenario
when user enters wrong AP name for hidden AP or WPA Supplicant/Driver
fails to scan hidden AP then also currently old service will be
disconnected before initiating scan for hidden AP. This patch will
allow old service to remain in connected state for more time(time
when we are only scanning hidden AP to find if it is available) and
would only disconnect when required(hidden AP is found in scan).
So that's the reason behind the change. This should definitely be in
the commit message.
connman mailing list