8:19 a.m.
Hi Daniel,
I was pondering on this proposal for a while. I am just not convience
to introduce a SetProperties method is a good idea. We don't have
this kind of API in any other daemon and also we might eventually like
to move (connman v2) to the freedesktop verion of the properties
interface:
https://dbus.freedesktop.org/doc/dbus-java/api/org/freedesktop/DBus.Prope...
So one way you could do push this one level down behind SetProperty
and do a parsing of a config set there. It's almost the same just
avoid to do introduce a D-Bus API.
Ah, right. So the SetProperty should accept both, a single {sv} or a similar set
what GetProperties returns. I think that is doable and a good suggestion. I'll try
to manage a v2 before holidays.
Don't you also need to set all vpn_provider_set_string() back? This
just avoids to store the current configuration but the configuration
is still there. Unless I err again...
I'm not sure if I'm following this comment.. But are you suggesting a revert of
some sort in case there are errors?
The idea behind this is to write the config only once if there is a single property
value change. In case there are errors on some, simply report back them in the
D-Bus error message. If no changes are done, there is no need to save the config.
Or did I completely misinterpret that last comment of yours?
Cheers,
Jussi
P.S. The first reply on 1/3 arrived to my mailbox, this 2/3 reply didn't :)