2:14 a.m.
Hi,
I've discovered that ConnMan does not enter online state when going
from IPV4LL to DHCP-assigned address. ConnMan remains in ready state
because the online check is not triggered again in this case.
Here is a scenario for reproducing the problem:
- A device running ConnMan is attached to an Ethernet switch.
- The Ethernet switch is powered on, but is connected only to the
device, not to any network.
- The wired service is set up for DHCP.
- ConnMan tries to configure the Ethernet connection via DHCP, fails
because there is no DHCP server on the network, and resorts to
IPV4LL.
- ConnMan starts sending periodic DHCP requests to get a proper IP
address.
- After connecting the switch to a network which has a DHCP server,
ConnMan's DHCP requests are answered. IP configuration succeeds, but
ConnMan remains in ready state.
I have checked the debug output. After the configuration via IPV4LL
has succeeded, __connman_service_wispr_start() is called, and
wispr_portal_detect() fails with the message "Could not get
nameservers". Then, ConnMan ends up in ready state. Fair enough.
When the DHCP requests are answered, the Ethernet interface is
configured correctly, but __connman_service_wispr_start() is not
called again. Thus, ConnMan remains in its previously assumed ready
state.
To fix this, I have prepared a patch against master which triggers the
online check when the IP address is updated. It works, but I am not
sure if this is a good solution or if the patch is just fighting a
symptom caused by a problem which should be fixed somewhere else.
Cheers,
Robert
Robert Tiemann (1):
service: Start online check on IP address update
src/service.c | 27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
--
2.17.1
2:16 a.m.
New subject: [PATCH 1/1] service: Start online check on IP address update
This patch enables ConnMan to enter online state after getting IP
configuration via DHCP when coming from an IPV4LL configuration.
---
src/service.c | 27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/service.c b/src/service.c
index 3202f26c..8d672b03 100644
--- a/src/service.c
+++ b/src/service.c
@@ -144,6 +144,8 @@ static struct connman_ipconfig *create_ip4config(struct
connman_service *service
static struct connman_ipconfig *create_ip6config(struct connman_service *service,
int index);
static void dns_changed(struct connman_service *service);
+static void start_online_check(struct connman_service *service,
+ enum connman_ipconfig_type type);
struct find_data {
const char *path;
@@ -1395,6 +1397,7 @@ static void address_updated(struct connman_service *service,
service == connman_service_get_default()) {
nameserver_remove_all(service, type);
nameserver_add_all(service, type);
+ start_online_check(service, type);
__connman_timeserver_sync(service);
}
@@ -5955,6 +5958,20 @@ done:
__connman_service_wispr_start(service, CONNMAN_IPCONFIG_TYPE_IPV4);
}
+static void start_online_check(struct connman_service *service,
+ enum connman_ipconfig_type type)
+{
+ if (connman_setting_get_bool("EnableOnlineCheck"))
+ if (type == CONNMAN_IPCONFIG_TYPE_IPV4) {
+ check_proxy_setup(service);
+ } else {
+ __connman_service_wispr_start(service, type);
+ }
+ else
+ connman_info("Online check disabled. "
+ "Default service remains in READY state.");
+}
+
/*
* How many networks are connected at the same time. If more than 1,
* then set the rp_filter setting properly (loose mode routing) so that network
@@ -6147,15 +6164,7 @@ int __connman_service_ipconfig_indicate_state(struct
connman_service *service,
case CONNMAN_SERVICE_STATE_CONFIGURATION:
break;
case CONNMAN_SERVICE_STATE_READY:
- if (connman_setting_get_bool("EnableOnlineCheck"))
- if (type == CONNMAN_IPCONFIG_TYPE_IPV4) {
- check_proxy_setup(service);
- } else {
- __connman_service_wispr_start(service, type);
- }
- else
- connman_info("Online check disabled. "
- "Default service remains in READY state.");
+ start_online_check(service, type);
if (type == CONNMAN_IPCONFIG_TYPE_IPV4)
service_rp_filter(service, true);
set_mdns(service, service->mdns_config);
--
2.17.1
11:31 p.m.
New subject: [PATCH 1/1] service: Start online check on IP address update
Hi Robert,
+static void start_online_check(struct connman_service *service,
+ enum connman_ipconfig_type type)
+{
+ if (connman_setting_get_bool("EnableOnlineCheck"))
+ if (type == CONNMAN_IPCONFIG_TYPE_IPV4) {
+ check_proxy_setup(service);
+ } else {
+ __connman_service_wispr_start(service, type);
+ }
+ else
+ connman_info("Online check disabled. "
+ "Default service remains in READY state.");
+}
+
I think we should cancel any pending online check first. Just checked
the wispr file and it looks like we could trigger an online check
while one is running. Probably a bad thing.
Thanks,
Daniel
3:26 a.m.
New subject: [PATCH 1/1] service: Start online check on IP address update
On 3/27/19 8:31 AM, Daniel Wagner wrote:
Hi Robert,
Hi,
thank you for your feedback!
> +static void start_online_check(struct connman_service *service,
> + enum connman_ipconfig_type type)
> +{
> + if (connman_setting_get_bool("EnableOnlineCheck"))
> + if (type == CONNMAN_IPCONFIG_TYPE_IPV4) {
> + check_proxy_setup(service);
> + } else {
> + __connman_service_wispr_start(service, type);
> + }
> + else
> + connman_info("Online check disabled. "
> + "Default service remains in READY state.");
> +}
> +
I think we should cancel any pending online check first. Just checked
the wispr file and it looks like we could trigger an online check
while one is running. Probably a bad thing.
True. I have revised my patch and will send a new version later this
day.
Thanks,
Daniel
Cheers,
Robert
11:28 p.m.
Hi Robert,
On Tue, Mar 26, 2019 at 11:14:52AM +0100, Robert Tiemann wrote:
To fix this, I have prepared a patch against master which triggers
the
online check when the IP address is updated. It works, but I am not
sure if this is a good solution or if the patch is just fighting a
symptom caused by a problem which should be fixed somewhere else.
Well, not sure either. address_updated() was introduced to fix the
problem whenever a new IP is assigned we need to check the timeserver
etc. again. From this perspective it seems a reasonable place to
trigger also the online check again.
Thanks,
Daniel
1229
days inactive
1231
days old
4 comments
2 participants
participants (2)
-
Daniel Wagner -
Robert Tiemann