(Sorry, last one did not reach list)
On 4/30/19 10:05 AM, Daniel Wagner wrote:
On Mon, Apr 29, 2019 at 05:31:08PM +0300, Jussi Laakkonen wrote:
> This commit fixes the issue of loading external (library) VPN plugins
> using dlopen(). The vpn/plugins/vpn.c source should not be built with
> external VPN plugins as vpn/plugins/vpn.c is regarded as a plugin. This
> will cause undefined symbol erros when opening the .so using dlopen(),
> since vpn.c uses functions defined only for local (builtin) use and are
> cannot be accessed by plugins.
> The vpn/plugins/vpn.c source must be included in vpn build sources if
> there is a single VPN plugin to be built. Both builtin and external
> VPN plugins require this. Otherwise, when there are no builtin VPN
> plugins included in build, loading of the external plugins will fail as
> the vpn/plugins/vpn.c would have never included in connman-vpnd.
I hope you are offended by this: I modified the commit message
slightly. Starting the commit message with 'This patch' or 'This
commit' is redundant. Instead just write in imparative what you do.
No worries, that is fine. I'll keep that in mind in the next ones. Thanks!