On 10/28/2016 09:28 AM, Patrik Flykt wrote:
On Wed, 2016-10-26 at 18:36 +0530, Nishant Chaprana wrote:
> Signed-off-by: Nishant Chaprana <n.chaprana(a)samsung.com>
> ---
> src/service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/service.c b/src/service.c
> index ee10e6c..f6a76f6 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -1164,7 +1164,7 @@ int __connman_service_nameserver_remove(struct
> connman_service *service,
> if (!nameservers)
> return 0;
>
> - for (i = 0; nameservers && nameservers[i]; i++)
> + for (i = 0; nameservers[i]; i++)
> if (g_strcmp0(nameservers[i], nameserver) == 0) {
> found = true;
> break;
NACK. nameservers can be NULL as well. Touching nameservers[i] will
cause a segfault.
Isn't the if above the for loop testing this already?
cheers,
daniel