2:38 a.m.
Allow clients to identify WPS registrars.
Note that I am actually not quite happy with patch 3 because I have
copied some parts from network_added() to network_changed() in
plugins/wifi.c. Maybe it would be good to refactor it later to avoid
code duplication.
Robert Tiemann (3):
service: Indicate which wifi network has WPS activated.
gsupplicant: Fix WPS capabilities updates.
gsupplicant: Report changes of network WPS capabilities.
gsupplicant/supplicant.c | 22 +++++++++++++++++++++-
plugins/wifi.c | 37 ++++++++++++++++++++++++++++++++++---
src/network.c | 5 +++++
src/service.c | 16 ++++++++++++++--
4 files changed, 74 insertions(+), 6 deletions(-)
--
1.9.1
2:40 a.m.
New subject: [PATCH 1/3] service: Indicate which wifi network has WPS activated.
---
plugins/wifi.c | 1 +
src/network.c | 5 +++++
src/service.c | 16 ++++++++++++++--
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/plugins/wifi.c b/plugins/wifi.c
index f99340d..0bd8134 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -2813,6 +2813,7 @@ static void network_added(GSupplicantNetwork *supplicant_network)
connman_network_set_strength(network,
calculate_strength(supplicant_network));
connman_network_set_bool(network, "WiFi.WPS", wps);
+ connman_network_set_bool(network, "WiFi.WPSAdvertising", wps_advertizing);
if (wps) {
/* Is AP advertizing for WPS association?
diff --git a/src/network.c b/src/network.c
index f3e422f..8c5979f 100644
--- a/src/network.c
+++ b/src/network.c
@@ -97,6 +97,7 @@ struct connman_network {
char *private_key_passphrase;
char *phase2_auth;
bool wps;
+ bool wps_advertizing;
bool use_wps;
char *pin_wps;
} wifi;
@@ -1927,6 +1928,8 @@ int connman_network_set_bool(struct connman_network *network,
network->roaming = value;
else if (g_strcmp0(key, "WiFi.WPS") == 0)
network->wifi.wps = value;
+ else if (g_strcmp0(key, "WiFi.WPSAdvertising") == 0)
+ network->wifi.wps_advertizing = value;
else if (g_strcmp0(key, "WiFi.UseWPS") == 0)
network->wifi.use_wps = value;
@@ -1947,6 +1950,8 @@ bool connman_network_get_bool(struct connman_network *network,
return network->roaming;
else if (g_str_equal(key, "WiFi.WPS"))
return network->wifi.wps;
+ else if (g_str_equal(key, "WiFi.WPSAdvertising"))
+ return network->wifi.wps_advertizing;
else if (g_str_equal(key, "WiFi.UseWPS"))
return network->wifi.use_wps;
diff --git a/src/service.c b/src/service.c
index e72b6f3..80bc474 100644
--- a/src/service.c
+++ b/src/service.c
@@ -126,6 +126,7 @@ struct connman_service {
char **excludes;
char *pac;
bool wps;
+ bool wps_advertizing;
int online_check_count;
bool do_split_routing;
bool new_service;
@@ -1664,6 +1665,12 @@ static void append_security(DBusMessageIter *iter, void
*user_data)
case CONNMAN_SERVICE_SECURITY_8021X:
break;
}
+
+ if (service->wps_advertizing) {
+ str = "wps_advertising";
+ dbus_message_iter_append_basic(iter,
+ DBUS_TYPE_STRING, &str);
+ }
}
}
@@ -4878,6 +4885,7 @@ static void service_initialize(struct connman_service *service)
service->provider = NULL;
service->wps = false;
+ service->wps_advertizing = false;
}
/**
@@ -7022,8 +7030,10 @@ static void update_from_network(struct connman_service *service,
str = connman_network_get_string(network, "WiFi.Security");
service->security = convert_wifi_security(str);
- if (service->type == CONNMAN_SERVICE_TYPE_WIFI)
+ if (service->type == CONNMAN_SERVICE_TYPE_WIFI) {
service->wps = connman_network_get_bool(network, "WiFi.WPS");
+ service->wps_advertizing = connman_network_get_bool(network,
"WiFi.WPSAdvertising");
+ }
if (service->strength > strength && service->network) {
connman_network_unref(service->network);
@@ -7191,8 +7201,10 @@ void __connman_service_update_from_network(struct connman_network
*network)
DBUS_TYPE_STRING, &service->name);
}
- if (service->type == CONNMAN_SERVICE_TYPE_WIFI)
+ if (service->type == CONNMAN_SERVICE_TYPE_WIFI) {
service->wps = connman_network_get_bool(network, "WiFi.WPS");
+ service->wps_advertizing = connman_network_get_bool(network,
"WiFi.WPSAdvertising");
+ }
strength = connman_network_get_strength(service->network);
if (strength == service->strength)
--
1.9.1
2:40 a.m.
New subject: [PATCH 2/3] gsupplicant: Fix WPS capabilities updates.
---
gsupplicant/supplicant.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 3994bfe..8f6da41 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -1611,6 +1611,11 @@ static int add_or_replace_bss_to_network(struct g_supplicant_bss
*bss)
network->frequency = bss->frequency;
network->best_bss = bss;
+ if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
+ network->wps = TRUE;
+ network->wps_capabilities = bss->wps_capabilities;
+ }
+
SUPPLICANT_DBG("New network %s created", network->name);
network->bss_table = g_hash_table_new_full(g_str_hash, g_str_equal,
@@ -1628,7 +1633,7 @@ done:
/* We update network's WPS properties if only bss provides WPS. */
if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
network->wps = TRUE;
- network->wps_capabilities |= bss->wps_capabilities;
+ network->wps_capabilities = bss->wps_capabilities;
}
/*
@@ -2725,6 +2730,7 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
GSupplicantInterface *interface;
GSupplicantNetwork *network;
GSupplicantSecurity old_security;
+ unsigned int old_wps_capabilities;
struct g_supplicant_bss *bss;
SUPPLICANT_DBG("");
@@ -2799,6 +2805,11 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
return;
}
+ old_wps_capabilities = network->wps_capabilities;
+
+ if (old_wps_capabilities != bss->wps_capabilities)
+ network->wps_capabilities = bss->wps_capabilities;
+
/* Consider only property changes of the connected BSS */
if (network == interface->current_network && bss != network->best_bss)
return;
--
1.9.1
2:54 a.m.
New subject: [PATCH 2/3] gsupplicant: Fix WPS capabilities updates.
Hi Robert,
Can you add a commit message what was wrong? Helps to understand what
you are fixing.
Thanks,
Daniel
On 01/12/2018 12:40 PM, Robert Tiemann wrote:
---
gsupplicant/supplicant.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 3994bfe..8f6da41 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -1611,6 +1611,11 @@ static int add_or_replace_bss_to_network(struct g_supplicant_bss
*bss)
network->frequency = bss->frequency;
network->best_bss = bss;
+ if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
+ network->wps = TRUE;
+ network->wps_capabilities = bss->wps_capabilities;
+ }
+
SUPPLICANT_DBG("New network %s created", network->name);
network->bss_table = g_hash_table_new_full(g_str_hash, g_str_equal,
@@ -1628,7 +1633,7 @@ done:
/* We update network's WPS properties if only bss provides WPS. */
if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
network->wps = TRUE;
- network->wps_capabilities |= bss->wps_capabilities;
+ network->wps_capabilities = bss->wps_capabilities;
}
/*
@@ -2725,6 +2730,7 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
GSupplicantInterface *interface;
GSupplicantNetwork *network;
GSupplicantSecurity old_security;
+ unsigned int old_wps_capabilities;
struct g_supplicant_bss *bss;
SUPPLICANT_DBG("");
@@ -2799,6 +2805,11 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
return;
}
+ old_wps_capabilities = network->wps_capabilities;
+
+ if (old_wps_capabilities != bss->wps_capabilities)
+ network->wps_capabilities = bss->wps_capabilities;
+
/* Consider only property changes of the connected BSS */
if (network == interface->current_network && bss != network->best_bss)
return;
3:59 a.m.
New subject: [PATCH 2/3] gsupplicant: Fix WPS capabilities updates.
WPS capabilities for newly added networks were written to the network
object only after the callback for reporting new networks has been
called. This caused the callee to pick up wrong initial WPS
information. Now, capabilities are assigned before the callback is
called.
Along the same lines, WPS capabilities for existing, updated networks
are updated using an assignment instead of OR'ing them into the
previous capability flags. This allows clearing previously set flags
such as the G_SUPPLICANT_WPS_REGISTRAR flag (WPS active).
The WPS capabilities are updated in the
fi.w1.wpa_supplicant1.Interface.BSS.PropertiesChanged handler as well
now.
---
gsupplicant/supplicant.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 3994bfe..8f6da41 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -1611,6 +1611,11 @@ static int add_or_replace_bss_to_network(struct g_supplicant_bss
*bss)
network->frequency = bss->frequency;
network->best_bss = bss;
+ if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
+ network->wps = TRUE;
+ network->wps_capabilities = bss->wps_capabilities;
+ }
+
SUPPLICANT_DBG("New network %s created", network->name);
network->bss_table = g_hash_table_new_full(g_str_hash, g_str_equal,
@@ -1628,7 +1633,7 @@ done:
/* We update network's WPS properties if only bss provides WPS. */
if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
network->wps = TRUE;
- network->wps_capabilities |= bss->wps_capabilities;
+ network->wps_capabilities = bss->wps_capabilities;
}
/*
@@ -2725,6 +2730,7 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
GSupplicantInterface *interface;
GSupplicantNetwork *network;
GSupplicantSecurity old_security;
+ unsigned int old_wps_capabilities;
struct g_supplicant_bss *bss;
SUPPLICANT_DBG("");
@@ -2799,6 +2805,11 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
return;
}
+ old_wps_capabilities = network->wps_capabilities;
+
+ if (old_wps_capabilities != bss->wps_capabilities)
+ network->wps_capabilities = bss->wps_capabilities;
+
/* Consider only property changes of the connected BSS */
if (network == interface->current_network && bss != network->best_bss)
return;
--
1.9.1
2:41 a.m.
New subject: [PATCH 3/3] gsupplicant: Report changes of network WPS capabilities.
---
gsupplicant/supplicant.c | 11 ++++++++++-
plugins/wifi.c | 36 +++++++++++++++++++++++++++++++++---
2 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 8f6da41..5246c80 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -1577,6 +1577,7 @@ static int add_or_replace_bss_to_network(struct g_supplicant_bss
*bss)
GSupplicantInterface *interface = bss->interface;
GSupplicantNetwork *network;
char *group;
+ bool is_new_network;
group = create_group(bss);
SUPPLICANT_DBG("New group created: %s", group);
@@ -1588,10 +1589,13 @@ static int add_or_replace_bss_to_network(struct g_supplicant_bss
*bss)
if (network) {
g_free(group);
SUPPLICANT_DBG("Network %s already exist", network->name);
+ is_new_network = false;
goto done;
}
+ is_new_network = true;
+
network = g_try_new0(GSupplicantNetwork, 1);
if (!network) {
g_free(group);
@@ -1634,6 +1638,9 @@ done:
if ((bss->keymgmt & G_SUPPLICANT_KEYMGMT_WPS) != 0) {
network->wps = TRUE;
network->wps_capabilities = bss->wps_capabilities;
+
+ if (!is_new_network)
+ callback_network_changed(network, "WPSCapabilities");
}
/*
@@ -2807,8 +2814,10 @@ static void signal_bss_changed(const char *path, DBusMessageIter
*iter)
old_wps_capabilities = network->wps_capabilities;
- if (old_wps_capabilities != bss->wps_capabilities)
+ if (old_wps_capabilities != bss->wps_capabilities) {
network->wps_capabilities = bss->wps_capabilities;
+ callback_network_changed(network, "WPSCapabilities");
+ }
/* Consider only property changes of the connected BSS */
if (network == interface->current_network && bss != network->best_bss)
diff --git a/plugins/wifi.c b/plugins/wifi.c
index 0bd8134..7e4a0f7 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -2880,6 +2880,7 @@ static void network_changed(GSupplicantNetwork *network, const char
*property)
struct wifi_data *wifi;
const char *name, *identifier;
struct connman_network *connman_network;
+ bool update_needed;
interface = g_supplicant_network_get_interface(network);
wifi = g_supplicant_interface_get_data(interface);
@@ -2895,11 +2896,40 @@ static void network_changed(GSupplicantNetwork *network, const
char *property)
if (!connman_network)
return;
- if (g_str_equal(property, "Signal")) {
- connman_network_set_strength(connman_network,
+ if (g_str_equal(property, "WPSCapabilities")) {
+ bool wps;
+ bool wps_pbc;
+ bool wps_ready;
+ bool wps_advertizing;
+
+ wps = g_supplicant_network_get_wps(network);
+ wps_pbc = g_supplicant_network_is_wps_pbc(network);
+ wps_ready = g_supplicant_network_is_wps_active(network);
+ wps_advertizing =
+ g_supplicant_network_is_wps_advertizing(network);
+
+ connman_network_set_bool(connman_network, "WiFi.WPS", wps);
+ connman_network_set_bool(connman_network, "WiFi.WPSAdvertising",
wps_advertizing);
+
+ if (wps) {
+ /* Is AP advertizing for WPS association?
+ * If so, we decide to use WPS by default */
+ if (wps_ready && wps_pbc && wps_advertizing)
+ connman_network_set_bool(connman_network, "WiFi.UseWPS", true);
+ }
+
+ update_needed = true;
+ }
+ else if (g_str_equal(property, "Signal")) {
+ connman_network_set_strength(connman_network,
calculate_strength(network));
- connman_network_update(connman_network);
+ update_needed = true;
}
+ else
+ update_needed = false;
+
+ if (update_needed)
+ connman_network_update(connman_network);
}
static void network_associated(GSupplicantNetwork *network)
--
1.9.1
2:56 a.m.
New subject: [PATCH 3/3] gsupplicant: Report changes of network WPS capabilities.
+ wps = g_supplicant_network_get_wps(network);
+ wps_pbc = g_supplicant_network_is_wps_pbc(network);
+ wps_ready = g_supplicant_network_is_wps_active(network);
+ wps_advertizing =
+ g_supplicant_network_is_wps_advertizing(network);
+
+ connman_network_set_bool(connman_network, "WiFi.WPS", wps);
+ connman_network_set_bool(connman_network, "WiFi.WPSAdvertising",
wps_advertizing);
+
+ if (wps) {
+ /* Is AP advertizing for WPS association?
+ * If so, we decide to use WPS by default */
Just a nitpick: please do
/*
*
*
*/
comment style.
3:25 a.m.
New subject: [PATCH 3/3] gsupplicant: Report changes of network WPS capabilities.
On 01/12/2018 12:56 PM, Daniel Wagner wrote:
> + if (wps) {
> + /* Is AP advertizing for WPS association?
> + * If so, we decide to use WPS by default */
Just a nitpick: please do
/*
*
*
*/
comment style.
This comment is part of what I've copied from function network_added()
in the same file. Should I fix the comment style in the original place
as well?
3:30 a.m.
New subject: [PATCH 3/3] gsupplicant: Report changes of network WPS capabilities.
On 01/12/2018 01:25 PM, Robert Tiemann wrote:
On 01/12/2018 12:56 PM, Daniel Wagner wrote:
>
>> + if (wps) {
>> + /* Is AP advertizing for WPS association?
>> + * If so, we decide to use WPS by default */
>
> Just a nitpick: please do
>
> /*
> *
> *
> */
>
> comment style.
This comment is part of what I've copied from function network_added()
in the same file. Should I fix the comment style in the original place
as well?
Ah I see. No, leave the old comment as it is. It would just introduce
unnecessary white space changes in the commit history. There are a few
other places which have the other comment style. So we either change all
of them or leave them as they are. But it's just not worth the extra
noise in the commit history in my opinion.
4:13 a.m.
New subject: [PATCH 3/3] gsupplicant: Report changes of network WPS capabilities.
On 01/12/2018 01:30 PM, Daniel Wagner wrote:
> This comment is part of what I've copied from function
network_added()
> in the same file. Should I fix the comment style in the original place
> as well?
Ah I see. No, leave the old comment as it is. It would just introduce
unnecessary white space changes in the commit history. There are a few
other places which have the other comment style. So we either change all
of them or leave them as they are. But it's just not worth the extra
noise in the commit history in my opinion.
Same thinking here, I actually prefer your comment style as well.
I wanted to keep the two duplicated portions as equal as possible.
2:58 a.m.
Hi Robert,
On 01/12/2018 12:38 PM, Robert Tiemann wrote:
Allow clients to identify WPS registrars.
Note that I am actually not quite happy with patch 3 because I have
copied some parts from network_added() to network_changed() in
plugins/wifi.c. Maybe it would be good to refactor it later to avoid
code duplication.
Apart the two nitpicks from me, the code looks good. Pretty neat
actually :) Nice work.
Thanks,
Daniel
2:42 p.m.
Hi Robert,
On Fri, Jan 12, 2018 at 12:58 PM, Daniel Wagner <wagi(a)monom.org> wrote:
> Allow clients to identify WPS registrars.
>
> Note that I am actually not quite happy with patch 3 because I have
> copied some parts from network_added() to network_changed() in
> plugins/wifi.c. Maybe it would be good to refactor it later to avoid
> code duplication.
Apart the two nitpicks from me, the code looks good. Pretty neat
actually :) Nice work.
Same for me :) I will test it a little bit more tomorrow.
I would just suggest, as usual, to check the patch with checkpatch.pl
for style errors like "line over 80 characters" and others. We use
Linux kernel coding style.
Thanks,
Jose Blanquicet
12:28 a.m.
On 01/15/2018 12:42 AM, Jose Blanquicet wrote:
I would just suggest, as usual, to check the patch with
checkpatch.pl
for style errors like "line over 80 characters" and others. We use
Linux kernel coding style.
OK, I've sent another patch series. There is still one warning for the
the third patch about the comment style in plugins/wifi.c.
10:54 p.m.
Hi Robert, Daniel,
If we will go ahead, I think that maybe it's worth to generate a
PropertyChanged signal to notify Security property has changed when
wps_adversing is added/removed. Currently PropertyChanged signal on
Security is not generated because when security changes, e.g. PSK ->
OPEN, we consider it as a new service. But with wps_advertising it is
not the case, so I think that signal should be generated. That would
ease job for a ConnMan client. What do you think?
Furthermore, Service API documentation should be updated with the new
possible value for Security property.
Thanks,
Jose Blanquicet
On Mon, Jan 15, 2018 at 10:28 AM, Robert Tiemann <rtie(a)gmx.de> wrote:
On 01/15/2018 12:42 AM, Jose Blanquicet wrote:
> I would just suggest, as usual, to check the patch with checkpatch.pl
> for style errors like "line over 80 characters" and others. We use
> Linux kernel coding style.
OK, I've sent another patch series. There is still one warning for the
the third patch about the comment style in plugins/wifi.c.
11:03 p.m.
Hi Jose,
On 01/17/2018 08:54 AM, Jose Blanquicet wrote:
Hi Robert, Daniel,
If we will go ahead, I think that maybe it's worth to generate a
PropertyChanged signal to notify Security property has changed when
wps_adversing is added/removed. Currently PropertyChanged signal on
Security is not generated because when security changes, e.g. PSK ->
OPEN, we consider it as a new service. But with wps_advertising it is
not the case, so I think that signal should be generated. That would
ease job for a ConnMan client. What do you think?
Sounds reasonable to me.
Furthermore, Service API documentation should be updated with the
new
possible value for Security property.
Yep, good plan.
Any objection to Robert's v2? Apart of the comment thingy it looks ready
to be merged.
Thanks,
Daniel
9:52 a.m.
Hi Jose,
On 01/21/2018 05:02 PM, Jose Blanquicet wrote:
Hi Daniel,
On Wed, Jan 17, 2018 at 9:03 AM, Daniel Wagner <wagi(a)monom.org> wrote:
> Any objection to Robert's v2? Apart of the comment thingy it looks ready to
> be merged.
No, looks fine to me too.
Thanks for reviewing. Patches applied.
Daniel
11:27 p.m.
On 01/17/2018 08:54 AM, Jose Blanquicet wrote:
Hi Robert, Daniel,
Hi!
If we will go ahead, I think that maybe it's worth to generate a
PropertyChanged signal to notify Security property has changed when
wps_adversing is added/removed.
This would be helpful indeed. My current client code constantly scans
for WLANs and reads out all data of all services on _any_ change
reported. Not very efficient, but it turned out to be the most
reliable way to keep up with changes.
Alternatively, wps_advertising could be turned into a property in its
own right, outside of Security in case Security is not supposed to
change. I just thought it would make sense to put it into Security.
Furthermore, Service API documentation should be updated with the
new
possible value for Security property.
Yes.
I guess to generate the PropertyChanged signal, a function similar to
strength_changed() would be needed which calls
connman_dbus_property_changed_array(), right?
Shall I prepare two patches (one for the signal, one for the docs)?
Robert
7:50 a.m.
Hi Robert,
On Wed, Jan 17, 2018 at 9:27 AM, Robert Tiemann <rtie(a)gmx.de> wrote:
> If we will go ahead, I think that maybe it's worth to
generate a
> PropertyChanged signal to notify Security property has changed when
> wps_adversing is added/removed.
This would be helpful indeed. My current client code constantly scans
for WLANs and reads out all data of all services on _any_ change
reported. Not very efficient, but it turned out to be the most
reliable way to keep up with changes.
I would say that avoid doing that is exactly the reason why signals are used :)
Alternatively, wps_advertising could be turned into a property in
its
own right, outside of Security in case Security is not supposed to
change. I just thought it would make sense to put it into Security.
I would rather add it into the Security property. Let's see what
Daniel thinks about it.
I guess to generate the PropertyChanged signal, a function similar
to
strength_changed() would be needed which calls
connman_dbus_property_changed_array(), right?
Yes.
Shall I prepare two patches (one for the signal, one for the docs)?
Yes, please divide it into two patches.
Thanks,
Jose
10:01 a.m.
Hi,
On 01/21/2018 05:50 PM, Jose Blanquicet wrote:
On Wed, Jan 17, 2018 at 9:27 AM, Robert Tiemann <rtie(a)gmx.de>
wrote:
>> If we will go ahead, I think that maybe it's worth to generate a
>> PropertyChanged signal to notify Security property has changed when
>> wps_adversing is added/removed.
>
> This would be helpful indeed. My current client code constantly scans
> for WLANs and reads out all data of all services on _any_ change
> reported. Not very efficient, but it turned out to be the most
> reliable way to keep up with changes.
I would say that avoid doing that is exactly the reason why signals are used :)
Indeed, this is indeed not really efficient.
> Alternatively, wps_advertising could be turned into a property in
its
> own right, outside of Security in case Security is not supposed to
> change. I just thought it would make sense to put it into Security.
I would rather add it into the Security property. Let's see what
Daniel thinks about it.
Unfortunately, I don't have any spec to read up on this topic. So I
can't really comment on it.
@Marcel any thougths on this?
Thanks,
Daniel
5:02 a.m.
On 01/21/2018 05:50 PM, Jose Blanquicet wrote:
> My current client code constantly scans
> for WLANs and reads out all data of all services on _any_ change
> reported. Not very efficient, but it turned out to be the most
> reliable way to keep up with changes.
I would say that avoid doing that is exactly the reason why signals are used :)
I know, earlier versions of my client relied on signals, and I'd
prefer it this way.
It turned out, however, that some information were missing from the
signals. That is, I have often received a set of changes by signal,
but when reading out all services and checking for changes manually,
I've found more changes that were never reported by signal.
This was with ConnMan v1.33, about one year ago. I don't remember
which properties were missing from the signals, but I had trouble
getting my client going when relying only on D-Bus signals. The
steamroller approach of reading out everything on any signal fixed
this for me...
Maybe things have changed in later ConnMan versions.
> Shall I prepare two patches (one for the signal, one for the
docs)?
Yes, please divide it into two patches.
Done.
Thanks,
Jose
Regards,
Robert
11:38 a.m.
Hi Robert,
On Tue, Jan 23, 2018 at 3:02 PM, Robert Tiemann <rtie(a)gmx.de> wrote:
On 01/21/2018 05:50 PM, Jose Blanquicet wrote:
>> My current client code constantly scans
>> for WLANs and reads out all data of all services on _any_ change
>> reported. Not very efficient, but it turned out to be the most
>> reliable way to keep up with changes.
>
> I would say that avoid doing that is exactly the reason why signals are used :)
I know, earlier versions of my client relied on signals, and I'd
prefer it this way.
It turned out, however, that some information were missing from the
signals. That is, I have often received a set of changes by signal,
but when reading out all services and checking for changes manually,
I've found more changes that were never reported by signal.
If you find something like this with latest version, try to get the
logs and a patter to reproduce the situation (If possible); then we
will try to fix it together :)
Thanks,
Jose
1653
days inactive
1669
days old
21 comments
3 participants
participants (3)
-
Daniel Wagner -
Jose Blanquicet -
Robert Tiemann