6:51 a.m.
Two small fixes found while ramping up again...
Daniel Wagner (2):
vpn: Send D-Bus response when connecting for daemon-less setups
session: Fix state initializiation
src/session.c | 2 +-
vpn/plugins/vpn.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.27.0
6:51 a.m.
New subject: [PATCH 1/2] vpn: Send D-Bus response when connecting for daemon-less setups
Pass in the callback to the connect() call to allow the plugin to
trigger the D-Bus response when done.
ConnMan was complaining it didn't receive a reply for the Connect2
call.
---
vpn/plugins/vpn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c
index e04670c85d13..30517a1153ab 100644
--- a/vpn/plugins/vpn.c
+++ b/vpn/plugins/vpn.c
@@ -632,7 +632,7 @@ static int vpn_connect(struct vpn_provider *provider,
vpn_driver_data->vpn_driver->flags & VPN_FLAG_NO_DAEMON) {
ret = vpn_driver_data->vpn_driver->connect(provider,
- NULL, NULL, NULL, NULL, NULL);
+ NULL, NULL, cb, dbus_sender, user_data);
if (ret) {
stop_vpn(provider);
goto exist_err;
--
2.27.0
6:51 a.m.
New subject: [PATCH 2/2] session: Fix state initializiation
gcc complains about using the wrong enum type:
src/session.c:1808:38: error: implicit conversion from ‘enum connman_session_state’ to
‘enum connman_service_state’ [-Werror=enum-conversion]
1808 | enum connman_service_state state = CONNMAN_SESSION_STATE_DISCONNECTED;
x
---
src/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/session.c b/src/session.c
index 2a1dd9aab221..eeefe3f28b3c 100644
--- a/src/session.c
+++ b/src/session.c
@@ -1804,7 +1804,7 @@ static void session_activate(struct connman_session *session)
struct connman_service *service;
struct connman_service_info *info;
GSList *service_list = NULL;
- enum connman_service_state state = CONNMAN_SESSION_STATE_DISCONNECTED;
+ enum connman_service_state state = CONNMAN_SERVICE_STATE_DISCONNECT;
g_hash_table_iter_init(&iter, service_hash);
--
2.27.0
2:42 p.m.
Is there a public accessible git repository with the patches applied that I
see in the email list?
I just went here:
https://git.kernel.org/pub/scm/network/connman/connman.git/
and the last commit was 2020-05-26
I am running Arch and there is an AUR package I can build but it also
references the same git repository.
I'd like to build and test the most up to date.
Regards,
Keith
On Wed, Jul 29, 2020 at 1:51 AM Daniel Wagner <wagi(a)monom.org> wrote:
Two small fixes found while ramping up again...
Daniel Wagner (2):
vpn: Send D-Bus response when connecting for daemon-less setups
session: Fix state initializiation
src/session.c | 2 +-
vpn/plugins/vpn.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.27.0
_______________________________________________
connman mailing list -- connman(a)lists.01.org
To unsubscribe send an email to connman-leave(a)lists.01.org
4:16 p.m.
On Wed, Jul 29, 2020 at 09:42:54AM -0500, KeithG wrote:
Is there a public accessible git repository with the patches applied
that I
see in the email list?
I just went here:
https://git.kernel.org/pub/scm/network/connman/connman.git/
and the last commit was 2020-05-26
I've posted these patches for review. Usually, there is no feedback but
I know there are folks looking at it and someone will scream at me if I
do something extremely stupid. If nothing happens for a while I apply
them.
742
days inactive
744
days old
5 comments
2 participants
participants (2)
-
Daniel Wagner -
KeithG