On 02/13/2018 10:52 PM, Vasyl Vavrychuk wrote:
I would like to make P2P_FIND_TIMEOUT large than 30 seconds locally.
Potentially it can be very large value even infinite.
But then connmanctl's 'scan p2p' command will timeout because connman
client has 120 seconds D-Bus reply timeout.
In my opinion it would be better if
1. Make Scan method being asynchronous in the sense it returns upon scan start.
The API documentation for p2p already reads as it could be asynchronous.
In case of P2P technology, results will be signaled
via the PeersChanged signal from the manager
Do you want to make Scan() completely asynchronous or just for p2p? I
fear we should not change the current Scan() behavior for any other
technology because it breaks the API. If the p2p folks would like to
change that to asynchronous I could be convinced to accept it. But it is
2. Add Scanning property. That is what UI does, for example here
they manage their own m_scanning field.
Yes, that makes sense but as said above I fear we can't change Scan()
without breaking applications. This would be something for 2.x.