3:52 p.m.
I would like to make P2P_FIND_TIMEOUT large than 30 seconds locally.
Potentially it can be very large value even infinite.
But then connmanctl's 'scan p2p' command will timeout because connman
client has 120 seconds D-Bus reply timeout.
In my opinion it would be better if
1. Make Scan method being asynchronous in the sense it returns upon scan start.
2. Add Scanning property. That is what UI does, for example here
http://git.merproject.org/mer-core/libconnman-qt/blob/master/plugin/techn...
they manage their own m_scanning field.
10:58 a.m.
Hi Vasyl,
On 02/13/2018 10:52 PM, Vasyl Vavrychuk wrote:
I would like to make P2P_FIND_TIMEOUT large than 30 seconds locally.
Potentially it can be very large value even infinite.
But then connmanctl's 'scan p2p' command will timeout because connman
client has 120 seconds D-Bus reply timeout.
In my opinion it would be better if
1. Make Scan method being asynchronous in the sense it returns upon scan start.
The API documentation for p2p already reads as it could be asynchronous.
In case of P2P technology, results will be signaled
via the PeersChanged signal from the manager
interface.
Do you want to make Scan() completely asynchronous or just for p2p? I
fear we should not change the current Scan() behavior for any other
technology because it breaks the API. If the p2p folks would like to
change that to asynchronous I could be convinced to accept it. But it is
ugly.
2. Add Scanning property. That is what UI does, for example here
http://git.merproject.org/mer-core/libconnman-qt/blob/master/plugin/techn...
they manage their own m_scanning field.
Yes, that makes sense but as said above I fear we can't change Scan()
without breaking applications. This would be something for 2.x.
Thanks,
Daniel
4:08 a.m.
How do you feel about adding ScanAsync method or Scan2 or P2PFind
method that will behave asynchronously in the sense that it will
return when scan or find successfully started?
On Mon, Feb 19, 2018 at 6:58 PM, Daniel Wagner <wagi(a)monom.org> wrote:
Hi Vasyl,
On 02/13/2018 10:52 PM, Vasyl Vavrychuk wrote:
>
> I would like to make P2P_FIND_TIMEOUT large than 30 seconds locally.
> Potentially it can be very large value even infinite.
>
> But then connmanctl's 'scan p2p' command will timeout because connman
> client has 120 seconds D-Bus reply timeout.
>
> In my opinion it would be better if
> 1. Make Scan method being asynchronous in the sense it returns upon scan
> start.
The API documentation for p2p already reads as it could be asynchronous.
In case of P2P technology, results will be signaled
via the PeersChanged signal from the manager
interface.
Do you want to make Scan() completely asynchronous or just for p2p? I fear
we should not change the current Scan() behavior for any other technology
because it breaks the API. If the p2p folks would like to change that to
asynchronous I could be convinced to accept it. But it is ugly.
> 2. Add Scanning property. That is what UI does, for example here
>
>
http://git.merproject.org/mer-core/libconnman-qt/blob/master/plugin/techn...
> they manage their own m_scanning field.
Yes, that makes sense but as said above I fear we can't change Scan()
without breaking applications. This would be something for 2.x.
Thanks,
Daniel
2:30 a.m.
Hi Vasyl,
On 21.02.2018 11:08, Vasyl Vavrychuk wrote:
How do you feel about adding ScanAsync method or Scan2 or P2PFind
method that will behave asynchronously in the sense that it will
return when scan or find successfully started?
I would go with ScanAsync and make the property signal working for all
technologies. That seems to be the best way forward in my opinion. If we
do a 2.x of ConnMan we can merge Scan and ScanAsync together and use a
parameter for the behavior.
Thanks,
Daniel
1071
days inactive
1080
days old
3 comments
2 participants
participants (2)
-
Daniel Wagner -
Vasyl Vavrychuk