This emails is again white space damaged and this time even send as
HTML. There are excellent guide how to send proper patches even using
broken corporate emails servers. Since I already invested time reading
the patch I opted for fixing it up myself. But please fix your email
setup for next time.
The patch title is not following our code guidelines. You should prefix
it. In this case "network:". Also calling it 'bug fix' is a bit of
noise. Just state what you do in the patch. In the commit message you
should explain why you do the change.
On 08/17/2018 06:43 AM, Rahul Jain wrote:
When a device having auto IP configurations, is connected
to router in which DHCP is not running, device will go for
IPv4All configuration and will get IP(like 169.254.xxx.xxx).
Inside connman/src/dhcp.c:dhcpipv4ll_available_cb(), dhcp ipconfig
set to AUTO.
Now if user tries to configure manual IP, it fails.
As per current code, dhcp stop function (__connman_dhcp_stop) will
not be called for IPv5.
I suppose this should be IPv4.
diff --git a/src/network.c b/src/network.c
index c3a7cbf..2d1cbb9 100644
@@ -1872,12 +1872,13 @@ int __connman_network_clear_ipconfig(struct
- case CONNMAN_IPCONFIG_METHOD_AUTO:
+ case CONNMAN_IPCONFIG_METHOD_AUTO:
+ if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
src/network.c: In function ‘__connman_network_clear_ipconfig’:
src/network.c:1880:6: error: this statement may fall through
if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
src/network.c:1882:2: note: here
cc1: all warnings being treated as errors
I fixed this by adding a "/* fall through */" comment. GCC is then
happy with the code.