On Fri, 2016-10-28 at 14:00 +0530, Milind Murhekar wrote:
> > ---
> > src/technology.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/src/technology.c b/src/technology.c
> > index 17ed456..4574f1e 100644
> > --- a/src/technology.c
> > +++ b/src/technology.c
> > @@ -270,10 +270,8 @@ static int set_tethering(struct
> > connman_technology *technology,
> > if (result == -EINPROGRESS)
> > continue;
> >
> > - if (err == -EINPROGRESS || err == 0) {
> > + if (err == -EINPROGRESS || err == 0)
> > result = err;
> > - continue;
> > - }
> > }
> Why is the test unnecessary and what is the use case enabled by its
> removal?
Hi,
This patch simply removes the extra "continue" statement, which I
think is not required.
As conitnue is the last statement in the loop and loop will
automatically get continued.
And applied with the last sentence as the commit message (and prefixed
the subject with tethering:), thanks!
Patrik