You getting better with the patch submission. I really appreciate your
On 08/23/2018 01:55 PM, Rahul Jain wrote:
Subject: [PATCH] ipconfig: Incase of Manual IP Configuration, saving
information during network switch
This seems to be a repetition of the emails subject. I usually send my
changes out with 'git format-patch' and 'git send-email'.
Anyway, try to trip the subject a bit. Just mention what you change.
Maybe something like 'Save gateway information'
[Problem] If user use manual IP configuration while connect with
Then during network switch (suppose from wired to wireless), gateway will not be saved
/var/lib/connman respective profile settings.
So when user come back to earlier network(suppose wired again),
then connection will fail as connman does not have gateway(wrong gateway as 0.0.0.0) to
[Solution] When device switch from wired to wireless network, gateway information was
to be saved into /var/lib/connman respective profile. So during Network switch
service_save()->__connman_ipconfig_save() will not remove "IPV4.gateway"
from respective profile settings file.
Format your commit message so that you don't exceed the 80 chars per line.
Signed-off-by: Rahul Jain <rahul.jain(a)samsung.com>
We don't do Signed-off-by at this project.
src/ipconfig.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 2565773..a2e398d 100644
@@ -2346,8 +2346,6 @@ int __connman_ipconfig_save(struct connman_ipconfig *ipconfig,
- g_key_file_remove_key(keyfile, identifier, key, NULL);
The g_key_file_remove_key() has been added by Craig: 60facabb03a9
("ipconfig: Remove IPv4.gateway key in settings if gateway is not
I am not sure if I am really understand the problem you want to fix. The
code you are deleting seems quite reasonable. If gateway is valid
(!NULL) save it, otherwise remove it. (The code above these lines should
probably do the same but that's a different story).
Does the initial network have a proper configuration, that is it
contains a valid gateway? If so why is it missing when we reach
__connman_ipfconfig_save()? Do we call __connman_ipconfig_save() too late?