ACPICA version 20130214 released
by Moore, Robert
14 February 2013. Summary of changes for version 20130214:
This release is available at https://www.acpica.org/downloads
The ACPI 5.0 specification is available at www.acpi.info
1) ACPICA kernel-resident subsystem:
Fixed a possible regression on some hosts: Reinstated the safe return macros (return_ACPI_STATUS, etc.) that ensure that the macro argument is only evaluated once. Although these macros are not needed for the ACPICA code itself, they are often used by ACPI-related host device drivers where the safe feature may be necessary.
Fixed several issues related to the ACPI 5.0 reduced hardware support (SOC): Now ensure that if the platform declares itself as hardware-reduced via the FADT, the following functions become NOOPs (and always return AE_OK) because ACPI is always enabled by definition on these machines:
AcpiEnable
AcpiDisable
AcpiHwGetMode
AcpiHwSetMode
Dynamic Object Repair: Implemented additional runtime repairs for predefined name return values. Both of these repairs can simplify code in the related device drivers that invoke these methods:
1) For the _STR and _MLS names, automatically repair/convert an ASCII string to a Unicode buffer.
2) For the _CRS, _PRS, and _DMA names, return a resource descriptor with a lone end tag descriptor in the following cases: A Return(0) was executed, a null buffer was returned, or no object at all was returned (non-slack mode only). Adds a new file, nsconvert.c
ACPICA BZ 998. Bob Moore, Lv Zheng.
Resource Manager: Added additional code to prevent possible infinite loops while traversing corrupted or ill-formed resource template buffers. Check for zero-length resource descriptors in all code that loops through resource templates (the length field is used to index through the template). This change also hardens the external AcpiWalkResources and AcpiWalkResourceBuffer interfaces.
Local Cache Manager: Enhanced the main data structure to eliminate an unnecessary mechanism to access the next object in the list. Actually provides a small performance enhancement for hosts that use the local ACPICA cache manager. Jung-uk Kim.
Example Code and Data Size: These are the sizes for the OS-independent acpica.lib produced by the Microsoft Visual C++ 9.0 32-bit compiler. The debug version of the code includes the debug output trace mechanism and has a much larger code and data size.
Previous Release:
Non-Debug Version: 94.5K Code, 25.4K Data, 119.9K Total
Debug Version: 182.3K Code, 75.0K Data, 257.3K Total
Current Release:
Non-Debug Version: 95.0K Code, 25.9K Data, 120.9K Total
Debug Version: 182.9K Code, 75.6K Data, 258.5K Total
2) iASL Compiler/Disassembler and Tools:
iASL/Disassembler: Fixed several issues with the definition of the ACPI 5.0 RASF table (RAS Feature Table). This change incorporates late changes that were made to the ACPI 5.0 specification.
iASL/Disassembler: Added full support for the following new ACPI tables:
1) The MTMR table (MID Timer Table)
2) The VRTC table (Virtual Real Time Clock Table).
Includes header file, disassembler, table compiler, and template support for both tables.
iASL: Implemented compile-time validation of package objects returned by predefined names. This new feature validates static package objects returned by the various predefined names defined to return packages. Both object types and package lengths are validated, for both parent packages and sub-packages, if any. The code is similar in structure and behavior to the runtime repair mechanism within the AML interpreter and uses the existing predefined name information table. Adds a new file, aslprepkg.c. ACPICA BZ 938.
iASL: Implemented auto-detection of binary ACPI tables for disassembly. This feature detects a binary file with a valid ACPI table header and invokes the disassembler automatically. Eliminates the need to specifically invoke the disassembler with the -d option. ACPICA BZ 862.
iASL/Disassembler: Added several warnings for the case where there are unresolved control methods during the disassembly. This can potentially cause errors when the output file is compiled, because the disassembler assumes zero method arguments in these cases (it cannot determine the actual number of arguments without resolution/definition of the method).
Debugger: Added support to display all resources with a single command. Invocation of the resources command with no arguments will now display all resources within the current namespace.
AcpiHelp: Added descriptive text for each ACPICA exception code displayed via the -e option.
9 years, 3 months
[PATCH] tools/power/acpi: Introduce acpi_validate with manpage for easy validation of ACPI BIOS tables
by Thomas Renninger
The used iasl compiler shares the same code base as the kernel.
Warnings or errors mostly point to bad BIOSes.
These errors should get reported to the BIOS vendors and may indicated that
acpica (kernel ACPI parts) need compatibility adjustings.
Why is an extra tool needed for this?
The dynamic ACPI Source Language (ASL) parts are located in DSDT and often
multiple SSDT tables. Those often have dependencies to each other and the iasl
compiler often cannot resolve external symbols correctly if they are not
passed as external tables (iasl -e option) when tables get disassembled.
This quickly leads to false positive errors.
This tool makes sure disassembling and recompilation is done correctly.
This tool is also made for ACPI BIOS table verification for BIOS vendors and
hardware certification tools for distributions.
Hardware which supports Linux must/should not show any warnings or errors.
Remarks and optimization hints in the logs can be used to further enhance
the ACPI BIOS code.
Warnings and errors mostly describe the issues in a way, so that they can
get passed to and used by BIOS developers to fix the problems easily.
Signed-off-by: Thomas Renninger <trenn(a)suse.de>
---
tools/power/acpi/acpi_validate | 193 ++++++++++++++++++++++++++++++++++++++
tools/power/acpi/acpi_validate.8 | 72 ++++++++++++++
2 files changed, 265 insertions(+), 0 deletions(-)
create mode 100755 tools/power/acpi/acpi_validate
create mode 100644 tools/power/acpi/acpi_validate.8
diff --git a/tools/power/acpi/acpi_validate b/tools/power/acpi/acpi_validate
new file mode 100755
index 0000000..12d105b
--- /dev/null
+++ b/tools/power/acpi/acpi_validate
@@ -0,0 +1,193 @@
+#!/bin/bash
+#
+# Copyright (c) 2012 SUSE Linux Products GmbH
+# Thomas Renninger <trenn(a)suse.de>
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms and conditions of the GNU General Public License,
+# version 2, as published by the Free Software Foundation.
+#
+# This program is distributed in the hope it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+#
+
+OUTPUT_DIR="$PWD"
+VERBOSE=0
+# Disable remarks and resource checks. The latter often/mostly generates
+# false positive warnings. Can be overridden via -c option
+COMPILE_OPTIONS="-sa -cr -vr"
+DISASSEMBLE_OPTIONS=""
+OUTPUT="/dev/null"
+ACPIDUMP=""
+
+function usage()
+{
+ echo "acpi_validate [ -o output_dir ] [ -v ] [ -a acpidump ]"
+ echo " [ -c compile_options ] [ -d disassemble_options ]"
+ echo
+ echo "This tool extracts, disassembles and recompiles ACPI BIOS tables."
+ echo "The disassembled files will be copied into the local or specified"
+ echo "output directory (-o option)."
+ echo
+ echo "The underlying iasl compiler verifies and may complain about"
+ echo "correctness of some of the BIOS tables."
+ echo "These can give a pointer to possible malfunction of the system."
+ echo
+ echo "If you think you found a bug in the iasl compiler or related tools,"
+ echo "you can ask here for help: devel(a)acpica.org"
+ echo "You may also want to ask there if you are not sure whether it really"
+ echo "is a BIOS bug."
+ echo
+ echo "If you are sure you found a BIOS issue, complain to your hardware vendor."
+ echo "The iasl compiler typically provides a description of the warning/error in a way,"
+ echo "so that BIOS authors can easily fix it."
+ echo
+ echo "Options"
+ echo " -o output_dir: Copy tables to this directory instead of local one"
+ echo " -v: : be more verbose"
+ echo " -a acpidump : Use this acpidump file"
+ echo " instead of the tables from the local machine"
+ echo " -d options : Pass iasl disassemble options"
+ echo " -c options : Pass iasl compile options"
+ echo " will override -sa -cr -vr (default options)"
+ echo " -h : Show help"
+ exit 1
+}
+
+if [ "$(id -u)" != "0" ]; then
+ echo "This script must be run as root"
+ exit 1
+fi
+
+while getopts hva:o:c:d: name ; do
+ case $name in
+ o)
+ OUTPUT_DIR="$OPTARG"
+ if [ ! -d "$OUTPUT_DIR" ];then
+ mkdir "$OUTPUT_DIR"
+ if [[ $? != 0 ]];then
+ echo "Cannot create directory $OUTPUT_DIR"
+ exit 1
+ fi
+ elif [ ! -w "$OUTPUT_DIR" ];then
+ echo "Cannot write into directory $OUTPUT_DIR"
+ exit 1
+ fi
+
+ [[ $VERBOSE == 1 ]] && echo "Installing for architecture: $OUTPUT_DIR"
+ ;;
+ a)
+ ACPIDUMP="$OPTARG"
+ if [ ! -r "$ACPIDUMP" ];then
+ echo "$ACPIDUMP does not exist"
+ exit 1
+ fi
+ [[ $VERBOSE == 1 ]] && echo "acpidump file: $ACPIDUMP"
+ ;;
+ c)
+ COMPILE_OPTIONS="$OPTARG"
+ [[ $VERBOSE == 1 ]] && echo "Compile options: $COMPILE_OPTIONS"
+ ;;
+ c)
+ DISASSEMBLE_OPTIONS="$OPTARG"
+ [[ $VERBOSE == 1 ]] && echo "Disassemble options: $DISASSEMBLE_OPTIONS"
+ ;;
+ v)
+ VERBOSE=1
+ OUTPUT="1"
+ ;;
+ ?)
+ usage
+ ;;
+ esac
+done
+shift $(($OPTIND -1))
+
+shopt -s nocasematch
+TEMP_DIR=$(mktemp -d)
+[[ $VERBOSE == 1 ]] && echo "Using temporary directory: $TEMP_DIR"
+
+if [ -r "$ACPIDUMP" ];then
+ cp "$ACPIDUMP" "$TEMP_DIR"/acpidump
+fi
+
+pushd "$TEMP_DIR" >/dev/null
+
+mkdir log
+mkdir err
+if [ ! -r acpidump ];then
+ acpidump >acpidump
+fi
+acpixtract -a acpidump >&$OUTPUT 2>&1
+
+
+# ACPICA changed from uppercase to lowercase, try to find both:
+SDTs=$(ls [SD]DST*.dat 2>/dev/null)
+SDTs="${SDTs}$(ls [sd]sdt*.dat 2>/dev/null)"
+
+for file in *.dat;do
+ table=${file/.dat/}
+ # Enable case insensitive pattern matching
+
+ case $file in
+ [DS]SDT*.dat | [sd]sdt*.dat)
+ # Use other [sd]sdt*.dat tables to reference possible
+ # external symbols. Pass the table itself for disassembling
+ # comma separted.
+ # For example you we have:
+ # dsdt.dat ssdt1 ssdt2.dat
+ # and the current table to disassemble is ssdt1.dat the
+ # command has to be:
+ # iasl -e dsdt.dat,ssdt2.dat -d ssdt1.dat
+
+ # Get rid of the table which gets disassembled
+ # could have leading or trailing whitespace depending whether
+ # it is at the end or the beginning of the list
+ REF_TABLE_LIST=${SDTs/[[:space:]]$file/}
+ REF_TABLE_LIST=${SDTs/$file[[:space:]]/}
+ # Convert the whitespace list into a comma separated one:
+ REF_TABLE_LIST=${REF_TABLE_LIST//[[:space:]]/,}
+ echo "stdout and stderr of $file disassembling:" >log/${table}.log
+ iasl $DISASSEMBLE_OPTIONS -e ${REF_TABLE_LIST} -d $file 1>>log/${table}.log 2>&1
+ [[ $VERBOSE == 1 ]] && echo "iasl $DISASSEMBLE_OPTIONS -e ${REF_TABLE_LIST} -d $file 1>>log/${table}.log 2>&1"
+ iasl $COMPILE_OPTIONS ${table}.dsl 1>>log/${table}.log 2>>err/${table}.err
+ [[ $VERBOSE == 1 ]] && echo "iasl $COMPILE_OPTIONS ${table}.dsl 1>>log/${table}.log 2>>err/${table}.err"
+ ;;
+ *.dat)
+ iasl -d $file 1>log/${table}.log 2>&1
+ iasl -sa ${table}.dsl 1>log/${table}.log 2>err/${table}.err
+ ;;
+ esac
+done
+
+# remove empty error files
+rm $(find err -size 0)
+ERR_TABLES=$(ls err)
+ERR_TABLES=${ERR_TABLES//.err/}
+
+popd >/dev/null
+cp -r "$TEMP_DIR"/* "$OUTPUT_DIR"
+
+if [[ $VERBOSE == 1 ]];then
+ echo "Temporary directory (undeleted): $TEMP_DIR"
+else
+ rm -rf "$TEMP_DIR"
+fi
+
+if [ "$ERR_TABLES" = "" ];then
+ echo "No errors or warnings detected"
+ exit 0
+else
+ echo "These tables have warnings or errors (details in "$OUTPUT_DIR"/err directory):"
+ for err in $ERR_TABLES;do
+ echo -n $err $'\t'
+ sed -n -e 's/Compilation complete. \(.* Errors, .* Warnings\).*/\1/p' "$OUTPUT_DIR"/log/$err.log
+ done
+ exit 1
+fi
diff --git a/tools/power/acpi/acpi_validate.8 b/tools/power/acpi/acpi_validate.8
new file mode 100644
index 0000000..cd10694
--- /dev/null
+++ b/tools/power/acpi/acpi_validate.8
@@ -0,0 +1,72 @@
+.TH ACPI_VALIDATE 8
+.SH NAME
+acpi_validate \- Extracts, disassembles and recompiles ACPI BIOS tables.
+.SH SYNOPSIS
+.ft B
+.B acpica_validate [ \-o output_dir ] [ \-a acpidump ] [ \-v ] [ \-c compile_options ] [ \-d disassemble_options ]
+.SH DESCRIPTION
+\fBacpi_validate \fP extracts, disassembles and recompiles ACPI BIOS
+tables. The disassembled files will be copied into the local or specified
+output directory (-o option).
+
+The underlying iasl compiler verifies and may complain about correctness of
+some of the BIOS tables. Warnings or errors can give a pointer to possible
+malfunction of the system. The Linux kernel uses the same code base as the
+iasl interpreter which is used to validate tables.
+
+The ASL (ACPI Source Language) files (*.dsl) can get recompiled manually via
+\fBiasl -sa\fP and the resulting compilation (*.aml) can get passed to the
+kernel via the "Overriding ACPI tables via initrd" mechanism. Only use this
+feature if you know what you are doing. Read
+Documentation/acpi/initrd_table_override.txt (part of the kernel sources) for
+further information.
+
+If you think you found a bug in the iasl compiler or related
+tools, you can ask here for help: \fBdevel(a)acpica.org\fP
+
+You may also want to ask there if you are not sure whether it really
+is a BIOS bug.
+
+If you are sure you found a BIOS issue, complain to your hardware vendor. The
+iasl compiler typically provides a description of the warning/error in a way,
+so that BIOS authors can easily fix it.
+
+.SH OPTIONS
+\fB-o output_dir\fP
+
+The output directory where extracted, disassembled and
+recompiled tables are copied to. Compiler output is located in a log
+subdirectory, warnings and errors found by the compiler are located in the err
+directory.
+.PP
+\fB-a acpidump\fP
+
+Take this acpidump file instead of dumping and extracting
+ACPI tables from the local machine
+.PP
+\fB-v\fP
+
+Be more verbose
+.PP
+\fB-c options\fP
+
+Override default iasl compile options (default -sa -cr -vr)
+.PP
+\fB-d options\fP
+
+Override default iasl disassemble options
+
+.SH NOTES
+
+.B "acpi_validate"
+must be run as root.
+
+.SH REFERENCES
+ACPICA: https://acpica.org/
+
+.SH "SEE ALSO"
+.BR acpidump (8)
+
+.SH AUTHOR
+.nf
+Written by Thomas Renninger <trenn(a)suse.de>
--
1.7.6.1
9 years, 3 months
