ACPICA version 20140828 released
by Moore, Robert
28 August 2014. Summary of changes for version 20140828:
This release is available at https://acpica.org/downloads
1) ACPICA kernel-resident subsystem:
Fixed a problem related to the internal use of the Timer() operator where a 64-bit divide could cause an attempted link to a double-precision math library. This divide is not actually necessary, so the code was restructured to eliminate it. Lv Zheng.
ACPI 5.1: Added support for the runtime validation of the _DSD package (similar to the iASL support).
ACPI 5.1/Headers: Added support for the GICC affinity subtable to the SRAT table. Hanjun Guo <hanjun.guo(a)linaro.org>.
Example Code and Data Size: These are the sizes for the OS-independent acpica.lib produced by the Microsoft Visual C++ 9.0 32-bit compiler. The debug version of the code includes the debug output trace mechanism and has a much larger code and data size.
Current Release:
Non-Debug Version: 98.8K Code, 27.3K Data, 126.1K Total
Debug Version: 192.1K Code, 79.8K Data, 271.9K Total
Previous Release:
Non-Debug Version: 98.7K Code, 27.3K Data, 126.0K Total1
Debug Version: 192.0K Code, 79.7K Data, 271.7K Total
2) iASL Compiler/Disassembler and Tools:
AcpiExec: Fixed a problem on unix systems where the original terminal state was not always properly restored upon exit. Seen when using the -v option. ACPICA BZ 1104.
iASL: Fixed a problem with the validation of the ranges/length within the Memory24 resource descriptor. There was a boundary condition when the range was equal to the (length -1) caused by the fact that these values are defined in 256-byte blocks, not bytes. ACPICA BZ 1098
Disassembler: Fixed a problem with the GpioInt descriptor interrupt polarity flags. The flags are actually 2 bits, not 1, and the "ActiveBoth" keyword is now supported properly.
ACPI 5.1: Added the GICC affinity subtable to the SRAT table. Supported in the disassembler, data table compiler, and table template generator.
iASL: Added a requirement for Device() objects that one of either a _HID or _ADR must exist within the scope of a Device, as per the ACPI specification. Remove a similar requirement that was incorrectly in place for the _DSD object.
iASL: Added error detection for illegal named references within control methods that would cause runtime failures. Now trapped as errors are: 1) References to objects within a non-parent control method. 2) Forward references (within a method) -- for control methods, AML interpreters use a one-pass parse of control methods. ACPICA BZ 1008.
iASL: Added error checking for dependencies related to the _PSx power methods. ACPICA BZ 1029.
1) For _PS0, one of these must exist within the same scope: _PS1, _PS2, _PS3.
2) For _PS1, _PS2, and PS3: A _PS0 object must exist within the same scope.
iASL and table compiler: Cleanup miscellaneous memory leaks by fully deploying the existing object and string caches and adding new caches for the table compiler.
iASL: Split the huge parser source file into multiple subfiles to improve manageability. Generation now requires the M4 macro preprocessor, which is part of the Bison distribution on both unix and windows platforms.
AcpiSrc: Fixed and removed all extraneous warnings generated during entire ACPICA source code scan and/or conversion.
6 years, 8 months
Re: [Devel] [PATCH RFC] x86 early_ioremap: increase FIX_BTMAPS_SLOTS to 8
by Zheng, Lv
Hi,
> From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Dave Young
> Sent: Tuesday, August 26, 2014 5:07 PM
>
> 3.16 kernel boot fail with earlyprintk=efi, it keeps scrolling at the
> bottom line of screen.
>
> Bisected, the first bad commit is below:
> commit 86dfc6f339886559d80ee0d4bd20fe5ee90450f0
> Author: Lv Zheng <lv.zheng(a)intel.com>
> Date: Fri Apr 4 12:38:57 2014 +0800
>
> ACPICA: Tables: Fix table checksums verification before installation.
>
>
> I did some debugging by enabling both serial and efi earlyprintk, below is
> some debug dmesg, seems early_ioremap fails in scroll up function due to
> no free slot, see below dmesg output:
>
> [snip]
> [ 0.000000] RAMDISK: [mem 0x3e1b0000-0x3e982fff]
> [ 0.000000] ACPI: Early table checksum verification disabled
> [ 0.000000] ACPI: RSDP 0x00000000DB752000 000024 (v02 HPQOEM)
> [ 0.000000] ACPI: XSDT 0x00000000DB752088 00008C (v01 HPQOEM SLIC-WKS 01072009 AMI 00010013)
> [ 0.000000] ACPI: FACP 0x00000000DB759590 00010C (v05 HPQOEM SLIC-WKS 01072009 AMI 00010013)
> [ 0.000000] ------------[ cut here ]------------
> [ 0.000000] WARNING: CPU: 0 PID: 0 at mm/early_ioremap.c:116 __early_ioremap+0x90/0x1c4()
> [ 0.000000] __early_ioremap(ed00c800, 00000c80) not found slot
> [ 0.000000] Modules linked in:
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 3.17.0-rc1+ #204
> [ 0.000000] Hardware name: Hewlett-Packard HP Z420 Workstation/1589, BIOS J61 v03.15 05/09/2013
> [ 0.000000] 0000000000000000 ffffffff8173b970 ffffffff814bb919 ffffffff8173b9b8
> [ 0.000000] ffffffff8173b9a8 ffffffff810638c9 ffffffff8184ee81 ffffffffff538000
> [ 0.000000] 0000000000000c80 0000000000000003 0000000000000c80 ffffffff8173ba08
> [ 0.000000] Call Trace:
> [ 0.000000] [<ffffffff814bb919>] dump_stack+0x4e/0x7a
> [ 0.000000] [<ffffffff810638c9>] warn_slowpath_common+0x75/0x8e
> [ 0.000000] [<ffffffff8184ee81>] ? __early_ioremap+0x90/0x1c4
> [ 0.000000] [<ffffffff81063929>] warn_slowpath_fmt+0x47/0x49
> [ 0.000000] [<ffffffff8184ee81>] __early_ioremap+0x90/0x1c4
> [ 0.000000] [<ffffffff8124cf4d>] ? sprintf+0x46/0x48
> [ 0.000000] [<ffffffff8184f169>] early_ioremap+0x13/0x15
> [ 0.000000] [<ffffffff814ae4f0>] early_efi_map+0x24/0x26
> [ 0.000000] [<ffffffff81060985>] early_efi_scroll_up+0x6d/0xc0
> [ 0.000000] [<ffffffff81060b88>] early_efi_write+0x1b0/0x214
> [ 0.000000] [<ffffffff8109ec3a>] call_console_drivers.constprop.21+0x73/0x7e
> [ 0.000000] [<ffffffff8109fab4>] console_unlock+0x151/0x3b2
> [ 0.000000] [<ffffffff810a01b4>] ? vprintk_emit+0x49f/0x532
> [ 0.000000] [<ffffffff810a0236>] vprintk_emit+0x521/0x532
> [ 0.000000] [<ffffffff8109fce6>] ? console_unlock+0x383/0x3b2
> [ 0.000000] [<ffffffff814b6f01>] printk+0x4f/0x51
> [ 0.000000] [<ffffffff81292f9c>] acpi_os_vprintf+0x2b/0x2d
> [ 0.000000] [<ffffffff81292fe1>] acpi_os_printf+0x43/0x45
> [ 0.000000] [<ffffffff812bc44c>] acpi_info+0x5c/0x63
> [ 0.000000] [<ffffffff8183cdfa>] ? __acpi_map_table+0x13/0x18
> [ 0.000000] [<ffffffff814afc88>] ? acpi_os_map_iomem+0x21/0x147
> [ 0.000000] [<ffffffff812b7e59>] acpi_tb_print_table_header+0x177/0x186
> [ 0.000000] [<ffffffff812b79da>] acpi_tb_install_table_with_override+0x4b/0x62
> [ 0.000000] [<ffffffff812b7b80>] acpi_tb_install_standard_table+0xd9/0x215
> [ 0.000000] [<ffffffff8184f169>] ? early_ioremap+0x13/0x15
> [ 0.000000] [<ffffffff8183cdfa>] ? __acpi_map_table+0x13/0x18
> [ 0.000000] [<ffffffff81857545>] acpi_tb_parse_root_table+0x16e/0x1b4
> [ 0.000000] [<ffffffff818575e2>] acpi_initialize_tables+0x57/0x59
> [ 0.000000] [<ffffffff8185591d>] acpi_table_init+0x50/0xce
> [ 0.000000] [<ffffffff8183cea2>] acpi_boot_table_init+0x1e/0x85
> [ 0.000000] [<ffffffff81834638>] setup_arch+0x9b7/0xcc4
> [ 0.000000] [<ffffffff81830b3e>] start_kernel+0x94/0x42d
> [ 0.000000] [<ffffffff81830120>] ? early_idt_handlers+0x120/0x120
> [ 0.000000] [<ffffffff818304a2>] x86_64_start_reservations+0x2a/0x2c
> [ 0.000000] [<ffffffff81830597>] x86_64_start_kernel+0xf3/0x100
> [ 0.000000] ---[ end trace 48732c7db414b8fe ]---
> [ 0.000000] ------------[ cut here ]------------
> [ 0.000000] WARNING: CPU: 0 PID: 0 at mm/early_ioremap.c:116 __early_ioremap+0x90/0x1c4()
> [ 0.000000] __early_ioremap(ed00c800, 00000c80) not found slot
> [ 0.000000] Modules linked in:
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 3.17.0-rc1+ #204
> [ 0.000000] Hardware name: Hewlett-Packard HP Z420 Workstation/1589, BIOS J61 v03.15 05/09/2013
> [ 0.000000] 0000000000000000 ffffffff8173b970 ffffffff814bb919 ffffffff8173b9b8
> [ 0.000000] ffffffff8173b9a8 ffffffff810638c9 ffffffff8184ee81 ffffffffff538000
> [ 0.000000] 0000000000000c80 0000000000000003 0000000000000c80 ffffffff8173ba08
> [ 0.000000] Call Trace:
> [ 0.000000] [<ffffffff814bb919>] dump_stack+0x4e/0x7a
> [ 0.000000] [<ffffffff810638c9>] warn_slowpath_common+0x75/0x8e
> [ 0.000000] [<ffffffff8184ee81>] ? __early_ioremap+0x90/0x1c4
> [ 0.000000] [<ffffffff81063929>] warn_slowpath_fmt+0x47/0x49
> [ 0.000000] [<ffffffff8184ee81>] __early_ioremap+0x90/0x1c4
> [ 0.000000] [<ffffffff8184f169>] early_ioremap+0x13/0x15
> [ 0.000000] [<ffffffff814ae4f0>] early_efi_map+0x24/0x26
> [ 0.000000] [<ffffffff81060985>] early_efi_scroll_up+0x6d/0xc0
> [ 0.000000] [<ffffffff81060b88>] early_efi_write+0x1b0/0x214
> [ 0.000000] [<ffffffff8109ec3a>] call_console_drivers.constprop.21+0x73/0x7e
> [ 0.000000] [<ffffffff8109fb5d>] console_unlock+0x1fa/0x3b2
> [ 0.000000] [<ffffffff810a0236>] vprintk_emit+0x521/0x532
> [ 0.000000] [<ffffffff8109fce6>] ? console_unlock+0x383/0x3b2
> [ 0.000000] [<ffffffff814b6f01>] printk+0x4f/0x51
> [ 0.000000] [<ffffffff81292f9c>] acpi_os_vprintf+0x2b/0x2d
> [ 0.000000] [<ffffffff81292fe1>] acpi_os_printf+0x43/0x45
> [ 0.000000] [<ffffffff812bc44c>] acpi_info+0x5c/0x63
> [ 0.000000] [<ffffffff8183cdfa>] ? __acpi_map_table+0x13/0x18
> [ 0.000000] [<ffffffff814afc88>] ? acpi_os_map_iomem+0x21/0x147
> [ 0.000000] [<ffffffff812b7e59>] acpi_tb_print_table_header+0x177/0x186
> [ 0.000000] [<ffffffff812b79da>] acpi_tb_install_table_with_override+0x4b/0x62
> [ 0.000000] [<ffffffff812b7b80>] acpi_tb_install_standard_table+0xd9/0x215
> [ 0.000000] [<ffffffff8184f169>] ? early_ioremap+0x13/0x15
> [ 0.000000] [<ffffffff8183cdfa>] ? __acpi_map_table+0x13/0x18
> [ 0.000000] [<ffffffff81857545>] acpi_tb_parse_root_table+0x16e/0x1b4
> [ 0.000000] [<ffffffff818575e2>] acpi_initialize_tables+0x57/0x59
> [ 0.000000] [<ffffffff8185591d>] acpi_table_init+0x50/0xce
> [ 0.000000] [<ffffffff8183cea2>] acpi_boot_table_init+0x1e/0x85
> [ 0.000000] [<ffffffff81834638>] setup_arch+0x9b7/0xcc4
> [ 0.000000] [<ffffffff81830b3e>] start_kernel+0x94/0x42d
> [ 0.000000] [<ffffffff81830120>] ? early_idt_handlers+0x120/0x120
> [ 0.000000] [<ffffffff818304a2>] x86_64_start_reservations+0x2a/0x2c
>
>
> Quote reply from Lv.zheng about the early ioremap slot usage in this case:
>
> """
> In early_efi_scroll_up(), 2 mapping entries will be used for the src/dst screen buffer.
> In drivers/acpi/acpica/tbutils.c, we've improved the early table loading code in acpi_tb_parse_root_table().
> We now need 2 mapping entries:
> 1. One mapping entry is used for RSDT table mapping. Each RSDT entry contains an address for another ACPI table.
> 2. For each entry in RSDP, we need another mapping entry to map the table to perform necessary check/override before installing it.
>
> When acpi_tb_parse_root_table() prints something through EFI earlyprintk console, we'll have 4 mapping entries used.
> The current 4 slots setting of early_ioremap() seems to be too small for such a use case.
> """
In my reply, I only talked about 4 mapping entries which doesn't exceed the current number of early ioremap slot.
Was it better to offer early_ioremap_debug log to prove that we really need to increase it?
And to prove that all of the mappings are done by the code already upstreamed?
Thanks and best regards
-Lv
>
> Thus increase the slot to 8 in this patch to fix this issue.
> boot-time mappings become 512 page with this patch.
>
> Signed-off-by: Dave Young <dyoung(a)redhat.com>
> ---
> I'm not sure if this is ok in 32bit, review and comments are appreciated.
> arch/x86/include/asm/fixmap.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux/arch/x86/include/asm/fixmap.h
> ===================================================================
> --- linux.orig/arch/x86/include/asm/fixmap.h
> +++ linux/arch/x86/include/asm/fixmap.h
> @@ -106,14 +106,14 @@ enum fixed_addresses {
> __end_of_permanent_fixed_addresses,
>
> /*
> - * 256 temporary boot-time mappings, used by early_ioremap(),
> + * 512 temporary boot-time mappings, used by early_ioremap(),
> * before ioremap() is functional.
> *
> - * If necessary we round it up to the next 256 pages boundary so
> + * If necessary we round it up to the next 512 pages boundary so
> * that we can have a single pgd entry and a single pte table:
> */
> #define NR_FIX_BTMAPS 64
> -#define FIX_BTMAPS_SLOTS 4
> +#define FIX_BTMAPS_SLOTS 8
> #define TOTAL_FIX_BTMAPS (NR_FIX_BTMAPS * FIX_BTMAPS_SLOTS)
> FIX_BTMAP_END =
> (__end_of_permanent_fixed_addresses ^
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
6 years, 8 months
Re: [Devel] kernel boot fail with efi earlyprintk (bisected)
by Zheng, Lv
Hi,
> From: Dave Young [mailto:dyoung@redhat.com]
> Sent: Monday, August 25, 2014 2:07 PM
> To: Matt Fleming
> Cc: Zheng, Lv; Fleming, Matt; linux-efi(a)vger.kernel.org; linux-acpi(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; devel(a)acpica.org;
> lenb(a)kernel.org; Wysocki, Rafael J; Moore, Robert
> Subject: Re: kernel boot fail with efi earlyprintk (bisected)
>
> On 08/22/14 at 06:02pm, Dave Young wrote:
> > On 08/21/14 at 09:52pm, Matt Fleming wrote:
> > > On Tue, 19 Aug, at 04:16:58PM, Dave Young wrote:
> > > > Hi,
> > > >
> > > > 3.16 kernel boot fail with earlyprintk=efi on my laptop.
> > > > It keeps scrolling at the bottom line of screen.
> > > >
> > > > Bisected, the first bad commit is below:
> > > > commit 86dfc6f339886559d80ee0d4bd20fe5ee90450f0
> > > > Author: Lv Zheng <lv.zheng(a)intel.com>
> > > > Date: Fri Apr 4 12:38:57 2014 +0800
> > > >
> > > > ACPICA: Tables: Fix table checksums verification before installation.
> > > >
> > > >
> > > > I did some debugging by enabling both serial and efi earlyprintk, below is
> > > > some debug dmesg, seems early_ioremap fails in scroll up function due to
> > > > no free slot, but I'm still not sure if the debug info is right or not.
> > >
> > > Thanks Dave, your callstack seems to make sense.
> > >
> > > Can you also enable early_ioremap_debug so that we can figure out where
> > > all the FIXMAP slots are going?
> >
> > With early_ioremap_debug enabled, there will be a lot of "dropped printk", so
> > I can not get any useful information.
> >
> > Will try to do more debug.
>
> early_ioremap_debug does not work because we are debugging early_printk but
> early_ioremap_debug itself will print warning message at the same time.
>
> Tried what Lv mentioned, increasing the early ioremap slots does help.
Could you send a tested patch to linux-acpi(a)vger.kermel.org for this?
I think the number of early mapping slots need to be increased by 1 because of this case.
Thanks and best regards
-Lv
6 years, 8 months
Re: [Devel] kernel boot fail with efi earlyprintk (bisected)
by Zheng, Lv
Hi,
I checked the arch/x86/platform/efi/early_printk.c.
In early_efi_scroll_up(), 2 mapping entries will be used for the src/dst screen buffer.
In drivers/acpi/acpica/tbutils.c, we've improved the early table loading code in acpi_tb_parse_root_table().
We now need 2 mapping entries:
1. One mapping entry is used for RSDT table mapping. Each RSDT entry contains an address for another ACPI table.
2. For each entry in RSDP, we need another mapping entry to map the table to perform necessary check/override before installing it.
When acpi_tb_parse_root_table() prints something through EFI earlyprintk console, we'll have 4 mapping entries used.
The current 4 slots setting of early_ioremap() seems to be too small for such a use case.
I'm not 100% sure if this is the cause.
If it's the cause and we think both of the mappings are reasonable, we can simply increase the FIX_BITMAPS_SLOTS defined in arch/x86/include/asm/fixmap.h.
What do you think of this?
Thanks and best regards
-Lv
> From: Zheng, Lv
> Sent: Friday, August 22, 2014 9:43 AM
>
> Hi,
>
> There is only limited entries in the x86 early mapping which is implemented by the FIXMAP.
> So this means for all __init call invoked for x86, if there was a early mapping in it, it should be unmapped before exiting the __init call.
>
> Using this rule, all __init call implementers can make sure that before entering the __init call, the limited number of FIXMAP entries is
> enough.
>
> The following bisected commit just increase early mapping times from 1 to 2 in ACPICA early table handling code.
> The number of 2 is less than the number of available FIXMAP entries.
> And ACPICA code has ensured that all mappings are correctly unmapped after the table initialization.
> So we didn't break the rule.
>
> We can offer a workaround in ACPICA to reduce mapping count from 2 to 1 using a global option.
> But since this report sounds like that the root cause is earlyprintk=efi has broken the above rule and the existing issue is triggered by
> this cleanup.
> So could someone check the earlyprintk=efi code first?
> I think earlyprintk=efi should either unmap the increased mapping or increase the number of FIXMAP entries in case earlyprintk=efi
> need additional early mappings.
> Otherwise it will always be chances for earlyprintk=efi to break future code.
>
> Thanks and best regards
> -Lv
>
> > From: Matt Fleming [mailto:matt@console-pimps.org]
> > Sent: Friday, August 22, 2014 4:52 AM
> >
> > On Tue, 19 Aug, at 04:16:58PM, Dave Young wrote:
> > > Hi,
> > >
> > > 3.16 kernel boot fail with earlyprintk=efi on my laptop.
> > > It keeps scrolling at the bottom line of screen.
> > >
> > > Bisected, the first bad commit is below:
> > > commit 86dfc6f339886559d80ee0d4bd20fe5ee90450f0
> > > Author: Lv Zheng <lv.zheng(a)intel.com>
> > > Date: Fri Apr 4 12:38:57 2014 +0800
> > >
> > > ACPICA: Tables: Fix table checksums verification before installation.
> > >
> > >
> > > I did some debugging by enabling both serial and efi earlyprintk, below is
> > > some debug dmesg, seems early_ioremap fails in scroll up function due to
> > > no free slot, but I'm still not sure if the debug info is right or not.
> >
> > Thanks Dave, your callstack seems to make sense.
> >
> > Can you also enable early_ioremap_debug so that we can figure out where
> > all the FIXMAP slots are going?
> >
> > --
> > Matt Fleming, Intel Open Source Technology Center
6 years, 8 months
Re: [Devel] kernel boot fail with efi earlyprintk (bisected)
by Zheng, Lv
Hi,
There is only limited entries in the x86 early mapping which is implemented by the FIXMAP.
So this means for all __init call invoked for x86, if there was a early mapping in it, it should be unmapped before exiting the __init call.
Using this rule, all __init call implementers can make sure that before entering the __init call, the limited number of FIXMAP entries is enough.
The following bisected commit just increase early mapping times from 1 to 2 in ACPICA early table handling code.
The number of 2 is less than the number of available FIXMAP entries.
And ACPICA code has ensured that all mappings are correctly unmapped after the table initialization.
So we didn't break the rule.
We can offer a workaround in ACPICA to reduce mapping count from 2 to 1 using a global option.
But since this report sounds like that the root cause is earlyprintk=efi has broken the above rule and the existing issue is triggered by this cleanup.
So could someone check the earlyprintk=efi code first?
I think earlyprintk=efi should either unmap the increased mapping or increase the number of FIXMAP entries in case earlyprintk=efi need additional early mappings.
Otherwise it will always be chances for earlyprintk=efi to break future code.
Thanks and best regards
-Lv
> From: Matt Fleming [mailto:matt@console-pimps.org]
> Sent: Friday, August 22, 2014 4:52 AM
>
> On Tue, 19 Aug, at 04:16:58PM, Dave Young wrote:
> > Hi,
> >
> > 3.16 kernel boot fail with earlyprintk=efi on my laptop.
> > It keeps scrolling at the bottom line of screen.
> >
> > Bisected, the first bad commit is below:
> > commit 86dfc6f339886559d80ee0d4bd20fe5ee90450f0
> > Author: Lv Zheng <lv.zheng(a)intel.com>
> > Date: Fri Apr 4 12:38:57 2014 +0800
> >
> > ACPICA: Tables: Fix table checksums verification before installation.
> >
> >
> > I did some debugging by enabling both serial and efi earlyprintk, below is
> > some debug dmesg, seems early_ioremap fails in scroll up function due to
> > no free slot, but I'm still not sure if the debug info is right or not.
>
> Thanks Dave, your callstack seems to make sense.
>
> Can you also enable early_ioremap_debug so that we can figure out where
> all the FIXMAP slots are going?
>
> --
> Matt Fleming, Intel Open Source Technology Center
6 years, 8 months
Patch to override "Creator ID" and "Creator Revision"
by Neel Natu
Hi,
The following patch allows the "Creator ID" and "Creator Revision" to
be overridden at compile time.
At the moment the "Creator Revision" is a stand-in for the compiler
version which implies that the tables change every time the compiler
version changes. This patch decouples "Creator Revision" from the
compiler version.
It would be great if this could be committed.
best
Neel
diff --git a/source/compiler/asldefine.h b/source/compiler/asldefine.h
index b05bd7f..6a15bf1 100644
--- a/source/compiler/asldefine.h
+++ b/source/compiler/asldefine.h
@@ -125,7 +125,9 @@
#define ASL_COMPILER_NAME "ASL Optimizing Compiler"
#define AML_DISASSEMBLER_NAME "AML Disassembler"
#define ASL_INVOCATION_NAME "iasl"
+#ifndef ASL_CREATOR_ID
#define ASL_CREATOR_ID "INTL"
+#endif
#define ASL_COMPLIANCE "Supports ACPI Specification Revision 5.1"
diff --git a/source/include/acpixf.h b/source/include/acpixf.h
index cafc37b..005325c 100644
--- a/source/include/acpixf.h
+++ b/source/include/acpixf.h
@@ -118,7 +118,9 @@
/* Current ACPICA subsystem version in YYYYMMDD format */
+#ifndef ACPI_CA_VERSION
#define ACPI_CA_VERSION 0x20140724
+#endif
#include "acconfig.h"
#include "actypes.h"
6 years, 9 months