Re: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms
- First Post
- Replies
- Stats
-
Go to
- ----- 2022 -----
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
On Thu, Feb 24, 2022 at 12:38 PM Paul Menzel <pmenzel(a)molgen.mpg.de> wrote:
Quick boottime is important, so warn about sleeps greater than 50 ms in
ACPI.
50 ms is still long compared to distribution Linux kernels reaching initrd
in 350 ms, so should probably changed to 10 ms, so people are aware
about this.
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
First off, as ACPICA material, this should be submitted to the
upstream project via https://github.com/acpica/acpica/.
---
drivers/acpi/acpica/exsystem.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c
index 00f66af31ffa..bdffb8aac05c 100644
--- a/drivers/acpi/acpica/exsystem.c
+++ b/drivers/acpi/acpica/exsystem.c
@@ -167,6 +167,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
acpi_ex_exit_interpreter();
+ if (how_long_ms > 50) {
+ ACPI_WARNING((AE_INFO,
Second, the log level is somewhat high for something like this.
+ "Time parameter %llu > 50 ms. Please
contact firmware vendor for more responsive system.", how_long_ms));
Also, I would rephrase the warning message to something like "Firmware
issue: Excessive delay (%llu ms) in ACPI Control Method".
> + }
> +
> /*
> * For compatibility with other ACPI implementations and to prevent
> * accidental deep sleeps, limit the sleep time to something reasonable.
> --
> 2.35.1
>
175
days inactive
175
days old
0 comments
1 participants
tags (0)
participants (1)
-
Rafael J. Wysocki