tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge head: 8c649da5a7719ff87155d4c9e850f374a39856d4 commit: fd46b1aebee729fb984f74b7b8d81db210ec6355 [136/148] ACPI: SPCR: work around clock issue on xgene UART config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout fd46b1aebee729fb984f74b7b8d81db210ec6355 # save the attached .config to linux build tree make.cross ARCH=arm64 All error/warnings (new ones prefixed by >>): drivers//acpi/spcr.c: In function 'parse_spcr': if (xgene_8250_erratum_present(table)) ^~ drivers//acpi/spcr.c:198:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' snprintf(opts, sizeof(opts), "%s,%s,0x%llx", uart, iotype, ^~~~~~~~ goto done; ^~~~ drivers//acpi/spcr.c: At top level: } else { ^~~~ In file included from include/linux/printk.h:6:0, from include/linux/kernel.h:13, from include/linux/list.h:8, from include/linux/resource_ext.h:17, from include/linux/acpi.h:26, from drivers//acpi/spcr.c:14: #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~~~~~ include/linux/printk.h:308:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~ pr_info("console: %s\n", opts); ^~~~~~~ In file included from include/linux/kernel.h:13:0, from include/linux/list.h:8, from include/linux/resource_ext.h:17, from include/linux/acpi.h:26, from drivers//acpi/spcr.c:14: pr_info("console: %s\n", opts); ^ include/linux/printk.h:308:34: note: in definition of macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ if (earlycon) ^~ err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~ err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~~ err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~~ done: ^ return err; ^~~~~~ } ^ drivers//acpi/spcr.c: In function 'parse_spcr': } else { ^ cc1: some warnings being treated as errors -- drivers/acpi/spcr.c: In function 'parse_spcr': drivers/acpi/spcr.c:191:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (xgene_8250_erratum_present(table)) ^~ drivers/acpi/spcr.c:198:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' snprintf(opts, sizeof(opts), "%s,%s,0x%llx", uart, iotype, ^~~~~~~~ drivers/acpi/spcr.c:164:3: error: label 'done' used but not defined goto done; ^~~~ drivers/acpi/spcr.c: At top level: drivers/acpi/spcr.c:200:4: error: expected identifier or '(' before 'else' } else { ^~~~ In file included from include/linux/printk.h:6:0, from include/linux/kernel.h:13, from include/linux/list.h:8, from include/linux/resource_ext.h:17, from include/linux/acpi.h:26, from drivers/acpi/spcr.c:14: #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~~~~~ include/linux/printk.h:308:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~ drivers/acpi/spcr.c:205:2: note: in expansion of macro 'pr_info' pr_info("console: %s\n", opts); ^~~~~~~ In file included from include/linux/kernel.h:13:0, from include/linux/list.h:8, from include/linux/resource_ext.h:17, from include/linux/acpi.h:26, from drivers/acpi/spcr.c:14: drivers/acpi/spcr.c:205:27: error: unknown type name 'opts' pr_info("console: %s\n", opts); ^ include/linux/printk.h:308:34: note: in definition of macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/acpi/spcr.c:207:2: error: expected identifier or '(' before 'if' if (earlycon) ^~ drivers/acpi/spcr.c:210:2: warning: data definition has no type or storage class err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~ drivers/acpi/spcr.c:210:2: error: type defaults to 'int' in declaration of 'err' [-Werror=implicit-int] drivers/acpi/spcr.c:210:30: error: 'uart' undeclared here (not in a function) err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~~ drivers/acpi/spcr.c:210:39: error: 'opts' undeclared here (not in a function) err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ^~~~ drivers/acpi/spcr.c:212:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token done: ^ drivers/acpi/spcr.c:214:2: error: expected identifier or '(' before 'return' return err; ^~~~~~ drivers/acpi/spcr.c:215:1: error: expected identifier or '(' before '}' token } ^ drivers/acpi/spcr.c: In function 'parse_spcr': drivers/acpi/spcr.c:200:2: warning: control reaches end of non-void function [-Wreturn-type] } else { ^ cc1: some warnings being treated as errors vim +/pr_info +205 drivers//acpi/spcr.c ad1696f6f Aleksey Makarov 2016-09-27 13 ad1696f6f Aleksey Makarov 2016-09-27 @14 #include <linux/acpi.h> ad1696f6f Aleksey Makarov 2016-09-27 15 #include <linux/console.h> ad1696f6f Aleksey Makarov 2016-09-27 16 #include <linux/kernel.h> ad1696f6f Aleksey Makarov 2016-09-27 17 #include <linux/serial_core.h> ad1696f6f Aleksey Makarov 2016-09-27 18 d8a4995bc Christopher Covington 2017-02-15 19 /* 37ef38f3f Timur Tabi 2017-07-27 20 * Erratum 44 for QDF2432v1 and QDF2400v1 SoCs describes the BUSY bit as 37ef38f3f Timur Tabi 2017-07-27 21 * occasionally getting stuck as 1. To avoid the potential for a hang, check 37ef38f3f Timur Tabi 2017-07-27 22 * TXFE == 0 instead of BUSY == 1. This may not be suitable for all UART 37ef38f3f Timur Tabi 2017-07-27 23 * implementations, so only do so if an affected platform is detected in 37ef38f3f Timur Tabi 2017-07-27 24 * parse_spcr(). 37ef38f3f Timur Tabi 2017-07-27 25 */ 37ef38f3f Timur Tabi 2017-07-27 26 bool qdf2400_e44_present; 37ef38f3f Timur Tabi 2017-07-27 27 EXPORT_SYMBOL(qdf2400_e44_present); 37ef38f3f Timur Tabi 2017-07-27 28 37ef38f3f Timur Tabi 2017-07-27 29 /* d8a4995bc Christopher Covington 2017-02-15 30 * Some Qualcomm Datacenter Technologies SoCs have a defective UART BUSY bit. d8a4995bc Christopher Covington 2017-02-15 31 * Detect them by examining the OEM fields in the SPCR header, similiar to PCI d8a4995bc Christopher Covington 2017-02-15 32 * quirk detection in pci_mcfg.c. d8a4995bc Christopher Covington 2017-02-15 33 */ d8a4995bc Christopher Covington 2017-02-15 34 static bool qdf2400_erratum_44_present(struct acpi_table_header *h) d8a4995bc Christopher Covington 2017-02-15 35 { d8a4995bc Christopher Covington 2017-02-15 36 if (memcmp(h->oem_id, "QCOM ", ACPI_OEM_ID_SIZE)) d8a4995bc Christopher Covington 2017-02-15 37 return false; d8a4995bc Christopher Covington 2017-02-15 38 d8a4995bc Christopher Covington 2017-02-15 39 if (!memcmp(h->oem_table_id, "QDF2432 ", ACPI_OEM_TABLE_ID_SIZE)) d8a4995bc Christopher Covington 2017-02-15 40 return true; d8a4995bc Christopher Covington 2017-02-15 41 d8a4995bc Christopher Covington 2017-02-15 42 if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) && 542ed7846 Timur Tabi 2017-02-28 43 h->oem_revision == 1) d8a4995bc Christopher Covington 2017-02-15 44 return true; d8a4995bc Christopher Covington 2017-02-15 45 d8a4995bc Christopher Covington 2017-02-15 46 return false; d8a4995bc Christopher Covington 2017-02-15 47 } d8a4995bc Christopher Covington 2017-02-15 48 79a648328 Loc Ho 2017-07-03 49 /* 79a648328 Loc Ho 2017-07-03 50 * APM X-Gene v1 and v2 UART hardware is an 16550 like device but has its 79a648328 Loc Ho 2017-07-03 51 * register aligned to 32-bit. In addition, the BIOS also encoded the 79a648328 Loc Ho 2017-07-03 52 * access width to be 8 bits. This function detects this errata condition. 79a648328 Loc Ho 2017-07-03 53 */ 79a648328 Loc Ho 2017-07-03 54 static bool xgene_8250_erratum_present(struct acpi_table_spcr *tb) 79a648328 Loc Ho 2017-07-03 55 { dee82bc1e Graeme Gregory 2017-08-04 56 bool xgene_8250 = false; dee82bc1e Graeme Gregory 2017-08-04 57 79a648328 Loc Ho 2017-07-03 58 if (tb->interface_type != ACPI_DBG2_16550_COMPATIBLE) 79a648328 Loc Ho 2017-07-03 59 return false; 79a648328 Loc Ho 2017-07-03 60 dee82bc1e Graeme Gregory 2017-08-04 61 if (memcmp(tb->header.oem_id, "APMC0D", ACPI_OEM_ID_SIZE) && dee82bc1e Graeme Gregory 2017-08-04 62 memcmp(tb->header.oem_id, "HPE ", ACPI_OEM_ID_SIZE)) 79a648328 Loc Ho 2017-07-03 63 return false; 79a648328 Loc Ho 2017-07-03 64 79a648328 Loc Ho 2017-07-03 65 if (!memcmp(tb->header.oem_table_id, "XGENESPC", 79a648328 Loc Ho 2017-07-03 66 ACPI_OEM_TABLE_ID_SIZE) && tb->header.oem_revision == 0) dee82bc1e Graeme Gregory 2017-08-04 67 xgene_8250 = true; 79a648328 Loc Ho 2017-07-03 68 dee82bc1e Graeme Gregory 2017-08-04 69 if (!memcmp(tb->header.oem_table_id, "ProLiant", dee82bc1e Graeme Gregory 2017-08-04 70 ACPI_OEM_TABLE_ID_SIZE) && tb->header.oem_revision == 1) dee82bc1e Graeme Gregory 2017-08-04 71 xgene_8250 = true; dee82bc1e Graeme Gregory 2017-08-04 72 dee82bc1e Graeme Gregory 2017-08-04 73 return xgene_8250; 79a648328 Loc Ho 2017-07-03 74 } 79a648328 Loc Ho 2017-07-03 75 ad1696f6f Aleksey Makarov 2016-09-27 76 /** ad1696f6f Aleksey Makarov 2016-09-27 77 * parse_spcr() - parse ACPI SPCR table and add preferred console ad1696f6f Aleksey Makarov 2016-09-27 78 * ad1696f6f Aleksey Makarov 2016-09-27 79 * @earlycon: set up earlycon for the console specified by the table ad1696f6f Aleksey Makarov 2016-09-27 80 * ad1696f6f Aleksey Makarov 2016-09-27 81 * For the architectures with support for ACPI, CONFIG_ACPI_SPCR_TABLE may be ad1696f6f Aleksey Makarov 2016-09-27 82 * defined to parse ACPI SPCR table. As a result of the parsing preferred ad1696f6f Aleksey Makarov 2016-09-27 83 * console is registered and if @earlycon is true, earlycon is set up. ad1696f6f Aleksey Makarov 2016-09-27 84 * ad1696f6f Aleksey Makarov 2016-09-27 85 * When CONFIG_ACPI_SPCR_TABLE is defined, this function should be called 183b8021f Masahiro Yamada 2017-02-27 86 * from arch initialization code as soon as the DT/ACPI decision is made. ad1696f6f Aleksey Makarov 2016-09-27 87 * ad1696f6f Aleksey Makarov 2016-09-27 88 */ ad1696f6f Aleksey Makarov 2016-09-27 89 int __init parse_spcr(bool earlycon) ad1696f6f Aleksey Makarov 2016-09-27 90 { ad1696f6f Aleksey Makarov 2016-09-27 91 static char opts[64]; ad1696f6f Aleksey Makarov 2016-09-27 92 struct acpi_table_spcr *table; ad1696f6f Aleksey Makarov 2016-09-27 93 acpi_status status; ad1696f6f Aleksey Makarov 2016-09-27 94 char *uart; ad1696f6f Aleksey Makarov 2016-09-27 95 char *iotype; ad1696f6f Aleksey Makarov 2016-09-27 96 int baud_rate; ad1696f6f Aleksey Makarov 2016-09-27 97 int err; ad1696f6f Aleksey Makarov 2016-09-27 98 ad1696f6f Aleksey Makarov 2016-09-27 99 if (acpi_disabled) ad1696f6f Aleksey Makarov 2016-09-27 100 return -ENODEV; ad1696f6f Aleksey Makarov 2016-09-27 101 6b11d1d67 Lv Zheng 2016-12-14 102 status = acpi_get_table(ACPI_SIG_SPCR, 0, 6b11d1d67 Lv Zheng 2016-12-14 103 (struct acpi_table_header **)&table); ad1696f6f Aleksey Makarov 2016-09-27 104 ad1696f6f Aleksey Makarov 2016-09-27 105 if (ACPI_FAILURE(status)) ad1696f6f Aleksey Makarov 2016-09-27 106 return -ENOENT; ad1696f6f Aleksey Makarov 2016-09-27 107 ad1696f6f Aleksey Makarov 2016-09-27 108 if (table->header.revision < 2) { ad1696f6f Aleksey Makarov 2016-09-27 109 err = -ENOENT; ad1696f6f Aleksey Makarov 2016-09-27 110 pr_err("wrong table version\n"); ad1696f6f Aleksey Makarov 2016-09-27 111 goto done; ad1696f6f Aleksey Makarov 2016-09-27 112 } ad1696f6f Aleksey Makarov 2016-09-27 113 2bece4939 Loc Ho 2017-07-03 114 if (table->serial_port.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) { 2bece4939 Loc Ho 2017-07-03 115 switch (table->serial_port.access_width) { 2bece4939 Loc Ho 2017-07-03 116 default: 2bece4939 Loc Ho 2017-07-03 117 pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n"); 2bece4939 Loc Ho 2017-07-03 118 case ACPI_ACCESS_SIZE_BYTE: 2bece4939 Loc Ho 2017-07-03 119 iotype = "mmio"; 2bece4939 Loc Ho 2017-07-03 120 break; 2bece4939 Loc Ho 2017-07-03 121 case ACPI_ACCESS_SIZE_WORD: 2bece4939 Loc Ho 2017-07-03 122 iotype = "mmio16"; 2bece4939 Loc Ho 2017-07-03 123 break; 2bece4939 Loc Ho 2017-07-03 124 case ACPI_ACCESS_SIZE_DWORD: 2bece4939 Loc Ho 2017-07-03 125 iotype = "mmio32"; 2bece4939 Loc Ho 2017-07-03 126 break; 2bece4939 Loc Ho 2017-07-03 127 } 2bece4939 Loc Ho 2017-07-03 128 } else 2bece4939 Loc Ho 2017-07-03 129 iotype = "io"; ad1696f6f Aleksey Makarov 2016-09-27 130 ad1696f6f Aleksey Makarov 2016-09-27 131 switch (table->interface_type) { ad1696f6f Aleksey Makarov 2016-09-27 132 case ACPI_DBG2_ARM_SBSA_32BIT: ad1696f6f Aleksey Makarov 2016-09-27 133 iotype = "mmio32"; ad1696f6f Aleksey Makarov 2016-09-27 134 /* fall through */ ad1696f6f Aleksey Makarov 2016-09-27 135 case ACPI_DBG2_ARM_PL011: ad1696f6f Aleksey Makarov 2016-09-27 136 case ACPI_DBG2_ARM_SBSA_GENERIC: ad1696f6f Aleksey Makarov 2016-09-27 137 case ACPI_DBG2_BCM2835: ad1696f6f Aleksey Makarov 2016-09-27 138 uart = "pl011"; ad1696f6f Aleksey Makarov 2016-09-27 139 break; ad1696f6f Aleksey Makarov 2016-09-27 140 case ACPI_DBG2_16550_COMPATIBLE: ad1696f6f Aleksey Makarov 2016-09-27 141 case ACPI_DBG2_16550_SUBSET: ad1696f6f Aleksey Makarov 2016-09-27 142 uart = "uart"; ad1696f6f Aleksey Makarov 2016-09-27 143 break; ad1696f6f Aleksey Makarov 2016-09-27 144 default: ad1696f6f Aleksey Makarov 2016-09-27 145 err = -ENOENT; ad1696f6f Aleksey Makarov 2016-09-27 146 goto done; ad1696f6f Aleksey Makarov 2016-09-27 147 } ad1696f6f Aleksey Makarov 2016-09-27 148 ad1696f6f Aleksey Makarov 2016-09-27 149 switch (table->baud_rate) { ad1696f6f Aleksey Makarov 2016-09-27 150 case 3: ad1696f6f Aleksey Makarov 2016-09-27 151 baud_rate = 9600; ad1696f6f Aleksey Makarov 2016-09-27 152 break; ad1696f6f Aleksey Makarov 2016-09-27 153 case 4: ad1696f6f Aleksey Makarov 2016-09-27 154 baud_rate = 19200; ad1696f6f Aleksey Makarov 2016-09-27 155 break; ad1696f6f Aleksey Makarov 2016-09-27 156 case 6: ad1696f6f Aleksey Makarov 2016-09-27 157 baud_rate = 57600; ad1696f6f Aleksey Makarov 2016-09-27 158 break; ad1696f6f Aleksey Makarov 2016-09-27 159 case 7: ad1696f6f Aleksey Makarov 2016-09-27 160 baud_rate = 115200; ad1696f6f Aleksey Makarov 2016-09-27 161 break; ad1696f6f Aleksey Makarov 2016-09-27 162 default: ad1696f6f Aleksey Makarov 2016-09-27 163 err = -ENOENT; ad1696f6f Aleksey Makarov 2016-09-27 @164 goto done; ad1696f6f Aleksey Makarov 2016-09-27 165 } ad1696f6f Aleksey Makarov 2016-09-27 166 37ef38f3f Timur Tabi 2017-07-27 167 /* 37ef38f3f Timur Tabi 2017-07-27 168 * If the E44 erratum is required, then we need to tell the pl011 37ef38f3f Timur Tabi 2017-07-27 169 * driver to implement the work-around. 37ef38f3f Timur Tabi 2017-07-27 170 * 37ef38f3f Timur Tabi 2017-07-27 171 * The global variable is used by the probe function when it 37ef38f3f Timur Tabi 2017-07-27 172 * creates the UARTs, whether or not they're used as a console. 37ef38f3f Timur Tabi 2017-07-27 173 * 37ef38f3f Timur Tabi 2017-07-27 174 * If the user specifies "traditional" earlycon, the qdf2400_e44 37ef38f3f Timur Tabi 2017-07-27 175 * console name matches the EARLYCON_DECLARE() statement, and 37ef38f3f Timur Tabi 2017-07-27 176 * SPCR is not used. Parameter "earlycon" is false. 37ef38f3f Timur Tabi 2017-07-27 177 * 37ef38f3f Timur Tabi 2017-07-27 178 * If the user specifies "SPCR" earlycon, then we need to update 37ef38f3f Timur Tabi 2017-07-27 179 * the console name so that it also says "qdf2400_e44". Parameter 37ef38f3f Timur Tabi 2017-07-27 180 * "earlycon" is true. 37ef38f3f Timur Tabi 2017-07-27 181 * 37ef38f3f Timur Tabi 2017-07-27 182 * For consistency, if we change the console name, then we do it 37ef38f3f Timur Tabi 2017-07-27 183 * for everyone, not just earlycon. 37ef38f3f Timur Tabi 2017-07-27 184 */ 37ef38f3f Timur Tabi 2017-07-27 185 if (qdf2400_erratum_44_present(&table->header)) { 37ef38f3f Timur Tabi 2017-07-27 186 qdf2400_e44_present = true; 37ef38f3f Timur Tabi 2017-07-27 187 if (earlycon) d8a4995bc Christopher Covington 2017-02-15 188 uart = "qdf2400_e44"; 37ef38f3f Timur Tabi 2017-07-27 189 } 37ef38f3f Timur Tabi 2017-07-27 190 79a648328 Loc Ho 2017-07-03 @191 if (xgene_8250_erratum_present(table)) 79a648328 Loc Ho 2017-07-03 192 iotype = "mmio32"; d8a4995bc Christopher Covington 2017-02-15 193 fd46b1aeb Graeme Gregory 2017-08-04 194 /* for xgene v1 and v2 we don't know the clock rate of the fd46b1aeb Graeme Gregory 2017-08-04 195 * UART so don't attempt to change to the baud rate state fd46b1aeb Graeme Gregory 2017-08-04 196 * in the table because driver cannot calculate the dividers fd46b1aeb Graeme Gregory 2017-08-04 197 */ fd46b1aeb Graeme Gregory 2017-08-04 @198 snprintf(opts, sizeof(opts), "%s,%s,0x%llx", uart, iotype, fd46b1aeb Graeme Gregory 2017-08-04 199 table->serial_port.address); fd46b1aeb Graeme Gregory 2017-08-04 @200 } else { ad1696f6f Aleksey Makarov 2016-09-27 201 snprintf(opts, sizeof(opts), "%s,%s,0x%llx,%d", uart, iotype, ad1696f6f Aleksey Makarov 2016-09-27 202 table->serial_port.address, baud_rate); fd46b1aeb Graeme Gregory 2017-08-04 203 } ad1696f6f Aleksey Makarov 2016-09-27 204 ad1696f6f Aleksey Makarov 2016-09-27 @205 pr_info("console: %s\n", opts); ad1696f6f Aleksey Makarov 2016-09-27 206 ad1696f6f Aleksey Makarov 2016-09-27 @207 if (earlycon) ad1696f6f Aleksey Makarov 2016-09-27 208 setup_earlycon(opts); ad1696f6f Aleksey Makarov 2016-09-27 209 ad1696f6f Aleksey Makarov 2016-09-27 @210 err = add_preferred_console(uart, 0, opts + strlen(uart) + 1); ad1696f6f Aleksey Makarov 2016-09-27 211 ad1696f6f Aleksey Makarov 2016-09-27 @212 done: 6b11d1d67 Lv Zheng 2016-12-14 213 acpi_put_table((struct acpi_table_header *)table); ad1696f6f Aleksey Makarov 2016-09-27 @214 return err; ad1696f6f Aleksey Makarov 2016-09-27 @215 } :::::: The code at line 205 was first introduced by commit :::::: ad1696f6f09daacfdf2bf04bc83cd8f48d80e34a ACPI: parse SPCR and enable matching console :::::: TO: Aleksey Makarov <aleksey.makarov(a)linaro.org&gt; :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org&gt; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation