12:40 a.m.
Hey,
Another one against dleyna-renderer that should stop random crashes from
the control point and context manager signal handlers.
Happy hacking,
Debarshi
1:06 a.m.
On 01/20/2015 03:40 PM, Debarshi Ray wrote:
Another one against dleyna-renderer that should stop random crashes
from the control point and context manager signal handlers. A
GUPnPContextManager can outlive a dlr_upnp_t because it might be
using asynchronous operations during its construction (eg.,
GUPnPNetworkManager) which retain references to it.
This issue is a circular reference bug in gupnp:
https://bugzilla.gnome.org/show_bug.cgi?id=741257
Instead of patching dleyna to work around it, you should fix gupnp instead.
Alex
2:29 a.m.
Hey Alexander,
On Tue, Jan 20, 2015 at 04:06:17PM +0200, Alexander Kanavin wrote:
On 01/20/2015 03:40 PM, Debarshi Ray wrote:
> Another one against dleyna-renderer that should stop random crashes
> from the control point and context manager signal handlers. A
> GUPnPContextManager can outlive a dlr_upnp_t because it might be
> using asynchronous operations during its construction (eg.,
> GUPnPNetworkManager) which retain references to it.
This issue is a circular reference bug in gupnp:
https://bugzilla.gnome.org/show_bug.cgi?id=741257
Commented on the bug.
Instead of patching dleyna to work around it, you should fix
gupnp instead.
I am waiting for a reply from Jens why the private GCancellable is not
being used to cancel the pending operations (see my comment on the bug
for context). At first glance it looks weird that a GCancellable is
actually being passed around, but instead of using it to cancel the
operations, the code relies on the reference count to finish the
operations.
Until we figure that out, I can keep the workaround as a downstream
patch to stop the in-flow of crash reports. The interaction in dleyna
is more straightforward than in gupnp, which is why I don't want to
touch the later without a confirmation from one of the maintainers.
Thanks,
Debarshi
2798
days inactive
2798
days old
2 comments
2 participants
participants (2)
-
Alexander Kanavin -
Debarshi Ray