11:51 p.m.
Hi all,
I finally have some time to work on dleyna upstream and figured I'd
ping the list. Also, there are a couple of new people working on the
stack (hi Richard, Rasika)... So now is probably a good time to make a
little noise if you have pet bugs you want fixed.
I've gone through the open dleyna issues in the last couple of days
for rough scheduling: I've used a "for-next" label with the meaning
"These are low hanging fruit or otherwise good ideas I'll try to fix
in the next week or so". Maybe after all or most of those are merged
we can think of making a bug fix release. In any case, "for-next" is
just my opinion, nothing set in stone.
https://github.com/01org/dleyna-core/issues?labels=for-next
https://github.com/01org/dleyna-renderer/issues?labels=for-next
https://github.com/01org/dleyna-server/issues?labels=for-next
Please file an issue or comment on existing ones if you have something to add.
Some of those issues already have patches but I didn't merge yet: I
intend to do that but reviews from others are welcome as well. Some
require a little work which I'm prepared to do in the next couple of
days: please review when I have a pull request.
There are one or two bigger items that do not have patches: I'll take
a look and drop the the label if it seems like too extensive to do in
a short time or if it seems risky .
Jussi
6:36 p.m.
On 3 July 2014 16:51, Jussi Kukkonen <jussi.kukkonen(a)intel.com> wrote:
I've gone through the open dleyna issues in the last couple of
days
for rough scheduling: I've used a "for-next" label with the meaning
"These are low hanging fruit or otherwise good ideas I'll try to fix
in the next week or so".
Followup on this:
dleyna-core:
* 2 build system issues fixed
* 1 bug left with "for-next" label:
https://github.com/01org/dleyna-core/pull/43
I don't see it as a blocker (if dbus goes away, dleyna is pretty
useless in any case)
dleyna-renderer:
* 6 issues fixed
* 3 left with "for-next" label
https://github.com/01org/dleyna-renderer/issues/140
- not 100% sure what should be fixed
https://github.com/01org/dleyna-renderer/pull/132 (and 114)
- The idea is certainly good but the uuid parsing is problematic since
we can't make assumptions about the format (early specs did not
define the format). Not a blocker
https://github.com/01org/dleyna-renderer/issues/104
- I agree with the idea of fetching introspection data on device
construction,
but have not done anything yet. I don't think we have outstanding crashes
so this doesn't need to block anything.
dleyna-server:
* 3 issues fixed
* 2 left in "for-next" label
https://github.com/01org/dleyna-server/pull/131
- this is the same object path improvement as dleyna-renderer/pull/132 --
shouldn't block in my opinion.
https://github.com/01org/dleyna-server/issues/133
- Crash if device does not provide the services we expect. I'm
looking at this now.
Would be good to get fixed.
Just as reminder: there are more issues, this list was just for the
things I figured we might fix now-ish.
Jussi
8:30 p.m.
Hi,
On Fri, Jul 11, 2014 at 10:36 AM, Jussi Kukkonen <jussi.kukkonen(a)intel.com>
wrote:
Just as reminder: there are more issues, this list was just for the
things I figured we might fix now-ish.
Great work!
Hope this is not too late for you bug squashing; I've seen an issue in the
way openembedded does off tree build and dleyna-server (0.4.0)
I end up with this build failure:
| oe-linux-gcc
--sysroot=/my/path/openembedded-core/build/tmp-eglibc/sysroots/output
-DHAVE_CONFIG_H -I.
-I/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server
-I..
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-pthread
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-pthread
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/dleyna-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/gupnp-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/gssdp-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/libsoup-2.4
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/libxml2
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/uuid
-I../libdleyna/server -include config.h -O2 -pipe -g
-feliminate-unused-debug-types -Wno-format-extra-args -c -o daemon.o
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server/daemon.c
|
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server/daemon.c:28:51:
fatal error: libdleyna/server/control-point-server.h: No such file or
directory
| #include <libdleyna/server/control-point-server.h>
| ^
| compilation terminated.
| make[2]: *** [daemon.o] Error 1
| make[2]: Leaving directory
`/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/build/server'
To me it seems like the include paths are relative current dir
(-I../libdleyna/server) but as one can see OE build to a separate directory
where the sources are not available
(/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/build/server,
while sources are in
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/),
so -I ../libdleyna/server wont help.
--Richard
9:28 p.m.
On 11 July 2014 13:30, Richard Röjfors <richard.rojfors(a)gmail.com> wrote:
Hope this is not too late for you bug squashing;
Not at all.
I've seen an issue in the
way openembedded does off tree build and dleyna-server (0.4.0)
I end up with this build failure:
| oe-linux-gcc
--sysroot=/my/path/openembedded-core/build/tmp-eglibc/sysroots/output
-DHAVE_CONFIG_H -I.
-I/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server
-I..
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-pthread
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-pthread
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/dleyna-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/gupnp-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/gssdp-1.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/libsoup-2.4
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/libxml2
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/glib-2.0
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/lib/glib-2.0/include
-I/my/path/openembedded-core/build/tmp-eglibc/sysroots/output/usr/include/uuid
-I../libdleyna/server -include config.h -O2 -pipe -g
-feliminate-unused-debug-types -Wno-format-extra-args -c -o daemon.o
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server/daemon.c
|
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/server/daemon.c:28:51:
fatal error: libdleyna/server/control-point-server.h: No such file or
directory
| #include <libdleyna/server/control-point-server.h>
| ^
| compilation terminated.
| make[2]: *** [daemon.o] Error 1
| make[2]: Leaving directory
`/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/build/server'
To me it seems like the include paths are relative current dir
(-I../libdleyna/server) but as one can see OE build to a separate directory
where the sources are not available
(/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/build/server,
while sources are in
/my/path/openembedded-core/build/tmp-eglibc/work/my-arch-oe-linux/dleyna-server/0.4.0-r0/git/),
so -I ../libdleyna/server wont help.
I don't normally test out-of-source building but maybe I should...
I'll take a look at it. Could you file an issue on
https://github.com/01org/dleyna-server/issues/new ?
Thanks,
Jussi
1:25 a.m.
On Fri, Jul 11, 2014 at 1:28 PM, Jussi Kukkonen <jussi.kukkonen(a)intel.com>
wrote:
On 11 July 2014 13:30, Richard Röjfors
<richard.rojfors(a)gmail.com> wrote:
>
> Hope this is not too late for you bug squashing;
Not at all.
Great!
I don't normally test out-of-source building but maybe I should...
I'll take a look at it. Could you file an issue on
https://github.com/01org/dleyna-server/issues/new ?
https://github.com/01org/dleyna-server/issues/143
--Richard
2991
days inactive
2999
days old
4 comments
2 participants
participants (2)
-
Jussi Kukkonen -
Richard Röjfors