Re: ELL double free during debug exit cleanup

For what it's worth: I created an x86_64 openSUSE tumbleweed VM, and GIT repos of the master tip of both ELL and BLUEZ. This appears to build and run correctly using that configuration. The *reported* failure is using the BLUEZ tarball of 5.52, and sure enough if I do the *exact instructions* in the bug report: I can reproduce the problem on openSUSE only (it fails much earlier, in unrelated areas if I try this on Fedora-30). A working patch to solve this problem looks like this (using l_* for new global symbols): diff --git a/ell/log.c b/ell/log.c index f3f4b0c..a73aac1 100644 --- a/ell/log.c +++ b/ell/log.c @@ -441,7 +441,7 @@ LIB_EXPORT void l_debug_disable(void) debug_pattern = NULL; } -__attribute__((constructor)) static void register_debug_section() +__attribute__((constructor)) void l_register_debug_section() { extern struct l_debug_desc __start___ell_debug[]; extern struct l_debug_desc __stop___ell_debug[]; @@ -449,7 +449,7 @@ __attribute__((constructor)) static void register_debug_section() l_debug_add_section(__start___ell_debug, __stop___ell_debug); } -__attribute__((destructor(65535))) static void free_debug_sections() +__attribute__((destructor(65535))) void l_free_debug_sections() { l_queue_destroy(debug_sections, l_free); } diff --git a/ell/log.h b/ell/log.h index 19bf10b..04b913a 100644 --- a/ell/log.h +++ b/ell/log.h @@ -72,6 +72,8 @@ struct l_debug_desc { __func__ , ##__VA_ARGS__); \ } while (0) +void l_register_debug_section(void); +void l_free_debug_sections(void); void l_debug_enable_full(const char *pattern, struct l_debug_desc *start, struct l_debug_desc *stop); On Tue, 2019-11-05 at 16:22 +0000, Gix, Brian wrote: