Hi Denis,

On Tue, Mar 21, 2017 at 1:42 PM, Denis Kenzior <denkenz@gmail.com> wrote:
On 03/21/2017 02:57 PM, Ossama Othman wrote:
---
 Makefile.am             |  3 ++
 unit/test-genl-family.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++++

Do you want to add this test to unit/test-genl instead?  That test is a no-op at this point anyway.

Okay, that's fine with me.
 
+static void do_debug(const char *str, void *user_data)
+{
+       const char *prefix = user_data;
+
+       l_info("%s%s", prefix, str);
+}
+

I know test-genl does this, but...  generally our unit tests don't print anything.  Do you really need this?

Not at all.  I was just trying to be consistent with test-genl.

+       return vanished_called ? 0 : -1;

This is probably okay, but it might be better to use asserts, especially if more tests are added to this unit file in the future.

Okay, I'll go back to returning 0 and rely on an assert() instead.

Thanks Denis!
-Ossama