Re: [PATCH 2/6] tls: Convert encrypt and verify to l_key crypto

Hi Mat, Just a minor comment, On 5 August 2016 at 22:53, Mat Martineau <mathew.j.martineau(a)linux.intel.com&gt; wrote: > diff --git a/ell/tls.c b/ell/tls.c > index 18e5fae..627b57d 100644 > @@ -1029,23 +1022,18 @@ static bool tls_rsa_verify(struct l_tls *tls, const uint8_t *in, size_t len, > return false; > } > > - rsa_client_pubkey = l_asymmetric_cipher_new(L_CIPHER_RSA_PKCS1_V1_5, > - tls->peer_pubkey, > - tls->peer_pubkey_length, > - true); > - if (!rsa_client_pubkey) { > + if (!l_key_get_info(tls->peer_pubkey, L_CIPHER_RSA_PKCS1_V1_5, > + L_CHECKSUM_NONE, &key_size, > + &is_public)) { > tls_disconnect(tls, TLS_ALERT_INTERNAL_ERROR, 0); > - > - return false; > } It looks like this return should stay.