Re: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move assignment out of conditional

Actually, commit message looks malformatted. Signed-off-by line is not the last line. Not sure if that's a problem for Greg or not. On 07/13/2015 07:50 AM, Patrick Farrell wrote: > Looks good, thanks! > ________________________________________ > From: HPDD-discuss [hpdd-discuss-bounces(a)lists.01.org] on behalf of > Perry Hooker [perry.hooker(a)gmail.com] > Sent: Sunday, July 12, 2015 9:22 PM > To: oleg.drokin(a)intel.com; andreas.dilger(a)intel.com; > gregkh(a)linuxfoundation.org; devel(a)driverdev.osuosl.org; > HPDD-discuss(a)lists.01.org > Cc: Perry Hooker > Subject: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move assignment > out of conditional > > Found by checkpatch.pl > > Signed-off-by: Perry Hooker <perry.hooker(a)gmail.com&gt; > > Please enter the commit message for your changes. Lines starting > --- > .../staging/lustre/include/linux/libcfs/libcfs_fail.h | 18 > ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h > b/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h > index eea55d9..aa69c6a 100644 > --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h > +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h > @@ -79,14 +79,16 @@ static inline int cfs_fail_check_set(__u32 id, __u32 > value, > { > int ret = 0; > > - if (unlikely(CFS_FAIL_PRECHECK(id) && > - (ret = __cfs_fail_check_set(id, value, set)))) { > - if (quiet) { > - CDEBUG(D_INFO, "*** cfs_fail_loc=%x, val=%u***\n", > - id, value); > - } else { > - LCONSOLE_INFO("*** cfs_fail_loc=%x, val=%u***\n", > - id, value); > + if (unlikely(CFS_FAIL_PRECHECK(id))) { > + ret = __cfs_fail_check_set(id, value, set); > + if (ret) { > + if (quiet) { > + CDEBUG(D_INFO, "*** cfs_fail_loc=%x, > val=%u***\n", > + id, value); > + } else { > + LCONSOLE_INFO("*** cfs_fail_loc=%x, > val=%u***\n", > + id, value); > + } > } > } > > -- > 2.1.4 > > _______________________________________________ > HPDD-discuss mailing list > HPDD-discuss(a)lists.01.org > https://lists.01.org/mailman/listinfo/hpdd-discuss > _______________________________________________ > HPDD-discuss mailing list > HPDD-discuss(a)lists.01.org > https://lists.01.org/mailman/listinfo/hpdd-discuss >