This patch does a lot of stuff all at once and it is hard to review.
It
could easily be broken into patches which are easy to review.
I have more very large patches. With breaking them up that means you are
going to see hundreds of patches coming from me.
Ok in this next section we move functions around and rename them but
also introduce some bad changes in the new function.
Thanks for pointing out these bugs. We are still carrying these bugs in the
OpenSFS branch. Once you approve these changes I will sync up lib-socket.c
in the OpenSFS branch.
P.S
Does the 3rd patch look okay to you?