On Thu, 6 Aug 2015, Shraddha Barke wrote:
This patch fixes "externs should be avoided in .c files"
warning as reported by checkpatch
Signed-off-by: Shraddha Barke <shraddha.6596(a)gmail.com>
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c
b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 20a7cd9..71651cb6 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -502,13 +502,13 @@ int obd_init_checks(void)
return ret;
}
-extern int class_procfs_init(void);
-extern int class_procfs_clean(void);
+static int class_procfs_init(void);
+static int class_procfs_clean(void);
static int __init init_obdclass(void)
{
- int i, err;
- int lustre_register_fs(void);
+ static int i, err;
This doesn't look right at all.
julia
+ static int lustre_register_fs(void);
for (i = CAPA_SITE_CLIENT; i < CAPA_SITE_MAX; i++)
INIT_LIST_HEAD(&capa_list[i]);
@@ -637,8 +637,8 @@ EXPORT_SYMBOL(obd_pages_max);
* ifdef to the end of the file to cover module and versioning goo.*/
static void cleanup_obdclass(void)
{
- int i;
- int lustre_unregister_fs(void);
+ static int i;
+ static int lustre_unregister_fs(void);
__u64 memory_leaked, pages_leaked;
__u64 memory_max, pages_max;
--
2.1.0