Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing
Sudip, Dan, thanks for your feedback. I'll see what I can do to clean up
the trimmings in my next iteration (and add more files' worth of cleanup as
well).
While editing these 4 files, I found two more (non-white space) clean ups
needed. Should I build a patch series, with those fixes in it, or email
those as a separate patch?
On Wednesday, May 6, 2015, Dan Carpenter <dan.carpenter(a)oracle.com> wrote:
On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote:
> Clean up spacing in some variable declarations, to be more consistent.
>
> It's small, but I need to start somewhere. Please let me know if I'm not
> adhering to proper procedure for trivial cleanups.
Don't put these "aside" comments in the permanent kernel changelog.
Otherwise I like this patch, lining up the variables can look ok in
struct definitions in headers but in functions we can never keep it
consistent so it just looks whacky.
regards,
dan carpenter
--
--
Mike Shuey
Attachments:
- attachment.html (text/html — 1.3 KB)