Re: [HPDD-discuss] [PATCH 2/2] Staging: lustre: lnet: lnet: router.c: fix useless returns and elses
On Thu, Mar 19, 2015 at 01:20:02PM +0000, Patrick Farrell wrote:
Hm. I like that else - it is not strictly necessary, but it adds
readability by making clear that the error is a direct consequence of
failing that if test. Perhaps I've missed a convention that says we
should remove it, but if not, I prefer it as is. The other changes
look good to me.
It's an additional indentation that isn't needed, and the code is now
more readable.
Also, yes, it's a convention to make this type of change, look at the
result of the checkpatch.pl tool, it highlighed this problem in the
file.
thanks,
greg k-h