Re: [HPDD-discuss] [PATCH] staging: lustre: remove unused variable
Hello!
On May 11, 2015, at 7:43 AM, Sudip Mukherjee wrote:
On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
>> - if (set->set_pga) {
>> - int len = set->set_oabufs * sizeof(*set->set_pga);
>> + if (set->set_pga)
>> OBD_FREE_LARGE(set->set_pga, len);
> ^^^
> It's used right here?
oops.. sorry .. but why i didnot get a build failure after this?
ok, got it ...
#define OBD_FREE_LARGE(ptr, size) \
do { \
kvfree(ptr); \
} while (0)
the variable is actually not used. I will make a v2 and send
tomorrow. today is a day of silly mistakes :(
It's probably best to wait for a bit at this point.
Julia is going to send in a bunch of patches actually getting rid of
those macros.
And then whatever stuff surfaces would be easier to see.
Thanks!
Bye,
Oleg