Re: [HPDD-discuss] [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c
>On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
> toobig = 1;
> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> - CWARN("Too many interfaces: only enumerating first %d\n",
> - nalloc);
> + CWARN("Too many interfaces: only enumerating "
> + "first %d\n", nalloc);
> }
Don't split string literals, it makes them hard to grep for.
Will fix. The CWARN will go over 80 characters but from the recent emails that is more
acceptable.
If this is the only problem then this patch set it ready. I have more patch series that
are dependent
on this first one. Should I push the other patch series with a note that it is dependent
on the tcpip
cleanup or wait until it is merged? Also how does one find out when the patch has been
merged?