Re: [HPDD-discuss] [PATCH 2/3] staging: lustre: Add blank line after variable declaration
On Wed, 2015-08-12 at 10:30 +0530, Sudip Mukherjee wrote:
On Tue, Aug 11, 2015 at 09:32:30PM +0800, Swee Hua Law wrote:
> Add blank line after variable declaration
[]
> diff --git a/drivers/staging/lustre/lustre/llite/lloop.c
b/drivers/staging/lustre/lustre/llite/lloop.c
[]
> @@ -372,9 +372,11 @@ err:
> static inline void loop_handle_bio(struct lloop_device *lo, struct bio *bio)
> {
> int ret;
> +
> ret = do_bio_lustrebacked(lo, bio);
> while (bio) {
> struct bio *tmp = bio->bi_next;
> +
> bio->bi_next = NULL;
> bio_endio(bio);
This patch will not apply. I am not sure how your tree got
bio_endio(bio) but in the staging tree this line is bio_endio(bio, ret);
And besides that, why do only this file/location?
There are several hundred possible in lustre.
Using:
$ git ls-files -- "drivers/staging/lustre/*.[ch]" | \
xargs ./scripts/checkpatch.pl -f --fix-inplace --types=line_spacing
would fix just about all of them.
$ git diff --shortstat drivers/staging/lustre/
172 files changed, 267 insertions(+), 316 deletions(-)