Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive
On Sat, Aug 15, 2015 at 11:13:39AM +0300, Ioan-Adrian Ratiu wrote:
On Fri, 14 Aug 2015 18:50:24 -0700
Greg KH <gregkh(a)linuxfoundation.org> wrote:
> On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > "pack_generic.c:642:5: warning: no previous prototype for ..."
>
> It does? What version of gcc give you that, I don't see that here.
>
Yes, but it's a non-default warning (-Wmissing-prototypes)
Then you should say that, otherwise you have us worrying something is
really wrong with our build/compiler versions...
I've taken this patch, but next time please be more specific.
thanks,
greg k-h