[HPDD-discuss] llite/xattr.c:181: poor error checking ?

Hello there, lustre/llite/xattr.c:181]: (style) Checking if unsigned variable 'size' is less than zero. Source code is             size = lustre_posix_acl_xattr_filter(                         (posix_acl_xattr_header *)value,                         size, &new_value);             if (unlikely(size < 0))                 return size; but static int ll_setxattr_common(struct inode *inode, const char *name,                const void *value, size_t size,                int flags, __u64 valid) and extern int lustre_posix_acl_xattr_filter(posix_acl_xattr_header *header, size_t size,                   posix_acl_xattr_header **out); Suggest sanity check return value *before* assignment into size. Regards David Binderman