On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote:
This patch fixes the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
+#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
Signed-off-by: Vasiliy Korchagin <vasiliy.korchagin(a)gmail.com>
---
drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c
b/drivers/staging/lustre/lustre/obdclass/uuid.c
index ff0a01b..8d00882 100644
--- a/drivers/staging/lustre/lustre/obdclass/uuid.c
+++ b/drivers/staging/lustre/lustre/obdclass/uuid.c
@@ -55,7 +55,7 @@ static inline __u32 consume(int nob, __u8 **ptr)
return value;
}
-#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
+#define CONSUME(val, ptr) ((val) = consume(sizeof(val), (ptr)))
CONSUME is used exactly once.
It'd be likely be simpler to remove it and expand it
in-place instead.
The static inline __u32 consume() function is also used
once and might as well be expanded in-place too.