3:05 a.m.
ifconfig isn't available by default in several linux distros
so instead use 'ip' which seems to be much more widespread.
---
autotests/testScan/remove_iface_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autotests/testScan/remove_iface_test.py
b/autotests/testScan/remove_iface_test.py
index af36c1e8..4f9eef93 100644
--- a/autotests/testScan/remove_iface_test.py
+++ b/autotests/testScan/remove_iface_test.py
@@ -18,7 +18,7 @@ class Test(unittest.TestCase):
device.autoconnect = True
device.scan(wait=False)
- os.system('ifconfig %s down' % device.name)
+ os.system('ip link set dev %s down' % device.name)
@classmethod
def setUpClass(cls):
--
2.34.1
2:59 a.m.
Hi James,
On 6/3/22 12:05, James Prestwood wrote:
ifconfig isn't available by default in several linux distros
so instead use 'ip' which seems to be much more widespread.
---
autotests/testScan/remove_iface_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Both applied, thanks.
Regards,
-Denis
3:05 a.m.
New subject: [PATCH 2/2] test-runner: only remove /tmp files if they exist
This bit of code was throwing exceptions if a test cleaned up files that
test-runner was expecting to clean up. Specifically testHotspot swaps out
main.conf and PSK files many times. This led to the exception being thrown,
caught, and ignored but further on test-runner would print:
"File _X_ not cleaned up!"
Now the files will be checked if they exist before trying to remove it.
---
tools/run-tests | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/run-tests b/tools/run-tests
index f65daf67..56f865e0 100755
--- a/tools/run-tests
+++ b/tools/run-tests
@@ -861,7 +861,7 @@ def post_test(ctx, to_copy):
for f in to_copy:
if os.path.isdir('/tmp/' + f):
shutil.rmtree('/tmp/' + f)
- else:
+ elif os.path.exists('/tmp/' + f):
os.remove('/tmp/' + f)
Process(['ip', 'link', 'set', 'lo',
'down']).wait()
--
2.34.1
107
days inactive
107
days old
2 comments
2 participants
participants (2)
-
Denis Kenzior -
James Prestwood