Hi Andrew,
On 9/29/21 5:22 PM, Andrew Zaborowski wrote:
On NETDEV_EVENT_DISCONNECT_BY_* events during netconfig, we'd
forget to
call netconfig_reset() before trying a new netconfig_configure()
resulting in the "netconfig: Failed to start DHCPv4 client for interface
%u" warning and a L_WARN_ON. Add the missing call.
So you're still not including the useful information that would be very useful
that was mentioned in the earlier thread...
---
src/station.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/station.c b/src/station.c
index 934815f2..1c073fc1 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2810,6 +2810,9 @@ static void station_disconnect_event(struct station *station, void
*event_data)
switch (station->state) {
case STATION_STATE_CONNECTING:
case STATION_STATE_CONNECTING_AUTO:
+ if (station->netconfig)
+ netconfig_reset(station->netconfig);
+
NAK. This is still not addressing the underlying bug. It should not go via the
station_connect_cb path at all. Perhaps you need to add a new
CONNECTED_NETCONFIG state instead.
station_connect_cb(station->netdev,
NETDEV_RESULT_HANDSHAKE_FAILED,
event_data, station);
Regards,
-Denis