Hi James,
On 10/16/19 6:21 PM, James Prestwood wrote:
---
src/hotspot.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/hotspot.c b/src/hotspot.c
index ad8af37c..e3a7a07a 100644
--- a/src/hotspot.c
+++ b/src/hotspot.c
@@ -342,7 +342,11 @@ static struct hs20_config *hs20_config_new(struct l_settings
*settings,
config = l_new(struct hs20_config, 1);
if (hessid_str) {
- util_string_to_address(hessid_str, config->hessid);
+ if (!util_string_to_address(hessid_str, config->hessid)) {
+ l_error("Invalid HESSID in settings");
+ goto free_values;
+ }
+
This still looks wrong since you're allocating config above
l_free(hessid_str);
}
Regards,
-Denis