8:08 a.m.
This got changed to use which, but not updated to remove the
list argument.
---
tools/run-tests | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/run-tests b/tools/run-tests
index 78665de1..7e61b6b1 100755
--- a/tools/run-tests
+++ b/tools/run-tests
@@ -461,7 +461,7 @@ class TestContext(Namespace):
os.environ['IWD_SIM_KEYS'] = sim_keys
return
- if not shutil.which('ofonod') or not shutil.which(['phonesim']):
+ if not shutil.which('ofonod') or not shutil.which('phonesim'):
print("Ofono or Phonesim not found, skipping test")
return
--
2.34.1
8:08 a.m.
New subject: [PATCH 2/2] test-runner: resolve --kernel absolute path
This only posed a problem oddly if the kernel binary was in the same
directory as test-runner. Resolving the absolute path with the
argument parser resolves the issue.
---
tools/runner.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/runner.py b/tools/runner.py
index 1f087d6c..1cb01d29 100644
--- a/tools/runner.py
+++ b/tools/runner.py
@@ -183,7 +183,7 @@ class RunnerArgParse(RunnerCoreArgParse):
default=None)
self.add_argument('--kernel', '-k',
metavar='<kernel>',
- type=str,
+ type=os.path.abspath,
help='Path to kernel/uml image',
dest='kernel',
default=None)
--
2.34.1
164
days inactive
165
days old
2 comments
2 participants
participants (2)
-
Denis Kenzior -
James Prestwood