12:34 a.m.
Hi Emmanuel,
On 4/5/22 06:19, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
If a user connection fails on a freshly scanned psk or open hidden
network,
during passphrase request or after, it shall be removed from the network list.
Otherwise, it would be possible to directly connect to that known
network, which will appear as not hidden.
Commit 06ca8e20a9b0 ("station: Hide forgotten hidden networks")
---
src/network.c | 11 +++++++++++
src/station.c | 2 ++
2 files changed, 13 insertions(+)
Applied, thanks.
Regards,
-Denis
12:49 a.m.
New subject: [PATCH v3] network: Hide hidden networks on connection error
Dear Denis, dear Emmanuel,
Am 05.04.22 um 16:34 schrieb Denis Kenzior:
Hi Emmanuel,
On 4/5/22 06:19, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> If a user connection fails on a freshly scanned psk or open hidden network,
> during passphrase request or after, it shall be removed from the network list.
> Otherwise, it would be possible to directly connect to that known
> network, which will appear as not hidden.
>
> Commit 06ca8e20a9b0 ("station: Hide forgotten hidden networks")
What does this line mean?
Kind regards,
Paul
>> ---
>> src/network.c | 11 +++++++++++
>> src/station.c | 2 ++
>> 2 files changed, 13 insertions(+)
>>
>
> Applied, thanks.
>
> Regards,
> -Denis
12:53 a.m.
New subject: [PATCH v3] network: Hide hidden networks on connection error
Hi Paul,
>> Commit 06ca8e20a9b0 ("station: Hide forgotten hidden
networks")
What does this line mean?
Emmanuel was referring to the commit that added 'station_hide_network' API here.
It wasn't really relevant to this commit and I took this line out when pushing
the commit upstream. I should have (and failed to) mentioned this in my earlier
reply.
Regards,
-Denis
1:13 a.m.
New subject: [PATCH v3] network: Hide hidden networks on connection error
Emmanuel was referring to the commit that added
'station_hide_network' API here.
It wasn't really relevant to this commit and I took this line out when pushing
the commit upstream. I should have (and failed to) mentioned this in my earlier
reply.
Exactly. As the former implementation was incomplete but not wrong, I
didn't want to
specify it as a "Fix" of the the related commit, but only refer it as
"Commit".
Best Regards,
Emmanuel
12:53 a.m.
New subject: [PATCH v3] network: Hide hidden networks on connection error
[Resend with fixed email address, botched by me]
Am 05.04.22 um 16:49 schrieb Paul Menzel:
> Dear Denis, dear Emmanuel,
>
>
> Am 05.04.22 um 16:34 schrieb Denis Kenzior:
>> Hi Emmanuel,
>>
>> On 4/5/22 06:19, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
>>> If a user connection fails on a freshly scanned psk or open hidden
>>> network,
>>> during passphrase request or after, it shall be removed from the
>>> network list.
>>> Otherwise, it would be possible to directly connect to that known
>>> network, which will appear as not hidden.
>>>
>>> Commit 06ca8e20a9b0 ("station: Hide forgotten hidden networks")
>
> What does this line mean?
>
>
> Kind regards,
>
> Paul
>
>
>>> ---
>>> src/network.c | 11 +++++++++++
>>> src/station.c | 2 ++
>>> 2 files changed, 13 insertions(+)
>>>
>>
>> Applied, thanks.
>>
>> Regards,
>> -Denis
166
days inactive
166
days old
5 comments
3 participants
participants (3)
-
Denis Kenzior -
Paul Menzel -
VAUTRIN Emmanuel (Canal Plus Prestataire)