Hi,
On Mon, 2022-03-14 at 21:49 +0100, Vladimír Dudr wrote:
Hello,
I dared to fix displaying of grey color for iwctl. I tested in Kitty,
Xterm, Termite, foot and Alarcitty.
\e[1;30m is bold black, often, but not always displayed bright black
or
bold bright black. In case it is displayed as real black it is
invisible. \e[1;90m is explicit bold bright black.
\e[37m is white, therefore it is not suitable to be
labeled as GREY, which is \e[90m. Anyway, this define is used only in
header, so matching the color to BOLDGRAY seems intuitive.
This definitely makes the table headers show up which I kinda forgot
existed since they were nearly black. Thanks.
My only suggestion would be to change the commit description a bit to
look more like a git commit, something like:
"Fixed displaying of grey color for iwctl...."
The rest seems fine to me.
Thanks,
James
Cheers,
Vladimír
---
client/display.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/display.h b/client/display.h
index b5df944a..7747c6a0 100644
--- a/client/display.h
+++ b/client/display.h
@@ -23,8 +23,8 @@
struct command;
struct command_family;
-#define COLOR_BOLDGRAY "\x1B[1;30m"
-#define COLOR_GRAY "\x1b[37m"
+#define COLOR_BOLDGRAY "\x1B[1;90m"
+#define COLOR_GRAY "\x1b[90m"
#define COLOR_GREEN "\x1b[32m"
#define COLOR_RED "\x1B[0;91m"
#define COLOR_BLUE "\x1B[94m"
_______________________________________________
iwd mailing list -- iwd(a)lists.01.org
To unsubscribe send an email to iwd-leave(a)lists.01.org