drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is uninitialized when used here
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8119c4332d253660e0a6b8748fe0749961cfbc97
commit: 868fd970e187d39c586565c875837e530c6f7e1b staging: wfx: improve robustness of wfx_get_hw_rate()
date: 7 days ago
config: powerpc64-randconfig-r001-20201016 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5fbab4025eb57b12f2842ab188ff07a110708e1d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 868fd970e187d39c586565c875837e530c6f7e1b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is uninitialized when used here [-Wuninitialized]
if (rate->idx >= band->n_bitrates) {
^~~~
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/staging/wfx/data_tx.c:23:39: note: initialize the variable 'band' to silence this warning
struct ieee80211_supported_band *band;
^
= NULL
1 warning generated.
vim +/band +34 drivers/staging/wfx/data_tx.c
19
20 static int wfx_get_hw_rate(struct wfx_dev *wdev,
21 const struct ieee80211_tx_rate *rate)
22 {
23 struct ieee80211_supported_band *band;
24
25 if (rate->idx < 0)
26 return -1;
27 if (rate->flags & IEEE80211_TX_RC_MCS) {
28 if (rate->idx > 7) {
29 WARN(1, "wrong rate->idx value: %d", rate->idx);
30 return -1;
31 }
32 return rate->idx + 14;
33 }
> 34 if (rate->idx >= band->n_bitrates) {
35 WARN(1, "wrong rate->idx value: %d", rate->idx);
36 return -1;
37 }
38 // WFx only support 2GHz, else band information should be retrieved
39 // from ieee80211_tx_info
40 band = wdev->hw->wiphy->bands[NL80211_BAND_2GHZ];
41 return band->bitrates[rate->idx].hw_value;
42 }
43
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[jirislaby:devel 15/52] drivers/tty/vt/keyboard.c:2066:3: warning: this statement may fall through
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head: 33533f1d99b53918d785901267d045f2964bfe5c
commit: a959de21141d5d2600cdfda7c4df5fa816fb6d38 [15/52] vt: keyboard, extract and simplify vt_kdskbsent
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commi...
git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
git fetch --no-tags jirislaby devel
git checkout a959de21141d5d2600cdfda7c4df5fa816fb6d38
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl':
drivers/tty/vt/keyboard.c:2063:3: error: 'ret' undeclared (first use in this function); did you mean 'rep'?
2063 | ret = copy_to_user(user_kdgkb->kb_string, func_copy, len + 1) ?
| ^~~
| rep
drivers/tty/vt/keyboard.c:2063:3: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/tty/vt/keyboard.c:2066:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
2066 | kfree(func_copy);
| ^~~~~~~~~~~~~~~~
drivers/tty/vt/keyboard.c:2070:2: note: here
2070 | case KDSKBSENT: {
| ^~~~
vim +2066 drivers/tty/vt/keyboard.c
a959de21141d5d2 Jiri Slaby 2020-08-18 2035
079c9534a96da9a Alan Cox 2012-02-28 2036 int vt_do_kdgkb_ioctl(int cmd, struct kbsentry __user *user_kdgkb, int perm)
079c9534a96da9a Alan Cox 2012-02-28 2037 {
76f8a0386a60170 Jiri Slaby 2020-08-18 2038 unsigned char kb_func;
a959de21141d5d2 Jiri Slaby 2020-08-18 2039 unsigned long flags;
079c9534a96da9a Alan Cox 2012-02-28 2040
079c9534a96da9a Alan Cox 2012-02-28 2041 if (!capable(CAP_SYS_TTY_CONFIG))
079c9534a96da9a Alan Cox 2012-02-28 2042 perm = 0;
079c9534a96da9a Alan Cox 2012-02-28 2043
76f8a0386a60170 Jiri Slaby 2020-08-18 2044 if (get_user(kb_func, &user_kdgkb->kb_func))
0d918baecc9263e Jiri Slaby 2020-08-14 2045 return -EFAULT;
079c9534a96da9a Alan Cox 2012-02-28 2046
76f8a0386a60170 Jiri Slaby 2020-08-18 2047 kb_func = array_index_nospec(kb_func, MAX_NR_FUNC);
079c9534a96da9a Alan Cox 2012-02-28 2048
079c9534a96da9a Alan Cox 2012-02-28 2049 switch (cmd) {
8092d18a17ab730 Jiri Slaby 2020-08-14 2050 case KDGKBSENT: {
8092d18a17ab730 Jiri Slaby 2020-08-14 2051 /* size should have been a struct member */
54b82ccf041264d Jiri Slaby 2020-09-01 2052 char *func_copy;
54b82ccf041264d Jiri Slaby 2020-09-01 2053 ssize_t len = sizeof(user_kdgkb->kb_string);
0d918baecc9263e Jiri Slaby 2020-08-14 2054
54b82ccf041264d Jiri Slaby 2020-09-01 2055 func_copy = kmalloc(len, GFP_KERNEL);
54b82ccf041264d Jiri Slaby 2020-09-01 2056 if (!func_copy)
54b82ccf041264d Jiri Slaby 2020-09-01 2057 return -ENOMEM;
0d918baecc9263e Jiri Slaby 2020-08-14 2058
54b82ccf041264d Jiri Slaby 2020-09-01 2059 spin_lock_irqsave(&func_buf_lock, flags);
76f8a0386a60170 Jiri Slaby 2020-08-18 2060 len = strlcpy(func_copy, func_table[kb_func] ? : "", len);
54b82ccf041264d Jiri Slaby 2020-09-01 2061 spin_unlock_irqrestore(&func_buf_lock, flags);
54b82ccf041264d Jiri Slaby 2020-09-01 2062
54b82ccf041264d Jiri Slaby 2020-09-01 2063 ret = copy_to_user(user_kdgkb->kb_string, func_copy, len + 1) ?
54b82ccf041264d Jiri Slaby 2020-09-01 2064 -EFAULT : 0;
54b82ccf041264d Jiri Slaby 2020-09-01 2065
54b82ccf041264d Jiri Slaby 2020-09-01 @2066 kfree(func_copy);
54b82ccf041264d Jiri Slaby 2020-09-01 2067
54b82ccf041264d Jiri Slaby 2020-09-01 2068 return ret;
8092d18a17ab730 Jiri Slaby 2020-08-14 2069 }
a959de21141d5d2 Jiri Slaby 2020-08-18 2070 case KDSKBSENT: {
a959de21141d5d2 Jiri Slaby 2020-08-18 2071 char *kbs;
a959de21141d5d2 Jiri Slaby 2020-08-18 2072
0d918baecc9263e Jiri Slaby 2020-08-14 2073 if (!perm)
0d918baecc9263e Jiri Slaby 2020-08-14 2074 return -EPERM;
0d918baecc9263e Jiri Slaby 2020-08-14 2075
0d918baecc9263e Jiri Slaby 2020-08-14 2076 kbs = strndup_user(user_kdgkb->kb_string,
0d918baecc9263e Jiri Slaby 2020-08-14 2077 sizeof(user_kdgkb->kb_string));
0d918baecc9263e Jiri Slaby 2020-08-14 2078 if (IS_ERR(kbs))
0d918baecc9263e Jiri Slaby 2020-08-14 2079 return PTR_ERR(kbs);
079c9534a96da9a Alan Cox 2012-02-28 2080
46ca3f735f345c9 Sergei Trofimovich 2019-03-10 2081 spin_lock_irqsave(&func_buf_lock, flags);
a959de21141d5d2 Jiri Slaby 2020-08-18 2082 kbs = vt_kdskbsent(kbs, kb_func);
46ca3f735f345c9 Sergei Trofimovich 2019-03-10 2083 spin_unlock_irqrestore(&func_buf_lock, flags);
a959de21141d5d2 Jiri Slaby 2020-08-18 2084
079c9534a96da9a Alan Cox 2012-02-28 2085 kfree(kbs);
a959de21141d5d2 Jiri Slaby 2020-08-18 2086
a959de21141d5d2 Jiri Slaby 2020-08-18 2087 return 0;
a959de21141d5d2 Jiri Slaby 2020-08-18 2088 }
a959de21141d5d2 Jiri Slaby 2020-08-18 2089 }
a959de21141d5d2 Jiri Slaby 2020-08-18 2090
a959de21141d5d2 Jiri Slaby 2020-08-18 2091 return 0;
079c9534a96da9a Alan Cox 2012-02-28 2092 }
079c9534a96da9a Alan Cox 2012-02-28 2093
:::::: The code at line 2066 was first introduced by commit
:::::: 54b82ccf041264dfd324f62719a430483a823028 vt: keyboard, extend func_buf_lock to readers
:::::: TO: Jiri Slaby <jslaby(a)suse.cz>
:::::: CC: Jiri Slaby <jslaby(a)suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH net] net: dsa: point out the tail taggers
by Jakub Kicinski
On Sat, 17 Oct 2020 00:33:02 +0300 Vladimir Oltean wrote:
> On Sat, Oct 17, 2020 at 12:16:28AM +0300, Vladimir Oltean wrote:
> > On Fri, Oct 16, 2020 at 11:03:18PM +0200, Andrew Lunn wrote:
> > > 2ecbc1f684482b4ed52447a39903bd9b0f222898 does not have net-next, as
> > > far as i see,
> >
> > Not sure what you mean by that.
>
> Ah, I do understand what you mean now. In git, that is what I see as
> well. But in my cgit link, why would tail_tag be there?
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/tree/inclu...
> I think either cgit is plainly dumb at showing the kernel tree at a
> particular commit, or I'm plainly incapable of using it.
The link is bamboozled.
The #n93 needs to be after the ? parameters.
Like this:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/tree/inclu...
1 year, 11 months
[linux-stable-rc:linux-4.14.y 9050/9999] drivers/media/v4l2-core/v4l2-compat-ioctl32.c:621:21: sparse: sparse: incorrect type in initializer (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
head: e1f7d50ae3a3ec342e87a9b1ce6787bfb8b3c08b
commit: 9bee4f9f4460db86c47fe01f9671af6a8951efda [9050/9999] powerpc: Fix duplicate const clang warning in user access code
config: powerpc-randconfig-s031-20201016 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-rc1-2-g368fd9ce-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi...
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.14.y
git checkout 9bee4f9f4460db86c47fe01f9671af6a8951efda
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: got void *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: got void *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: got void *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: sparse: got void *
>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:621:21: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct v4l2_plane [noderef] <asn:1> *[noderef] <asn:1> *__gu_addr @@ got struct v4l2_plane [noderef] <asn:1> ** @@
>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:621:21: sparse: expected struct v4l2_plane [noderef] <asn:1> *[noderef] <asn:1> *__gu_addr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:621:21: sparse: got struct v4l2_plane [noderef] <asn:1> **
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] base @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: got void *[assigned] base
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] base @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: got void *[assigned] base
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] base @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: got void *[assigned] base
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] base @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:693:13: sparse: got void *[assigned] base
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:871:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct v4l2_ext_control [noderef] <asn:1> *kcontrols @@ got struct v4l2_ext_control * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:871:13: sparse: expected struct v4l2_ext_control [noderef] <asn:1> *kcontrols
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:871:13: sparse: got struct v4l2_ext_control *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:957:13: sparse: sparse: cast removes address space '<asn:1>' of expression
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:957:13: sparse: sparse: cast removes address space '<asn:1>' of expression
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:957:13: sparse: sparse: cast removes address space '<asn:1>' of expression
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:957:13: sparse: sparse: cast removes address space '<asn:1>' of expression
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] edid @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: got void *[assigned] edid
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] edid @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: got void *[assigned] edid
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] edid @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: got void *[assigned] edid
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:1> *uptr @@ got void *[assigned] edid @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: expected void [noderef] <asn:1> *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13: sparse: got void *[assigned] edid
vim +621 drivers/media/v4l2-core/v4l2-compat-ioctl32.c
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 582
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 583 static int put_v4l2_buffer32(struct v4l2_buffer __user *kp,
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 584 struct v4l2_buffer32 __user *up)
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 585 {
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 586 u32 type;
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 587 u32 length;
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 588 enum v4l2_memory memory;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 589 struct v4l2_plane32 __user *uplane32;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 590 struct v4l2_plane __user *uplane;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 591 compat_caddr_t p;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 592 int ret;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 593
16c25072560fb3 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Hans Verkuil 2018-02-14 594 if (!access_ok(VERIFY_WRITE, up, sizeof(*up)) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 595 assign_in_user(&up->index, &kp->index) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 596 get_user(type, &kp->type) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 597 put_user(type, &up->type) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 598 assign_in_user(&up->flags, &kp->flags) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 599 get_user(memory, &kp->memory) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 600 put_user(memory, &up->memory))
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 601 return -EFAULT;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 602
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 603 if (assign_in_user(&up->bytesused, &kp->bytesused) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 604 assign_in_user(&up->field, &kp->field) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 605 assign_in_user(&up->timestamp.tv_sec, &kp->timestamp.tv_sec) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 606 assign_in_user(&up->timestamp.tv_usec, &kp->timestamp.tv_usec) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 607 copy_in_user(&up->timecode, &kp->timecode, sizeof(kp->timecode)) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 608 assign_in_user(&up->sequence, &kp->sequence) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 609 assign_in_user(&up->reserved2, &kp->reserved2) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 610 assign_in_user(&up->reserved, &kp->reserved) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 611 get_user(length, &kp->length) ||
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 612 put_user(length, &up->length))
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 613 return -EFAULT;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 614
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 615 if (V4L2_TYPE_IS_MULTIPLANAR(type)) {
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 616 u32 num_planes = length;
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 617
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 618 if (num_planes == 0)
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 619 return 0;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 620
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 @621 if (get_user(uplane, ((__force struct v4l2_plane __user **)&kp->m.planes)))
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 622 return -EFAULT;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 623 if (get_user(p, &up->m.planes))
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 624 return -EFAULT;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 625 uplane32 = compat_ptr(p);
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 626
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 627 while (num_planes--) {
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 628 ret = put_v4l2_plane32(uplane, uplane32, memory);
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 629 if (ret)
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 630 return ret;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 631 ++uplane;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 632 ++uplane32;
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 633 }
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 634 } else {
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 635 switch (memory) {
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 636 case V4L2_MEMORY_MMAP:
3df1197724661c drivers/media/v4l2-core/v4l2-compat-ioctl32.c Hans Verkuil 2018-02-14 637 case V4L2_MEMORY_OVERLAY:
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 638 if (assign_in_user(&up->m.offset, &kp->m.offset))
a113bc787e9b0e drivers/media/video/compat_ioctl32.c Guy Martin 2006-01-11 639 return -EFAULT;
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 640 break;
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 641 case V4L2_MEMORY_USERPTR:
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 642 if (assign_in_user(&up->m.userptr, &kp->m.userptr))
a113bc787e9b0e drivers/media/video/compat_ioctl32.c Guy Martin 2006-01-11 643 return -EFAULT;
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 644 break;
051c7788bcb92f drivers/media/v4l2-core/v4l2-compat-ioctl32.c Sumit Semwal 2012-06-14 645 case V4L2_MEMORY_DMABUF:
ad01b40bb9be09 drivers/media/v4l2-core/v4l2-compat-ioctl32.c Daniel Mentz 2018-02-14 646 if (assign_in_user(&up->m.fd, &kp->m.fd))
051c7788bcb92f drivers/media/v4l2-core/v4l2-compat-ioctl32.c Sumit Semwal 2012-06-14 647 return -EFAULT;
051c7788bcb92f drivers/media/v4l2-core/v4l2-compat-ioctl32.c Sumit Semwal 2012-06-14 648 break;
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 649 }
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 650 }
52a3082fea41ff drivers/media/video/v4l2-compat-ioctl32.c Pawel Osciak 2010-07-29 651
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 652 return 0;
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 653 }
cf664a6458b254 drivers/media/video/compat_ioctl32.c Philippe De Muyter 2006-01-09 654
:::::: The code at line 621 was first introduced by commit
:::::: ad01b40bb9be0987e883655205606c710a8785a5 media: v4l2-compat-ioctl32.c: refactor compat ioctl32 logic
:::::: TO: Daniel Mentz <danielmentz(a)google.com>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH RFC] bus: mhi: core: Enable unique QRTR node ID support
by kernel test robot
Hi Gokul,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linus/master]
[also build test ERROR on v5.9 next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/bus-mhi-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ff9b0d392ea08090cd1780fb196f36dbb586529
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7a9b56e151211022c138dff2099281fa1...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/bus-mhi-core-Enable-unique-QRTR-node-ID-support/20201017-030555
git checkout 7a9b56e151211022c138dff2099281fa12103f00
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/bus/mhi/core/boot.c: In function 'mhi_fw_load_handler':
>> drivers/bus/mhi/core/boot.c:467:9: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
467 | ret = of_property_read_u32(mhi_cntrl->cntrl_dev->of_node,
| ^~~~~~~~~~~~~~~~~~~~
drivers/bus/mhi/core/boot.c:468:30: error: 'instance' undeclared (first use in this function)
468 | "qrtr-instance-id", &instance);
| ^~~~~~~~
drivers/bus/mhi/core/boot.c:468:30: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
vim +/of_property_read_u32 +467 drivers/bus/mhi/core/boot.c
388
389 void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
390 {
391 const struct firmware *firmware = NULL;
392 struct image_info *image_info;
393 struct device *dev = &mhi_cntrl->mhi_dev->dev;
394 const char *fw_name;
395 void *buf;
396 dma_addr_t dma_addr;
397 size_t size;
398 int i, ret;
399
400 if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) {
401 dev_err(dev, "Device MHI is not in valid state\n");
402 return;
403 }
404
405 /* save hardware info from BHI */
406 ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_SERIALNU,
407 &mhi_cntrl->serial_number);
408 if (ret)
409 dev_err(dev, "Could not capture serial number via BHI\n");
410
411 for (i = 0; i < ARRAY_SIZE(mhi_cntrl->oem_pk_hash); i++) {
412 ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_OEMPKHASH(i),
413 &mhi_cntrl->oem_pk_hash[i]);
414 if (ret) {
415 dev_err(dev, "Could not capture OEM PK HASH via BHI\n");
416 break;
417 }
418 }
419
420 /* If device is in pass through, do reset to ready state transition */
421 if (mhi_cntrl->ee == MHI_EE_PTHRU)
422 goto fw_load_ee_pthru;
423
424 fw_name = (mhi_cntrl->ee == MHI_EE_EDL) ?
425 mhi_cntrl->edl_image : mhi_cntrl->fw_image;
426
427 if (!fw_name || (mhi_cntrl->fbc_download && (!mhi_cntrl->sbl_size ||
428 !mhi_cntrl->seg_len))) {
429 dev_err(dev,
430 "No firmware image defined or !sbl_size || !seg_len\n");
431 return;
432 }
433
434 ret = request_firmware(&firmware, fw_name, dev);
435 if (ret) {
436 dev_err(dev, "Error loading firmware: %d\n", ret);
437 return;
438 }
439
440 size = (mhi_cntrl->fbc_download) ? mhi_cntrl->sbl_size : firmware->size;
441
442 /* SBL size provided is maximum size, not necessarily the image size */
443 if (size > firmware->size)
444 size = firmware->size;
445
446 buf = mhi_alloc_coherent(mhi_cntrl, size, &dma_addr, GFP_KERNEL);
447 if (!buf) {
448 release_firmware(firmware);
449 return;
450 }
451
452 /* Download SBL image */
453 memcpy(buf, firmware->data, size);
454 ret = mhi_fw_load_sbl(mhi_cntrl, dma_addr, size);
455 mhi_free_coherent(mhi_cntrl, size, buf, dma_addr);
456
457 if (!mhi_cntrl->fbc_download || ret || mhi_cntrl->ee == MHI_EE_EDL)
458 release_firmware(firmware);
459
460 /* Error or in EDL mode, we're done */
461 if (ret) {
462 dev_err(dev, "MHI did not load SBL, ret:%d\n", ret);
463 return;
464 }
465
466 if (!ret && mhi_cntrl->cntrl_dev->of_node) {
> 467 ret = of_property_read_u32(mhi_cntrl->cntrl_dev->of_node,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH net] net: dsa: point out the tail taggers
by Andrew Lunn
On Fri, Oct 16, 2020 at 11:19:30PM +0300, Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 10:14:28PM +0200, Andrew Lunn wrote:
> > On Fri, Oct 16, 2020 at 08:33:17PM +0300, Vladimir Oltean wrote:
> > > On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote:
> > > > Hi Christian,
> > > >
> > > > Thank you for the patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on net/master]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-o...
> > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2ecbc1f684482b4ed52447a39903bd9b0f222898
> >
> > > Is the test bot being a bit "slow" today?
> >
> > It is using the net.git commit from yesterday afternoon. net-next got
> > merged into net yesterday evening, so it is a bit behind, but not too
> > far behind.
>
> Exactly. The sha1sum it uses _does_ contain the tail_tag member inside
> struct dsa_device_ops. What's it complaining about?
2ecbc1f684482b4ed52447a39903bd9b0f222898 does not have net-next, as
far as i see, and tail_tag only hit net when net-next was merged into
net.
Or i'm reading the git history wrong.
Andrew
1 year, 11 months
Re: [PATCH 9/9] pstore/blk: don't depend on CONFIG_BLOCK
by kernel test robot
Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on kees/for-next/pstore]
[also build test ERROR on ia64/next linus/master v5.9]
[cannot apply to next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/pstore-zone-ca...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
config: m68k-randconfig-r004-20201016 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a5c145d5f37504bf661cea0d7ac72d45b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christoph-Hellwig/pstore-zone-cap-the-maximum-device-size/20201016-222110
git checkout a5c145d5f37504bf661cea0d7ac72d45b88ebbcc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
m68k-linux-ld: init/main.o: in function `kernel_init_freeable':
>> init/main.c:1527: undefined reference to `pstore_blk_early_init'
vim +1527 init/main.c
b49a733d684e00 Dominik Brodowski 2018-10-23 1478
f80b0c904da93b Vineet Gupta 2012-12-21 1479 static noinline void __init kernel_init_freeable(void)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1480 {
b433c3d4549ae7 Peter Zijlstra 2010-06-28 1481 /*
b433c3d4549ae7 Peter Zijlstra 2010-06-28 1482 * Wait until kthreadd is all set-up.
b433c3d4549ae7 Peter Zijlstra 2010-06-28 1483 */
b433c3d4549ae7 Peter Zijlstra 2010-06-28 1484 wait_for_completion(&kthreadd_done);
31a67102f4762d Linus Torvalds 2012-05-21 1485
31a67102f4762d Linus Torvalds 2012-05-21 1486 /* Now the scheduler is fully set up and can do blocking allocations */
31a67102f4762d Linus Torvalds 2012-05-21 1487 gfp_allowed_mask = __GFP_BITS_MASK;
31a67102f4762d Linus Torvalds 2012-05-21 1488
58568d2a8215cb Miao Xie 2009-06-16 1489 /*
58568d2a8215cb Miao Xie 2009-06-16 1490 * init can allocate pages on any node
58568d2a8215cb Miao Xie 2009-06-16 1491 */
3c466d46a9f38d Lai Jiangshan 2012-12-12 1492 set_mems_allowed(node_states[N_MEMORY]);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1493
9ec52099e4b867 Cedric Le Goater 2006-10-02 1494 cad_pid = task_pid(current);
9ec52099e4b867 Cedric Le Goater 2006-10-02 1495
ca74a6f84e68b4 Andi Kleen 2008-01-30 1496 smp_prepare_cpus(setup_max_cpus);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1497
3347fa0928210d Tejun Heo 2016-09-16 1498 workqueue_init();
3347fa0928210d Tejun Heo 2016-09-16 1499
597b7305dd8baf Michal Hocko 2017-03-31 1500 init_mm_internals();
597b7305dd8baf Michal Hocko 2017-03-31 1501
^1da177e4c3f41 Linus Torvalds 2005-04-16 1502 do_pre_smp_initcalls();
004417a6d468e2 Peter Zijlstra 2010-11-25 1503 lockup_detector_init();
^1da177e4c3f41 Linus Torvalds 2005-04-16 1504
^1da177e4c3f41 Linus Torvalds 2005-04-16 1505 smp_init();
^1da177e4c3f41 Linus Torvalds 2005-04-16 1506 sched_init_smp();
^1da177e4c3f41 Linus Torvalds 2005-04-16 1507
f1b192b117cd41 Daniel Jordan 2020-06-03 1508 padata_init();
0e1cc95b4cc729 Mel Gorman 2015-06-30 1509 page_alloc_init_late();
2f1ee0913ce58e Qian Cai 2019-02-12 1510 /* Initialize page ext after all struct pages are initialized. */
2f1ee0913ce58e Qian Cai 2019-02-12 1511 page_ext_init();
0e1cc95b4cc729 Mel Gorman 2015-06-30 1512
^1da177e4c3f41 Linus Torvalds 2005-04-16 1513 do_basic_setup();
^1da177e4c3f41 Linus Torvalds 2005-04-16 1514
b49a733d684e00 Dominik Brodowski 2018-10-23 1515 console_on_rootfs();
2bd3a997befc22 Eric W. Biederman 2010-03-02 1516
^1da177e4c3f41 Linus Torvalds 2005-04-16 1517 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1518 * check if there is an early userspace init. If yes, let it do all
^1da177e4c3f41 Linus Torvalds 2005-04-16 1519 * the work
^1da177e4c3f41 Linus Torvalds 2005-04-16 1520 */
eb9d7d390e5110 Christoph Hellwig 2020-07-22 1521 if (init_eaccess(ramdisk_execute_command) != 0) {
ffdfc40976dda1 Olof Johansson 2005-09-06 1522 ramdisk_execute_command = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1523 prepare_namespace();
ffdfc40976dda1 Olof Johansson 2005-09-06 1524 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1525
796d214cf62d9b Christoph Hellwig 2020-10-16 1526 if (IS_BUILTIN(CONFIG_PSTORE_BLK))
796d214cf62d9b Christoph Hellwig 2020-10-16 @1527 pstore_blk_early_init();
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
