Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file_operations
by kernel test robot
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/kiransuren-osuosl-org/Staging-an...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 726eb70e0d34dc4bc4dada71f52bba8ed638431e
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1496e5f2103cc6f96af90aaf323cf92f0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review kiransuren-osuosl-org/Staging-android-ashmem-changed-struct-file_operations-to-const-file_operations/20201016-131238
git checkout 1496e5f2103cc6f96af90aaf323cf92f018dcf41
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/staging/android/ashmem.c: In function 'ashmem_mmap':
>> drivers/staging/android/ashmem.c:379:15: error: unknown type name 'file_operations'
379 | static const file_operations vmfile_fops;
| ^~~~~~~~~~~~~~~
>> drivers/staging/android/ashmem.c:429:19: error: request for member 'mmap' in something not a structure or union
429 | if (!vmfile_fops.mmap) {
| ^
>> drivers/staging/android/ashmem.c:430:16: error: assignment of read-only variable 'vmfile_fops'
430 | vmfile_fops = *vmfile->f_op;
| ^
drivers/staging/android/ashmem.c:431:15: error: request for member 'mmap' in something not a structure or union
431 | vmfile_fops.mmap = ashmem_vmfile_mmap;
| ^
>> drivers/staging/android/ashmem.c:432:15: error: request for member 'get_unmapped_area' in something not a structure or union
432 | vmfile_fops.get_unmapped_area =
| ^
>> drivers/staging/android/ashmem.c:435:16: error: assignment to 'const struct file_operations *' from incompatible pointer type 'const int *' [-Werror=incompatible-pointer-types]
435 | vmfile->f_op = &vmfile_fops;
| ^
cc1: some warnings being treated as errors
vim +/file_operations +379 drivers/staging/android/ashmem.c
376
377 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
378 {
> 379 static const file_operations vmfile_fops;
380 struct ashmem_area *asma = file->private_data;
381 int ret = 0;
382
383 mutex_lock(&ashmem_mutex);
384
385 /* user needs to SET_SIZE before mapping */
386 if (!asma->size) {
387 ret = -EINVAL;
388 goto out;
389 }
390
391 /* requested mapping size larger than object size */
392 if (vma->vm_end - vma->vm_start > PAGE_ALIGN(asma->size)) {
393 ret = -EINVAL;
394 goto out;
395 }
396
397 /* requested protection bits must match our allowed protection mask */
398 if ((vma->vm_flags & ~calc_vm_prot_bits(asma->prot_mask, 0)) &
399 calc_vm_prot_bits(PROT_MASK, 0)) {
400 ret = -EPERM;
401 goto out;
402 }
403 vma->vm_flags &= ~calc_vm_may_flags(~asma->prot_mask);
404
405 if (!asma->file) {
406 char *name = ASHMEM_NAME_DEF;
407 struct file *vmfile;
408 struct inode *inode;
409
410 if (asma->name[ASHMEM_NAME_PREFIX_LEN] != '\0')
411 name = asma->name;
412
413 /* ... and allocate the backing shmem file */
414 vmfile = shmem_file_setup(name, asma->size, vma->vm_flags);
415 if (IS_ERR(vmfile)) {
416 ret = PTR_ERR(vmfile);
417 goto out;
418 }
419 vmfile->f_mode |= FMODE_LSEEK;
420 inode = file_inode(vmfile);
421 lockdep_set_class(&inode->i_rwsem, &backing_shmem_inode_class);
422 asma->file = vmfile;
423 /*
424 * override mmap operation of the vmfile so that it can't be
425 * remapped which would lead to creation of a new vma with no
426 * asma permission checks. Have to override get_unmapped_area
427 * as well to prevent VM_BUG_ON check for f_ops modification.
428 */
> 429 if (!vmfile_fops.mmap) {
> 430 vmfile_fops = *vmfile->f_op;
431 vmfile_fops.mmap = ashmem_vmfile_mmap;
> 432 vmfile_fops.get_unmapped_area =
433 ashmem_vmfile_get_unmapped_area;
434 }
> 435 vmfile->f_op = &vmfile_fops;
436 }
437 get_file(asma->file);
438
439 /*
440 * XXX - Reworked to use shmem_zero_setup() instead of
441 * shmem_set_file while we're in staging. -jstultz
442 */
443 if (vma->vm_flags & VM_SHARED) {
444 ret = shmem_zero_setup(vma);
445 if (ret) {
446 fput(asma->file);
447 goto out;
448 }
449 } else {
450 vma_set_anonymous(vma);
451 }
452
453 if (vma->vm_file)
454 fput(vma->vm_file);
455 vma->vm_file = asma->file;
456
457 out:
458 mutex_unlock(&ashmem_mutex);
459 return ret;
460 }
461
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
arch/x86/kernel/jailhouse.o: warning: objtool: jailhouse_init_platform()+0x1ef: unreachable instruction
by kernel test robot
CC: linux-kernel(a)vger.kernel.org
TO: Kees Cook <keescook(a)chromium.org>
CC: Andrew Morton <akpm(a)linux-foundation.org>
CC: Linux Memory Management List <linux-mm(a)kvack.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 840e5bb326bbcb16ce82dd2416d2769de4839aea
commit: 0887a7ebc97770c7870abf3075a2e8cd502a7f52 ubsan: add trap instrumentation option
date: 6 months ago
config: x86_64-randconfig-a003-20201016 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0887a7ebc97770c7870abf3075a2e8cd502a7f52
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/jailhouse.o: warning: objtool: jailhouse_init_platform()+0x1ef: unreachable instruction
--
>> arch/x86/kernel/amd_gart_64.o: warning: objtool: gart_map_sg()+0x3e1: unreachable instruction
--
>> kernel/seccomp.o: warning: objtool: __secure_computing()+0x7e: unreachable instruction
--
>> fs/nfs/callback.o: warning: objtool: nfs4_callback_svc()+0x75: unreachable instruction
--
>> fs/nfs/nfs4state.o: warning: objtool: nfs4_run_state_manager()+0x27: unreachable instruction
--
>> drivers/watchdog/intel-mid_wdt.o: warning: objtool: mid_wdt_irq()+0xe: unreachable instruction
--
>> drivers/watchdog/softdog.o: warning: objtool: softdog_fire()+0x60: unreachable instruction
--
>> fs/reiserfs/bitmap.o: warning: objtool: reiserfs_free_block()+0xaa: unreachable instruction
--
>> fs/reiserfs/namei.o: warning: objtool: search_by_entry_key()+0x244: unreachable instruction
--
>> fs/reiserfs/dir.o: warning: objtool: reiserfs_readdir_inode()+0x540: unreachable instruction
--
>> fs/reiserfs/do_balan.o: warning: objtool: make_empty_node()+0x70: unreachable instruction
..
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[hch-misc:pstore 6/6] fs/pstore/blk.c:199:37: warning: unused variable 'pstore_blk_zone_ops'
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git pstore
head: e43b52f73d29c36717f1d78600efd2b7fc251c18
commit: e43b52f73d29c36717f1d78600efd2b7fc251c18 [6/6] pstore/blk: use the proper I/O path
config: riscv-randconfig-r004-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc pstore
git checkout e43b52f73d29c36717f1d78600efd2b7fc251c18
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:556:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inb(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:54:76: note: expanded from macro 'inb'
#define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:87:48: note: expanded from macro 'readb_cpu'
#define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; })
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:564:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inw(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:55:76: note: expanded from macro 'inw'
#define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:88:76: note: expanded from macro 'readw_cpu'
#define readw_cpu(c) ({ u16 __r = le16_to_cpu((__force __le16)__raw_readw(c)); __r; })
^
include/uapi/linux/byteorder/little_endian.h:36:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:572:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inl(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:56:76: note: expanded from macro 'inl'
#define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:89:76: note: expanded from macro 'readl_cpu'
#define readl_cpu(c) ({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; })
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:580:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outb(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:58:68: note: expanded from macro 'outb'
#define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:91:52: note: expanded from macro 'writeb_cpu'
#define writeb_cpu(v, c) ((void)__raw_writeb((v), (c)))
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:588:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outw(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:59:68: note: expanded from macro 'outw'
#define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:92:76: note: expanded from macro 'writew_cpu'
#define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c)))
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:596:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outl(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:60:68: note: expanded from macro 'outl'
#define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:93:76: note: expanded from macro 'writel_cpu'
#define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c)))
^
In file included from fs/pstore/blk.c:13:
In file included from include/linux/of_address.h:7:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:1017:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
~~~~~~~~~~ ^
>> fs/pstore/blk.c:199:37: warning: unused variable 'pstore_blk_zone_ops' [-Wunused-const-variable]
static const struct pstore_zone_ops pstore_blk_zone_ops = {
^
8 warnings generated.
vim +/pstore_blk_zone_ops +199 fs/pstore/blk.c
17639f67c1d61ab WeiXiong Liao 2020-03-25 198
0b670e4409bb317 Christoph Hellwig 2020-10-15 @199 static const struct pstore_zone_ops pstore_blk_zone_ops = {
0b670e4409bb317 Christoph Hellwig 2020-10-15 200 .name = KBUILD_MODNAME,
0b670e4409bb317 Christoph Hellwig 2020-10-15 201 .read = psblk_generic_blk_read,
0b670e4409bb317 Christoph Hellwig 2020-10-15 202 .write = psblk_generic_blk_write,
0b670e4409bb317 Christoph Hellwig 2020-10-15 203 };
0b670e4409bb317 Christoph Hellwig 2020-10-15 204
:::::: The code at line 199 was first introduced by commit
:::::: 0b670e4409bb317166cf859b3bb3af2562d275e7 pstore/zone: split struct pstore_zone_info
:::::: TO: Christoph Hellwig <hch(a)lst.de>
:::::: CC: Christoph Hellwig <hch(a)lst.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 2/2] ipu3-cio2: Use v4l2_get_link_freq helper
by kernel test robot
Hi Sakari,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20201015]
[cannot apply to v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/Link-frequency-help...
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a012-20201015 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/cf4ab5e39eb042b02f1d5660b5cbd8819...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sakari-Ailus/Link-frequency-helper-for-receivers/20201013-233742
git checkout cf4ab5e39eb042b02f1d5660b5cbd88197a05520
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/media/pci/intel/ipu3/ipu3-cio2.c:308:50: warning: format specifies type 'long' but the argument has type 's64' (aka 'long long') [-Wformat]
dev_err(dev, "error %ld, invalid link_freq\n", freq);
~~~ ^~~~
%lld
include/linux/dev_printk.h:104:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
drivers/media/pci/intel/ipu3/ipu3-cio2.c:301:6: warning: unused variable 'r' [-Wunused-variable]
int r;
^
2 warnings generated.
vim +308 drivers/media/pci/intel/ipu3/ipu3-cio2.c
293
294 /* Calculate the the delay value for termination enable of clock lane HS Rx */
295 static int cio2_csi2_calc_timing(struct cio2_device *cio2, struct cio2_queue *q,
296 struct cio2_csi2_timing *timing,
297 unsigned int bpp, unsigned int lanes)
298 {
299 struct device *dev = &cio2->pci_dev->dev;
300 s64 freq;
301 int r;
302
303 if (!q->sensor)
304 return -ENODEV;
305
306 freq = v4l2_get_link_rate(q->sensor->ctrl_handler, bpp, lanes);
307 if (freq < 0) {
> 308 dev_err(dev, "error %ld, invalid link_freq\n", freq);
309 return freq;
310 }
311
312 timing->clk_termen = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_TERMEN_CLANE_A,
313 CIO2_CSIRX_DLY_CNT_TERMEN_CLANE_B,
314 freq,
315 CIO2_CSIRX_DLY_CNT_TERMEN_DEFAULT);
316 timing->clk_settle = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_SETTLE_CLANE_A,
317 CIO2_CSIRX_DLY_CNT_SETTLE_CLANE_B,
318 freq,
319 CIO2_CSIRX_DLY_CNT_SETTLE_DEFAULT);
320 timing->dat_termen = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_TERMEN_DLANE_A,
321 CIO2_CSIRX_DLY_CNT_TERMEN_DLANE_B,
322 freq,
323 CIO2_CSIRX_DLY_CNT_TERMEN_DEFAULT);
324 timing->dat_settle = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_SETTLE_DLANE_A,
325 CIO2_CSIRX_DLY_CNT_SETTLE_DLANE_B,
326 freq,
327 CIO2_CSIRX_DLY_CNT_SETTLE_DEFAULT);
328
329 dev_dbg(dev, "freq ct value is %d\n", timing->clk_termen);
330 dev_dbg(dev, "freq cs value is %d\n", timing->clk_settle);
331 dev_dbg(dev, "freq dt value is %d\n", timing->dat_termen);
332 dev_dbg(dev, "freq ds value is %d\n", timing->dat_settle);
333
334 return 0;
335 };
336
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[RFC PATCH] leds: trigger: ledtrig_tty can be static
by kernel test robot
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
ledtrig-tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c
index 806548e33cd874..09cba818fb65c7 100644
--- a/drivers/leds/trigger/ledtrig-tty.c
+++ b/drivers/leds/trigger/ledtrig-tty.c
@@ -174,7 +174,7 @@ static void ledtrig_tty_deactivate(struct led_classdev *led_cdev)
kfree(trigger_data);
}
-struct led_trigger ledtrig_tty = {
+static struct led_trigger ledtrig_tty = {
.name = "tty",
.activate = ledtrig_tty_activate,
.deactivate = ledtrig_tty_deactivate,
1 year, 11 months
[android-common:android11-5.4 8965/9908] drivers/media/tuners/tda8290.c:468: undefined reference to `i2c_transfer'
by kernel test robot
Hi Greg,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android11-5.4
head: a2114d2456100c0db1d94773ec377fe8fa89f4a9
commit: 9c8aa25e2955df58dae59e409ec1bc7f850935d9 [8965/9908] ANDROID: GKI: fix symbol_get/put() build error on arm64 defconfig
config: x86_64-randconfig-a011-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android11-5.4
git checkout 9c8aa25e2955df58dae59e409ec1bc7f850935d9
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: drivers/i2c/algos/i2c-algo-bit.o: in function `i2c_bit_add_bus':
drivers/i2c/algos/i2c-algo-bit.c:685: undefined reference to `i2c_add_adapter'
ld: drivers/i2c/algos/i2c-algo-bit.o: in function `i2c_bit_add_numbered_bus':
drivers/i2c/algos/i2c-algo-bit.c:691: undefined reference to `i2c_add_numbered_adapter'
ld: drivers/media/tuners/tda8290.o: in function `tuner_i2c_xfer_send':
drivers/media/tuners/tuner-i2c.h:29: undefined reference to `i2c_transfer'
ld: drivers/media/tuners/tuner-i2c.h:29: undefined reference to `i2c_transfer'
ld: drivers/media/tuners/tda8290.o: in function `tda8290_standby':
>> drivers/media/tuners/tda8290.c:468: undefined reference to `i2c_transfer'
ld: drivers/media/tuners/tda8290.o: in function `tuner_i2c_xfer_send':
drivers/media/tuners/tuner-i2c.h:29: undefined reference to `i2c_transfer'
ld: drivers/media/tuners/tuner-i2c.h:29: undefined reference to `i2c_transfer'
ld: drivers/media/tuners/tda8290.o:drivers/media/tuners/tda8290.c:584: more undefined references to `i2c_transfer' follow
vim +468 drivers/media/tuners/tda8290.c
de48eebce8b63db drivers/media/video/tda8290.c Hartmut Hackmann 2005-11-08 454
4e9154b8a77d0f0 drivers/media/video/tda8290.c Michael Krufky 2007-10-21 455 static void tda8290_standby(struct dvb_frontend *fe)
793cf9e6a54c698 drivers/media/video/tda8290.c Mauro Carvalho Chehab 2005-09-09 456 {
4e9154b8a77d0f0 drivers/media/video/tda8290.c Michael Krufky 2007-10-21 457 struct tda8290_priv *priv = fe->analog_demod_priv;
4e9154b8a77d0f0 drivers/media/video/tda8290.c Michael Krufky 2007-10-21 458
8ff230fb4f48816 drivers/media/tuners/tda8290.c Arnd Bergmann 2017-12-11 459 static unsigned char cb1[] = { 0x30, 0xD0 };
8ff230fb4f48816 drivers/media/tuners/tda8290.c Arnd Bergmann 2017-12-11 460 static unsigned char tda8290_standby[] = { 0x00, 0x02 };
8ff230fb4f48816 drivers/media/tuners/tda8290.c Arnd Bergmann 2017-12-11 461 static unsigned char tda8290_agc_tri[] = { 0x02, 0x20 };
b208319993ceff7 drivers/media/video/tda8290.c Michael Krufky 2007-05-29 462 struct i2c_msg msg = {.addr = priv->tda827x_addr, .flags=0, .buf=cb1, .len = 2};
de48eebce8b63db drivers/media/video/tda8290.c Hartmut Hackmann 2005-11-08 463
2f719f7a9aa599b drivers/media/tuners/tda8290.c Ondrej Zary 2013-02-03 464 if (fe->ops.analog_ops.i2c_gate_ctrl)
2f719f7a9aa599b drivers/media/tuners/tda8290.c Ondrej Zary 2013-02-03 465 fe->ops.analog_ops.i2c_gate_ctrl(fe, 1);
8c125f2ceb3ec1b drivers/media/video/tda8290.c Michael Krufky 2007-10-27 466 if (priv->ver & TDA8275A)
de48eebce8b63db drivers/media/video/tda8290.c Hartmut Hackmann 2005-11-08 467 cb1[1] = 0x90;
db8a695658cda21 drivers/media/video/tda8290.c Michael Krufky 2007-08-21 @468 i2c_transfer(priv->i2c_props.adap, &msg, 1);
2f719f7a9aa599b drivers/media/tuners/tda8290.c Ondrej Zary 2013-02-03 469 if (fe->ops.analog_ops.i2c_gate_ctrl)
2f719f7a9aa599b drivers/media/tuners/tda8290.c Ondrej Zary 2013-02-03 470 fe->ops.analog_ops.i2c_gate_ctrl(fe, 0);
db8a695658cda21 drivers/media/video/tda8290.c Michael Krufky 2007-08-21 471 tuner_i2c_xfer_send(&priv->i2c_props, tda8290_agc_tri, 2);
db8a695658cda21 drivers/media/video/tda8290.c Michael Krufky 2007-08-21 472 tuner_i2c_xfer_send(&priv->i2c_props, tda8290_standby, 2);
793cf9e6a54c698 drivers/media/video/tda8290.c Mauro Carvalho Chehab 2005-09-09 473 }
793cf9e6a54c698 drivers/media/video/tda8290.c Mauro Carvalho Chehab 2005-09-09 474
:::::: The code at line 468 was first introduced by commit
:::::: db8a695658cda21eacfa2a5e3b15e8964bfb93ef V4L/DVB (6127): tuner: kill i2c_client interface to tuner sub-drivers
:::::: TO: Michael Krufky <mkrufky(a)linuxtv.org>
:::::: CC: Mauro Carvalho Chehab <mchehab(a)infradead.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH RFC bpf-next 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter
by kernel test robot
Hi "Toke,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Rewor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: powerpc-randconfig-r006-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/49323d0d5b278524de4bd9450ce2962a4...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Toke-H-iland-J-rgensen/bpf-Rework-bpf_redirect_neigh-to-allow-supplying-nexthop-from-caller/20201015-234710
git checkout 49323d0d5b278524de4bd9450ce2962a44311fec
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
__do_insb
^
arch/powerpc/include/asm/io.h:541:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from net/core/filter.c:25:
In file included from include/linux/sock_diag.h:5:
In file included from include/linux/netlink.h:7:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:141:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from net/core/filter.c:25:
In file included from include/linux/sock_diag.h:5:
In file included from include/linux/netlink.h:7:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:146:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from net/core/filter.c:25:
In file included from include/linux/sock_diag.h:5:
In file included from include/linux/netlink.h:7:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:151:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from net/core/filter.c:25:
In file included from include/linux/sock_diag.h:5:
In file included from include/linux/netlink.h:7:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:156:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from net/core/filter.c:25:
In file included from include/linux/sock_diag.h:5:
In file included from include/linux/netlink.h:7:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:161:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> net/core/filter.c:2404:44: error: too many arguments to function call, expected 2, have 3
return __bpf_redirect_neigh_v6(skb, dev, nh);
~~~~~~~~~~~~~~~~~~~~~~~ ^~
net/core/filter.c:2267:12: note: '__bpf_redirect_neigh_v6' declared here
static int __bpf_redirect_neigh_v6(struct sk_buff *skb, struct net_device *dev)
^
6 warnings and 1 error generated.
vim +2404 net/core/filter.c
2385
2386 static int __bpf_redirect_neigh(struct sk_buff *skb, struct net_device *dev,
2387 struct bpf_nh_params *nh)
2388 {
2389 struct ethhdr *ethh = eth_hdr(skb);
2390
2391 if (unlikely(skb->mac_header >= skb->network_header))
2392 goto out;
2393 bpf_push_mac_rcsum(skb);
2394 if (is_multicast_ether_addr(ethh->h_dest))
2395 goto out;
2396
2397 skb_pull(skb, sizeof(*ethh));
2398 skb_unset_mac_header(skb);
2399 skb_reset_network_header(skb);
2400
2401 if (skb->protocol == htons(ETH_P_IP))
2402 return __bpf_redirect_neigh_v4(skb, dev, nh);
2403 else if (skb->protocol == htons(ETH_P_IPV6))
> 2404 return __bpf_redirect_neigh_v6(skb, dev, nh);
2405 out:
2406 kfree_skb(skb);
2407 return -ENOTSUPP;
2408 }
2409
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months