Re: [PATCH 3/3] mfd: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller
by kernel test robot
Hi Shihlun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.9]
[cannot apply to lee-mfd/for-mfd-next next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shihlun-Lin/mfd-ahc1ec0-Add-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b5fc7a89e58bcc059a3d5e4db79c481fb437de59
config: parisc-randconfig-r003-20201014 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c0d1228cbc430e5be6ac8a311f8fa783f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
git checkout c0d1228cbc430e5be6ac8a311f8fa783f9285628
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/mfd/ahc1ec0-wdt.c: In function 'wdt_proc_read':
>> drivers/mfd/ahc1ec0-wdt.c:162:17: warning: variable 'name' set but not used [-Wunused-but-set-variable]
162 | unsigned char *name, *chip_name, *is_enable;
| ^~~~
drivers/mfd/ahc1ec0-wdt.c: In function 'adv_ec_wdt_probe':
>> drivers/mfd/ahc1ec0-wdt.c:426:31: warning: variable 'adv_ec_data' set but not used [-Wunused-but-set-variable]
426 | struct adv_ec_platform_data *adv_ec_data;
| ^~~~~~~~~~~
vim +/name +162 drivers/mfd/ahc1ec0-wdt.c
159
160 static int wdt_proc_read(struct seq_file *m, void *p)
161 {
> 162 unsigned char *name, *chip_name, *is_enable;
163 unsigned long current_timeout = 0;
164
165 name = m->private;
166
167 chip_name = wdt_data.chip_name;
168 current_timeout = wdt_data.current_timeout;
169 is_enable = wdt_data.is_enable;
170
171 seq_printf(m, "name : %s\n", chip_name);
172 seq_printf(m, "timeout : %ld\n", current_timeout);
173 seq_printf(m, "is_enable : %s\n", is_enable);
174
175 return 0;
176 }
177
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 3/3] scsi_debug: iouring iopoll support
by kernel test robot
Hi Kashyap,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20201013]
[cannot apply to scsi/for-next mkp-scsi/for-next v5.9 v5.9-rc8 v5.9-rc7 v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kashyap-Desai/add-io_uring-with-...
base: f2fb1afc57304f9dd68c20a08270e287470af2eb
config: powerpc64-randconfig-r006-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7fe3c6dfede8d5781bd000741c3dea7088307a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/a3173d0d1c2ca8a45007fa994f2641aa7...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kashyap-Desai/add-io_uring-with-IOPOLL-support-in-scsi-layer/20201014-202916
git checkout a3173d0d1c2ca8a45007fa994f2641aa7262719c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:29:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:541:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:31:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:33:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:35:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:37:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/scsi/scsi_debug.c:32:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:39:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
drivers/scsi/scsi_debug.c:5442:3: error: non-void function 'schedule_resp' should return a value [-Wreturn-type]
return;
^
>> drivers/scsi/scsi_debug.c:7246:5: warning: no previous prototype for function 'sdebug_blk_mq_poll' [-Wmissing-prototypes]
int sdebug_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
^
drivers/scsi/scsi_debug.c:7246:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sdebug_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
^
static
7 warnings and 1 error generated.
vim +/sdebug_blk_mq_poll +7246 drivers/scsi/scsi_debug.c
7245
> 7246 int sdebug_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
7247 {
7248 int qc_idx;
7249 int retiring = 0;
7250 unsigned long iflags;
7251 struct sdebug_queue *sqp;
7252 struct sdebug_queued_cmd *sqcp;
7253 struct scsi_cmnd *scp;
7254 struct sdebug_dev_info *devip;
7255 int num_entries = 0;
7256
7257 sqp = sdebug_q_arr + queue_num;
7258
7259 do {
7260 spin_lock_irqsave(&sqp->qc_lock, iflags);
7261 qc_idx = find_first_bit(sqp->in_use_bm, sdebug_max_queue);
7262 if (unlikely((qc_idx < 0) || (qc_idx >= SDEBUG_CANQUEUE)))
7263 goto out;
7264
7265 sqcp = &sqp->qc_arr[qc_idx];
7266 scp = sqcp->a_cmnd;
7267 if (unlikely(scp == NULL)) {
7268 pr_err("scp is NULL, queue_num=%d, qc_idx=%d from %s\n",
7269 queue_num, qc_idx, __func__);
7270 goto out;
7271 }
7272 devip = (struct sdebug_dev_info *)scp->device->hostdata;
7273 if (likely(devip))
7274 atomic_dec(&devip->num_in_q);
7275 else
7276 pr_err("devip=NULL from %s\n", __func__);
7277 if (unlikely(atomic_read(&retired_max_queue) > 0))
7278 retiring = 1;
7279
7280 sqcp->a_cmnd = NULL;
7281 if (unlikely(!test_and_clear_bit(qc_idx, sqp->in_use_bm))) {
7282 pr_err("Unexpected completion sqp %p queue_num=%d qc_idx=%d from %s\n",
7283 sqp, queue_num, qc_idx, __func__);
7284 goto out;
7285 }
7286
7287 if (unlikely(retiring)) { /* user has reduced max_queue */
7288 int k, retval;
7289
7290 retval = atomic_read(&retired_max_queue);
7291 if (qc_idx >= retval) {
7292 pr_err("index %d too large\n", retval);
7293 goto out;
7294 }
7295 k = find_last_bit(sqp->in_use_bm, retval);
7296 if ((k < sdebug_max_queue) || (k == retval))
7297 atomic_set(&retired_max_queue, 0);
7298 else
7299 atomic_set(&retired_max_queue, k + 1);
7300 }
7301 spin_unlock_irqrestore(&sqp->qc_lock, iflags);
7302 scp->scsi_done(scp); /* callback to mid level */
7303 num_entries++;
7304 } while (1);
7305
7306 out:
7307 spin_unlock_irqrestore(&sqp->qc_lock, iflags);
7308 return num_entries;
7309 }
7310
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[linux-next:master 12312/14891] sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f2fb1afc57304f9dd68c20a08270e287470af2eb
commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 [12312/14891] ASoC: Intel: Select catpt and deprecate haswell
config: x86_64-randconfig-m031-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here
vim +654 sound/soc/intel/catpt/loader.c
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 637
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 638 int catpt_first_boot_firmware(struct catpt_dev *cdev)
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 639 {
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 640 struct resource *res;
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 641 int ret;
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 642
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 643 ret = catpt_boot_firmware(cdev, false);
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 644 if (ret) {
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 645 dev_err(cdev->dev, "basefw boot failed: %d\n", ret);
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 646 return ret;
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 647 }
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 648
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 649 /* restrict FW Core dump area */
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 650 __request_region(&cdev->dram, 0, 0x200, NULL, 0);
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 651 /* restrict entire area following BASE_FW - highest offset in DRAM */
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 652 for (res = cdev->dram.child; res->sibling; res = res->sibling)
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 653 ;
a9aa6fb3eb6c7e0 Cezary Rojewski 2020-09-29 @654 __request_region(&cdev->dram, res->end + 1,
:::::: The code at line 654 was first introduced by commit
:::::: a9aa6fb3eb6c7e0e7e117b3f2dfafef8c45b9ea6 ASoC: Intel: catpt: Firmware loading and context restore
:::::: TO: Cezary Rojewski <cezary.rojewski(a)intel.com>
:::::: CC: Mark Brown <broonie(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 2/3] megaraid_sas: iouring iopoll support
by kernel test robot
Hi Kashyap,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20201013]
[cannot apply to scsi/for-next mkp-scsi/for-next v5.9 v5.9-rc8 v5.9-rc7 v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kashyap-Desai/add-io_uring-with-...
base: f2fb1afc57304f9dd68c20a08270e287470af2eb
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f93510c3e695f6f22822115f6587db68...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kashyap-Desai/add-io_uring-with-IOPOLL-support-in-scsi-layer/20201014-202916
git checkout 4f93510c3e695f6f22822115f6587db68fb40e5c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3652:5: warning: no previous prototype for 'megasas_blk_mq_poll' [-Wmissing-prototypes]
3652 | int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
| ^~~~~~~~~~~~~~~~~~~
vim +/megasas_blk_mq_poll +3652 drivers/scsi/megaraid/megaraid_sas_fusion.c
3651
> 3652 int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
3653 {
3654
3655 struct megasas_instance *instance;
3656 int num_entries = 0;
3657 struct fusion_context *fusion;
3658
3659 instance = (struct megasas_instance *)shost->hostdata;
3660
3661 fusion = instance->ctrl_context;
3662
3663 queue_num = queue_num + instance->low_latency_index_start;
3664
3665 if (!atomic_add_unless(&fusion->busy_mq_poll[queue_num], 1, 1))
3666 return 0;
3667
3668 num_entries = complete_cmd_fusion(instance, queue_num, NULL);
3669 atomic_dec(&fusion->busy_mq_poll[queue_num]);
3670
3671 return num_entries;
3672 }
3673
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH v2 1/2] efi: add secure boot get helper
by kernel test robot
Hi Chester,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on efi/next tip/x86/core v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chester-Lin/add-ima_arch-support...
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: x86_64-randconfig-r003-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7fe3c6dfede8d5781bd000741c3dea7088307a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/d88d2474c8dbc487055a897d379568b92...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chester-Lin/add-ima_arch-support-for-ARM64/20201014-184221
git checkout d88d2474c8dbc487055a897d379568b92bb3666e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/mm/fault.c:19:
>> include/linux/efi.h:1090:40: error: incomplete result type 'enum efi_secureboot_mode' in function definition
static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
^
include/linux/efi.h:1090:20: note: forward declaration of 'enum efi_secureboot_mode'
static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
^
>> include/linux/efi.h:1092:9: error: use of undeclared identifier 'efi_secureboot_mode_disabled'
return efi_secureboot_mode_disabled;
^
2 errors generated.
--
In file included from arch/x86/mm/ioremap.c:18:
>> include/linux/efi.h:1090:40: error: incomplete result type 'enum efi_secureboot_mode' in function definition
static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
^
include/linux/efi.h:1090:20: note: forward declaration of 'enum efi_secureboot_mode'
static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
^
>> include/linux/efi.h:1092:9: error: use of undeclared identifier 'efi_secureboot_mode_disabled'
return efi_secureboot_mode_disabled;
^
arch/x86/mm/ioremap.c:737:17: warning: no previous prototype for function 'early_memremap_pgprot_adjust' [-Wmissing-prototypes]
pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
^
arch/x86/mm/ioremap.c:737:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
^
static
1 warning and 2 errors generated.
vim +1090 include/linux/efi.h
1084
1085 #ifdef CONFIG_EFI
1086 extern bool efi_runtime_disabled(void);
1087 extern enum efi_secureboot_mode efi_get_secureboot_mode(void);
1088 #else
1089 static inline bool efi_runtime_disabled(void) { return true; }
> 1090 static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
1091 {
> 1092 return efi_secureboot_mode_disabled;
1093 }
1094 #endif
1095
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[chrome-os:chromeos-4.4 15/15] /tmp/trackpoint-558911.s:421: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4
head: 2828262ea2c5dd93d7f74ee7006cef6b9ae45ea9
commit: 2828262ea2c5dd93d7f74ee7006cef6b9ae45ea9 [15/15] FROMGIT: HID: wacom: Avoid entering wacom_wac_pen_report for pad / battery
config: x86_64-randconfig-a006-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7fe3c6dfede8d5781bd000741c3dea7088307a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-4.4
git checkout 2828262ea2c5dd93d7f74ee7006cef6b9ae45ea9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/input/mouse/trackpoint.c:11:
In file included from include/linux/slab.h:113:
In file included from include/linux/kasan.h:4:
In file included from include/linux/sched.h:62:
In file included from include/linux/cgroup-defs.h:16:
include/linux/percpu-refcount.h:177:3: warning: comparison of integers of different signs: 'unsigned long' and 'int' [-Wsign-compare]
this_cpu_add(*percpu_count, nr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:526:33: note: expanded from macro 'this_cpu_add'
#define this_cpu_add(pcp, val) __pcpu_size_call(this_cpu_add_, pcp, val)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:397:11: note: expanded from macro '__pcpu_size_call'
case 8: stem##8(variable, __VA_ARGS__);break; \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<scratch space>:287:1: note: expanded from here
this_cpu_add_8
^
arch/x86/include/asm/percpu.h:478:35: note: expanded from macro 'this_cpu_add_8'
#define this_cpu_add_8(pcp, val) percpu_add_op((pcp), val)
^~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/percpu.h:130:31: note: expanded from macro 'percpu_add_op'
((val) == 1 || (val) == -1)) ? \
~~~ ^ ~~
In file included from drivers/input/mouse/trackpoint.c:11:
In file included from include/linux/slab.h:113:
In file included from include/linux/kasan.h:4:
In file included from include/linux/sched.h:62:
In file included from include/linux/cgroup-defs.h:16:
include/linux/percpu-refcount.h:276:3: warning: comparison of integers of different signs: 'unsigned long' and 'int' [-Wsign-compare]
this_cpu_sub(*percpu_count, nr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:536:33: note: expanded from macro 'this_cpu_sub'
#define this_cpu_sub(pcp, val) this_cpu_add(pcp, -(typeof(pcp))(val))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:526:33: note: expanded from macro 'this_cpu_add'
#define this_cpu_add(pcp, val) __pcpu_size_call(this_cpu_add_, pcp, val)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:397:11: note: expanded from macro '__pcpu_size_call'
case 8: stem##8(variable, __VA_ARGS__);break; \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<scratch space>:96:1: note: expanded from here
this_cpu_add_8
^
arch/x86/include/asm/percpu.h:478:35: note: expanded from macro 'this_cpu_add_8'
#define this_cpu_add_8(pcp, val) percpu_add_op((pcp), val)
^~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/percpu.h:130:31: note: expanded from macro 'percpu_add_op'
((val) == 1 || (val) == -1)) ? \
~~~ ^ ~~
In file included from drivers/input/mouse/trackpoint.c:13:
In file included from include/linux/serio.h:13:
In file included from include/linux/interrupt.h:12:
In file included from include/linux/hardirq.h:8:
In file included from arch/x86/include/asm/hardirq.h:5:
In file included from include/linux/irq.h:418:
In file included from arch/x86/include/asm/hw_irq.h:26:
In file included from arch/x86/include/asm/sections.h:5:
arch/x86/include/asm/uaccess.h:754:26: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
if (likely(sz < 0 || sz >= n)) {
~~ ^ ~
include/linux/compiler.h:181:40: note: expanded from macro 'likely'
# define likely(x) __builtin_expect(!!(x), 1)
^
In file included from drivers/input/mouse/trackpoint.c:13:
In file included from include/linux/serio.h:13:
In file included from include/linux/interrupt.h:12:
In file included from include/linux/hardirq.h:8:
In file included from arch/x86/include/asm/hardirq.h:5:
In file included from include/linux/irq.h:418:
In file included from arch/x86/include/asm/hw_irq.h:26:
In file included from arch/x86/include/asm/sections.h:5:
arch/x86/include/asm/uaccess.h:773:26: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
if (likely(sz < 0 || sz >= n)) {
~~ ^ ~
include/linux/compiler.h:181:40: note: expanded from macro 'likely'
# define likely(x) __builtin_expect(!!(x), 1)
^
4 warnings generated.
/tmp/trackpoint-558911.s: Assembler messages:
>> /tmp/trackpoint-558911.s:421: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
/tmp/trackpoint-558911.s:431: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 1/3] mfd: ahc1ec0: Add support for Advantech embedded controller
by kernel test robot
Hi Shihlun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on linux/master v5.9]
[cannot apply to lee-mfd/for-mfd-next next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shihlun-Lin/mfd-ahc1ec0-Add-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b5fc7a89e58bcc059a3d5e4db79c481fb437de59
config: parisc-randconfig-r003-20201014 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f939b81446bccbb73682a795ea5422386...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
git checkout f939b81446bccbb73682a795ea5422386d6b15bb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/mfd/ahc1ec0.c:71:5: warning: no previous prototype for 'wait_ibf' [-Wmissing-prototypes]
71 | int wait_ibf(void)
| ^~~~~~~~
>> drivers/mfd/ahc1ec0.c:86:5: warning: no previous prototype for 'wait_obf' [-Wmissing-prototypes]
86 | int wait_obf(void)
| ^~~~~~~~
>> drivers/mfd/ahc1ec0.c:101:5: warning: no previous prototype for 'read_hw_ram' [-Wmissing-prototypes]
101 | int read_hw_ram(uchar addr, uchar *data)
| ^~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:182:5: warning: no previous prototype for 'wait_smbus_protocol_finish' [-Wmissing-prototypes]
182 | int wait_smbus_protocol_finish(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:203:5: warning: no previous prototype for 'adv_get_dynamic_tab' [-Wmissing-prototypes]
203 | int adv_get_dynamic_tab(struct adv_ec_platform_data *pdata)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:409:5: warning: no previous prototype for 'write_acpi_value' [-Wmissing-prototypes]
409 | int write_acpi_value(uchar addr, uchar value)
| ^~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:442:5: warning: no previous prototype for 'read_gpio_status' [-Wmissing-prototypes]
442 | int read_gpio_status(uchar PinNumber, uchar *pvalue)
| ^~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:493:5: warning: no previous prototype for 'write_gpio_status' [-Wmissing-prototypes]
493 | int write_gpio_status(uchar PinNumber, uchar value)
| ^~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:538:5: warning: no previous prototype for 'read_gpio_dir' [-Wmissing-prototypes]
538 | int read_gpio_dir(uchar PinNumber, uchar *pvalue)
| ^~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:585:5: warning: no previous prototype for 'write_gpio_dir' [-Wmissing-prototypes]
585 | int write_gpio_dir(uchar PinNumber, uchar value)
| ^~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:631:5: warning: no previous prototype for 'write_hw_extend_ram' [-Wmissing-prototypes]
631 | int write_hw_extend_ram(uchar addr, uchar data)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:866:5: warning: no previous prototype for 'smbus_write_byte' [-Wmissing-prototypes]
866 | int smbus_write_byte(struct EC_SMBUS_WRITE_BYTE *ptr_ec_smbus_write_byte)
| ^~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:946:5: warning: no previous prototype for 'read_onekey_status' [-Wmissing-prototypes]
946 | int read_onekey_status(uchar addr, uchar *pdata)
| ^~~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:990:5: warning: no previous prototype for 'write_onekey_status' [-Wmissing-prototypes]
990 | int write_onekey_status(uchar addr)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:1024:5: warning: no previous prototype for 'ec_oem_get_status' [-Wmissing-prototypes]
1024 | int ec_oem_get_status(uchar addr, uchar *pdata)
| ^~~~~~~~~~~~~~~~~
>> drivers/mfd/ahc1ec0.c:1076:5: warning: no previous prototype for 'ec_oem_set_status' [-Wmissing-prototypes]
1076 | int ec_oem_set_status(uchar addr, uchar pdata)
| ^~~~~~~~~~~~~~~~~
drivers/mfd/ahc1ec0.c: In function 'adv_ec_get_productname':
>> drivers/mfd/ahc1ec0.c:1167:13: error: implicit declaration of function 'ioremap_cache'; did you mean 'ioremap_uc'? [-Werror=implicit-function-declaration]
1167 | (char *)ioremap_cache(((unsigned int *)&uc_ptaddr[index+0x18])[0],
| ^~~~~~~~~~~~~
| ioremap_uc
At top level:
drivers/mfd/ahc1ec0.c:1244:30: warning: 'adv_ec_util_cells' defined but not used [-Wunused-const-variable=]
1244 | static const struct mfd_cell adv_ec_util_cells[] = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +1167 drivers/mfd/ahc1ec0.c
988
989 /* Set One Key Recovery status */
> 990 int write_onekey_status(uchar addr)
991 {
992 int ret;
993
994 mutex_lock(&lock);
995
996 /* Step 0. Wait IBF clear */
997 ret = wait_ibf();
998 if (ret)
999 goto error;
1000
1001 /* Step 1. Send "One Key Recovery" command to EC Command port */
1002 outb(EC_ONE_KEY_FLAG, EC_COMMAND_PORT);
1003
1004 /* Step 2. Wait IBF clear */
1005 ret = wait_ibf();
1006 if (ret)
1007 goto error;
1008
1009 /* Step 3. Send "One Key Recovery function" address to EC Data port */
1010 outb(addr, EC_STATUS_PORT);
1011
1012 mutex_unlock(&lock);
1013
1014 pr_debug("%s: addr= %d, line: %d", __func__, addr, __LINE__);
1015 return 0;
1016
1017 error:
1018 mutex_unlock(&lock);
1019 pr_debug("%s: Wait for IBF too long. line: %d", __func__, __LINE__);
1020 return ret;
1021 }
1022
1023 /* EC OEM get status */
> 1024 int ec_oem_get_status(uchar addr, uchar *pdata)
1025 {
1026 int ret;
1027
1028 mutex_lock(&lock);
1029
1030 /* Init return value */
1031 *pdata = 0;
1032
1033 /* Step 0. Wait IBF clear */
1034 ret = wait_ibf();
1035 if (ret)
1036 goto error;
1037
1038 /* Step 1. Send "ASG OEM" command to EC Command port */
1039 outb(EC_ASG_OEM, EC_COMMAND_PORT);
1040
1041 /* Step 2. Wait IBF clear */
1042 ret = wait_ibf();
1043 if (ret)
1044 goto error;
1045
1046 /* Step 3. Send "ASG OEM STATUS READ" address to EC Data port */
1047 outb(EC_ASG_OEM_READ, EC_STATUS_PORT);
1048
1049 /* Step 4. Wait IBF clear */
1050 ret = wait_ibf();
1051 if (ret)
1052 goto error;
1053
1054 /* Step 5. Send "OEM STATUS" address to EC Data port */
1055 outb(addr, EC_STATUS_PORT);
1056
1057 /* Step 6. Wait OBF set */
1058 ret = wait_obf();
1059 if (ret)
1060 goto error;
1061
1062 /* Step 7. Get "OEM STATUS" data from EC Data port */
1063 *pdata = inb(EC_STATUS_PORT);
1064
1065 pr_debug("%s: data= %d, line: %d", __func__, *pdata, __LINE__);
1066 mutex_unlock(&lock);
1067 return 0;
1068
1069 error:
1070 mutex_unlock(&lock);
1071 pr_warn("%s: Wait for IBF or OBF too long. line: %d", __func__, __LINE__);
1072 return ret;
1073 }
1074
1075 /* EC OEM set status */
> 1076 int ec_oem_set_status(uchar addr, uchar pdata)
1077 {
1078 int ret;
1079
1080 mutex_lock(&lock);
1081
1082 /* Step 0. Wait IBF clear */
1083 ret = wait_ibf();
1084 if (ret)
1085 goto error;
1086
1087 /* Step 1. Send "ASG OEM" command to EC Command port */
1088 outb(EC_ASG_OEM, EC_COMMAND_PORT);
1089
1090 /* Step 2. Wait IBF clear */
1091 ret = wait_ibf();
1092 if (ret)
1093 goto error;
1094
1095 /* Step 3. Send "ASG OEM STATUS WRITE" address to EC Data port */
1096 outb(EC_ASG_OEM_WRITE, EC_STATUS_PORT);
1097
1098 /* Step 4. Wait IBF clear */
1099 ret = wait_ibf();
1100 if (ret)
1101 goto error;
1102
1103 /* Step 5. Send "OEM STATUS" address to EC Data port */
1104 outb(addr, EC_STATUS_PORT);
1105
1106 /* Step 6. Wait IBF clear */
1107 ret = wait_ibf();
1108 if (ret)
1109 goto error;
1110
1111 /* Step 7. Send "OEM STATUS" status to EC Data port */
1112 outb(pdata, EC_STATUS_PORT);
1113
1114 pr_debug("%s: data= %d, line: %d", __func__, pdata, __LINE__);
1115 mutex_unlock(&lock);
1116 return 0;
1117
1118 error:
1119 mutex_unlock(&lock);
1120 pr_warn("%s: Wait for IBF or OBF too long. line: %d", __func__, __LINE__);
1121
1122 return ret;
1123 }
1124
1125 static int adv_ec_get_productname(char *product)
1126 {
1127 static unsigned char *uc_ptaddr;
1128 static unsigned char *uc_epsaddr;
1129 int index = 0, eps_table;
1130 int i = 0;
1131 int length = 0;
1132 int type0_str = 0;
1133 int type1_str = 0;
1134 int is_advantech = 0;
1135
1136 uc_ptaddr = ioremap(AMI_UEFI_ADVANTECH_BOARD_NAME_ADDRESS,
1137 AMI_UEFI_ADVANTECH_BOARD_NAME_LENGTH);
1138 if (!uc_ptaddr) {
1139 pr_err("Error: ioremap_nocache()");
1140 return -ENXIO;
1141 }
1142
1143 /* Try to Read the product name from UEFI BIOS(DMI) EPS table */
1144 for (index = 0; index < AMI_UEFI_ADVANTECH_BOARD_NAME_LENGTH; index++) {
1145 if (uc_ptaddr[index] == '_'
1146 && uc_ptaddr[index+0x1] == 'S'
1147 && uc_ptaddr[index+0x2] == 'M'
1148 && uc_ptaddr[index+0x3] == '_'
1149 && uc_ptaddr[index+0x10] == '_'
1150 && uc_ptaddr[index+0x11] == 'D'
1151 && uc_ptaddr[index+0x12] == 'M'
1152 && uc_ptaddr[index+0x13] == 'I'
1153 && uc_ptaddr[index+0x14] == '_'
1154 ) {
1155 eps_table = 1;
1156 break;
1157 }
1158 }
1159
1160 /* If EPS table exist, read type1(system information) */
1161 if (eps_table) {
1162 uc_epsaddr =
1163 (char *)ioremap(((unsigned int *)&uc_ptaddr[index+0x18])[0],
1164 ((unsigned short *)&uc_ptaddr[index+0x16])[0]);
1165 if (!uc_epsaddr) {
1166 uc_epsaddr =
> 1167 (char *)ioremap_cache(((unsigned int *)&uc_ptaddr[index+0x18])[0],
1168 ((unsigned short *)&uc_ptaddr[index+0x16])[0]);
1169 if (!uc_epsaddr) {
1170 pr_err("Error: both ioremap() and ioremap_cache() exec failed!");
1171 return -ENXIO;
1172 }
1173 }
1174
1175 type0_str = (int)uc_epsaddr[1];
1176 for (i = type0_str; i < (type0_str+512); i++) {
1177 if (uc_epsaddr[i] == 0 && uc_epsaddr[i+1] == 0 && uc_epsaddr[i+2] == 1) {
1178 type1_str = i + uc_epsaddr[i+3];
1179 break;
1180 }
1181 }
1182 for (i = type1_str; i < (type1_str+512); i++) {
1183 if (!strncmp(&uc_epsaddr[i], "Advantech", 9))
1184 is_advantech = 1;
1185
1186 if (uc_epsaddr[i] == 0) {
1187 i++;
1188 type1_str = i;
1189 break;
1190 }
1191 }
1192 length = 2;
1193 while ((uc_epsaddr[type1_str + length] != 0)
1194 && (length < AMI_UEFI_ADVANTECH_BOARD_NAME_LENGTH)) {
1195 length += 1;
1196 }
1197 memmove(product, &uc_epsaddr[type1_str], length);
1198 iounmap((void *)uc_epsaddr);
1199 if (is_advantech) {
1200 iounmap((void *)uc_ptaddr);
1201 return 0;
1202 }
1203 }
1204
1205 /* It is an old BIOS, read from 0x000F0000 */
1206 for (index = 0; index < (AMI_UEFI_ADVANTECH_BOARD_NAME_LENGTH - 3); index++) {
1207 if (!strncmp(&uc_ptaddr[index], "TPC", 3)
1208 || !strncmp(&uc_ptaddr[index], "UNO", 3)
1209 || !strncmp(&uc_ptaddr[index], "ITA", 3)
1210 || !strncmp(&uc_ptaddr[index], "MIO", 3)
1211 || !strncmp(&uc_ptaddr[index], "ECU", 3)
1212 || !strncmp(&uc_ptaddr[index], "APAX", 4))
1213 break;
1214 }
1215
1216 if (index == (AMI_UEFI_ADVANTECH_BOARD_NAME_LENGTH - 3)) {
1217 pr_err("%s: Can't find the product name, line: %d", __func__, __LINE__);
1218 product[0] = '\0';
1219 iounmap((void *)uc_ptaddr);
1220 return -ENODATA;
1221 }
1222
1223 /* Use char "Space" (ASCII code: 32) to check the end of the Product Name. */
1224 for (i = 0; (uc_ptaddr[index+i] != 32) && (i < 31); i++)
1225 product[i] = uc_ptaddr[index+i];
1226
1227 product[i] = '\0';
1228 pr_info("%s: BIOS Product Name = %s, line: %d", __func__, product, __LINE__);
1229
1230 iounmap((void *)uc_ptaddr);
1231
1232 return 0;
1233 }
1234
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [patch 4/4] media: cx231xx: Consolidate dmesg output
by kernel test robot
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on linus/master linux/master v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Gleixner/media-Cleanup-in...
base: git://linuxtv.org/media_tree.git master
config: microblaze-randconfig-r004-20201014 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/703daca167ddea5ab71b9547b549c1c14...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Gleixner/media-Cleanup-in_interrupt-usage/20201013-224011
git checkout 703daca167ddea5ab71b9547b549c1c1499f2bf4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/acpi.h:15,
from include/linux/i2c.h:13,
from drivers/media/usb/cx231xx/cx231xx.h:16,
from drivers/media/usb/cx231xx/cx231xx-vbi.c:10:
drivers/media/usb/cx231xx/cx231xx-vbi.c: In function 'cx231xx_init_vbi_isoc':
>> drivers/media/usb/cx231xx/cx231xx-vbi.c:411:5: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
411 | "unable to allocate %i bytes for transfer buffer %i%s\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/media/usb/cx231xx/cx231xx-vbi.c:410:4: note: in expansion of macro 'dev_err'
410 | dev_err(dev->dev,
| ^~~~~~~
drivers/media/usb/cx231xx/cx231xx-vbi.c:411:57: note: format string is defined here
411 | "unable to allocate %i bytes for transfer buffer %i%s\n",
| ~^
| |
| char *
vim +411 drivers/media/usb/cx231xx/cx231xx-vbi.c
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 336
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 337 /*
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 338 * Allocate URBs and start IRQ
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 339 */
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 340 int cx231xx_init_vbi_isoc(struct cx231xx *dev, int max_packets,
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 341 int num_bufs, int max_pkt_size,
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 342 int (*bulk_copy) (struct cx231xx *dev,
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 343 struct urb *urb))
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 344 {
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 345 struct cx231xx_dmaqueue *dma_q = &dev->vbi_mode.vidq;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 346 int i;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 347 int sb_size, pipe;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 348 struct urb *urb;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 349 int rc;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 350
336fea922936c11 drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-03 351 dev_dbg(dev->dev, "called cx231xx_vbi_isoc\n");
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 352
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 353 /* De-allocates all pending stuff */
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 354 cx231xx_uninit_vbi_isoc(dev);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 355
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 356 /* clear if any halt */
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 357 usb_clear_halt(dev->udev,
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 358 usb_rcvbulkpipe(dev->udev,
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 359 dev->vbi_mode.end_point_addr));
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 360
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 361 dev->vbi_mode.bulk_ctl.bulk_copy = bulk_copy;
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 362 dev->vbi_mode.bulk_ctl.num_bufs = num_bufs;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 363 dma_q->pos = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 364 dma_q->is_partial_line = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 365 dma_q->last_sav = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 366 dma_q->current_field = -1;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 367 dma_q->bytes_left_in_line = dev->width << 1;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 368 dma_q->lines_per_field = ((dev->norm & V4L2_STD_625_50) ?
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 369 PAL_VBI_LINES : NTSC_VBI_LINES);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 370 dma_q->lines_completed = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 371 for (i = 0; i < 8; i++)
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 372 dma_q->partial_buf[i] = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 373
6396bb221514d28 drivers/media/usb/cx231xx/cx231xx-vbi.c Kees Cook 2018-06-12 374 dev->vbi_mode.bulk_ctl.urb = kcalloc(num_bufs, sizeof(void *),
cde4362f0244a70 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 375 GFP_KERNEL);
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 376 if (!dev->vbi_mode.bulk_ctl.urb) {
336fea922936c11 drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-03 377 dev_err(dev->dev,
b7085c08647598a drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-02 378 "cannot alloc memory for usb buffers\n");
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 379 return -ENOMEM;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 380 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 381
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 382 dev->vbi_mode.bulk_ctl.transfer_buffer =
6396bb221514d28 drivers/media/usb/cx231xx/cx231xx-vbi.c Kees Cook 2018-06-12 383 kcalloc(num_bufs, sizeof(void *), GFP_KERNEL);
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 384 if (!dev->vbi_mode.bulk_ctl.transfer_buffer) {
336fea922936c11 drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-03 385 dev_err(dev->dev,
b7085c08647598a drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-02 386 "cannot allocate memory for usbtransfer\n");
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 387 kfree(dev->vbi_mode.bulk_ctl.urb);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 388 return -ENOMEM;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 389 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 390
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 391 dev->vbi_mode.bulk_ctl.max_pkt_size = max_pkt_size;
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 392 dev->vbi_mode.bulk_ctl.buf = NULL;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 393
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 394 sb_size = max_packets * dev->vbi_mode.bulk_ctl.max_pkt_size;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 395
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 396 /* allocate urbs and transfer buffers */
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 397 for (i = 0; i < dev->vbi_mode.bulk_ctl.num_bufs; i++) {
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 398
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 399 urb = usb_alloc_urb(0, GFP_KERNEL);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 400 if (!urb) {
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 401 cx231xx_uninit_vbi_isoc(dev);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 402 return -ENOMEM;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 403 }
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 404 dev->vbi_mode.bulk_ctl.urb[i] = urb;
cd5534be6bc681d drivers/media/video/cx231xx/cx231xx-vbi.c David Dillow 2012-06-18 405 urb->transfer_flags = 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 406
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 407 dev->vbi_mode.bulk_ctl.transfer_buffer[i] =
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 408 kzalloc(sb_size, GFP_KERNEL);
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 409 if (!dev->vbi_mode.bulk_ctl.transfer_buffer[i]) {
336fea922936c11 drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-03 410 dev_err(dev->dev,
b7085c08647598a drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-02 @411 "unable to allocate %i bytes for transfer buffer %i%s\n",
703daca167ddea5 drivers/media/usb/cx231xx/cx231xx-vbi.c Thomas Gleixner 2020-10-13 412 sb_size, i);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 413 cx231xx_uninit_vbi_isoc(dev);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 414 return -ENOMEM;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 415 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 416
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 417 pipe = usb_rcvbulkpipe(dev->udev, dev->vbi_mode.end_point_addr);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 418 usb_fill_bulk_urb(urb, dev->udev, pipe,
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 419 dev->vbi_mode.bulk_ctl.transfer_buffer[i],
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 420 sb_size, cx231xx_irq_vbi_callback, dma_q);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 421 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 422
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 423 init_waitqueue_head(&dma_q->wq);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 424
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 425 /* submit urbs and enables IRQ */
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 426 for (i = 0; i < dev->vbi_mode.bulk_ctl.num_bufs; i++) {
64fbf4445526068 drivers/media/video/cx231xx/cx231xx-vbi.c Palash Bandyopadhyay 2010-07-06 427 rc = usb_submit_urb(dev->vbi_mode.bulk_ctl.urb[i], GFP_ATOMIC);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 428 if (rc) {
336fea922936c11 drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-03 429 dev_err(dev->dev,
b7085c08647598a drivers/media/usb/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2014-11-02 430 "submit of urb %i failed (error=%i)\n", i, rc);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 431 cx231xx_uninit_vbi_isoc(dev);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 432 return rc;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 433 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 434 }
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 435
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 436 cx231xx_capture_start(dev, 1, Vbi);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 437
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 438 return 0;
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 439 }
84b5dbf39ed2f51 drivers/media/video/cx231xx/cx231xx-vbi.c Mauro Carvalho Chehab 2009-03-03 440 EXPORT_SYMBOL_GPL(cx231xx_init_vbi_isoc);
e0d3bafd02586cf drivers/media/video/cx231xx/cx231xx-vbi.c Sri Deevi 2009-03-03 441
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 2/3] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller
by kernel test robot
Hi Shihlun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.9]
[cannot apply to lee-mfd/for-mfd-next next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shihlun-Lin/mfd-ahc1ec0-Add-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b5fc7a89e58bcc059a3d5e4db79c481fb437de59
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/ac7622765e9bf99891a911be7a47e27b5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
git checkout ac7622765e9bf99891a911be7a47e27b5afe3a35
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/mfd/ahc1ec0-hwmon.c:1280:6: warning: no previous prototype for 'adv_ec_init_hwmon_profile' [-Wmissing-prototypes]
1280 | void adv_ec_init_hwmon_profile(u32 profile, struct adv_ec_platform_data *plat_data)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/adv_ec_init_hwmon_profile +1280 drivers/mfd/ahc1ec0-hwmon.c
1279
> 1280 void adv_ec_init_hwmon_profile(u32 profile, struct adv_ec_platform_data *plat_data)
1281 {
1282 int i;
1283 struct HW_PIN_TBL *ptbl = &lmsensor_data.pin_tbl;
1284 struct Dynamic_Tab *dym_tbl = plat_data->dym_tbl;
1285
1286 lmsensor_data.bios_product_name = plat_data->bios_product_name;
1287 lmsensor_data.profile = &advec_profile[profile];
1288
1289 for (i = 0; i < EC_MAX_TBL_NUM ; i++) {
1290 switch (dym_tbl[i].DeviceID) {
1291 case EC_DID_CMOSBAT:
1292 ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
1293 ptbl->vbat[1] = 1;
1294 break;
1295 case EC_DID_CMOSBAT_X2:
1296 ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
1297 ptbl->vbat[1] = 2;
1298 break;
1299 case EC_DID_CMOSBAT_X10:
1300 ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
1301 ptbl->vbat[1] = 10;
1302 break;
1303 case EC_DID_5VS0:
1304 case EC_DID_5VS5:
1305 ptbl->v5[0] = dym_tbl[i].HWPinNumber;
1306 ptbl->v5[1] = 1;
1307 break;
1308 case EC_DID_5VS0_X2:
1309 case EC_DID_5VS5_X2:
1310 ptbl->v5[0] = dym_tbl[i].HWPinNumber;
1311 ptbl->v5[1] = 2;
1312 break;
1313 case EC_DID_5VS0_X10:
1314 case EC_DID_5VS5_X10:
1315 ptbl->v5[0] = dym_tbl[i].HWPinNumber;
1316 ptbl->v5[1] = 10;
1317 break;
1318 case EC_DID_12VS0:
1319 ptbl->v12[0] = dym_tbl[i].HWPinNumber;
1320 ptbl->v12[1] = 1;
1321 break;
1322 case EC_DID_12VS0_X2:
1323 ptbl->v12[0] = dym_tbl[i].HWPinNumber;
1324 ptbl->v12[1] = 2;
1325 break;
1326 case EC_DID_12VS0_X10:
1327 ptbl->v12[0] = dym_tbl[i].HWPinNumber;
1328 ptbl->v12[1] = 10;
1329 break;
1330 case EC_DID_VCOREA:
1331 case EC_DID_VCOREB:
1332 ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
1333 ptbl->vcore[1] = 1;
1334 break;
1335 case EC_DID_VCOREA_X2:
1336 case EC_DID_VCOREB_X2:
1337 ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
1338 ptbl->vcore[1] = 2;
1339 break;
1340 case EC_DID_VCOREA_X10:
1341 case EC_DID_VCOREB_X10:
1342 ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
1343 ptbl->vcore[1] = 10;
1344 break;
1345 case EC_DID_DC:
1346 ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
1347 ptbl->vdc[1] = 1;
1348 break;
1349 case EC_DID_DC_X2:
1350 ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
1351 ptbl->vdc[1] = 2;
1352 break;
1353 case EC_DID_DC_X10:
1354 ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
1355 ptbl->vdc[1] = 10;
1356 break;
1357 case EC_DID_CURRENT:
1358 ptbl->ec_current[0] = dym_tbl[i].HWPinNumber;
1359 ptbl->ec_current[1] = 1;
1360 break;
1361 case EC_DID_SMBOEM0:
1362 lmsensor_data.ec_smboem0.HWPinNumber = dym_tbl[i].HWPinNumber;
1363 break;
1364 default:
1365 break;
1366 }
1367 }
1368 }
1369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH v5 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling
by kernel test robot
Hi Kuppuswamy,
I love your patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on v5.9]
[cannot apply to next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kuppuswamy-Sathyanarayanan/PCI-E...
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a004-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7fe3c6dfede8d5781bd000741c3dea7088307a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/7c892978aa57817ac512ea311d0d87dd6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kuppuswamy-Sathyanarayanan/PCI-ERR-Call-pci_bus_reset-before-calling-slot_reset-callback/20201014-172736
git checkout 7c892978aa57817ac512ea311d0d87dd6e1ced80
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/pcie/err.c:144:25: error: static declaration of 'pcie_do_fatal_recovery' follows non-static declaration
static pci_ers_result_t pcie_do_fatal_recovery(struct pci_dev *dev,
^
drivers/pci/pcie/../pci.h:559:18: note: previous declaration is here
pci_ers_result_t pcie_do_fatal_recovery(struct pci_dev *dev,
^
1 error generated.
vim +/pcie_do_fatal_recovery +144 drivers/pci/pcie/err.c
143
> 144 static pci_ers_result_t pcie_do_fatal_recovery(struct pci_dev *dev,
145 pci_ers_result_t (*reset_link)(struct pci_dev *pdev))
146 {
147 struct pci_dev *udev;
148 struct pci_bus *parent;
149 struct pci_dev *pdev, *temp;
150 pci_ers_result_t result;
151
152 if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
153 udev = dev;
154 else
155 udev = dev->bus->self;
156
157 parent = udev->subordinate;
158 pci_walk_bus(parent, pci_dev_set_disconnected, NULL);
159
160 pci_lock_rescan_remove();
161 pci_dev_get(dev);
162 list_for_each_entry_safe_reverse(pdev, temp, &parent->devices,
163 bus_list) {
164 pci_stop_and_remove_bus_device(pdev);
165 }
166
167 result = reset_link(udev);
168
169 if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
170 /*
171 * If the error is reported by a bridge, we think this error
172 * is related to the downstream link of the bridge, so we
173 * do error recovery on all subordinates of the bridge instead
174 * of the bridge and clear the error status of the bridge.
175 */
176 pci_aer_clear_fatal_status(dev);
177 if (pcie_aer_is_native(dev))
178 pcie_clear_device_status(dev);
179 }
180
181 if (result == PCI_ERS_RESULT_RECOVERED) {
182 if (pcie_wait_for_link(udev, true))
183 pci_rescan_bus(udev->bus);
184 pci_info(dev, "Device recovery from fatal error successful\n");
185 } else {
186 pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
187 pci_info(dev, "Device recovery from fatal error failed\n");
188 }
189
190 pci_dev_put(dev);
191 pci_unlock_rescan_remove();
192
193 return result;
194 }
195
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months