[kbuild] Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption
by Dan Carpenter
Hi Daniel,
url: https://github.com/0day-ci/linux/commits/Daniel-Rosenberg/Add-support-for...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> fs/f2fs/dir.c:206:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
dentry_page = ERR_CAST(res);
^
fs/f2fs/f2fs.h:2200:15: warning: Local variable valid_node_count shadows outer function [shadowFunction]
unsigned int valid_node_count, user_block_count;
^
fs/f2fs/f2fs.h:2296:28: note: Shadowed declaration
static inline unsigned int valid_node_count(struct f2fs_sb_info *sbi)
^
fs/f2fs/f2fs.h:2200:15: note: Shadow variable
unsigned int valid_node_count, user_block_count;
^
vim +206 fs/f2fs/dir.c
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 192 static struct f2fs_dir_entry *find_in_block(struct inode *dir,
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 193 struct page *dentry_page,
43c780ba26244e4 Eric Biggers 2020-05-07 194 const struct f2fs_filename *fname,
17f930e0a649e15 Chao Yu 2020-09-26 195 int *max_slots)
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 196 {
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 197 struct f2fs_dentry_block *dentry_blk;
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 198 struct f2fs_dentry_ptr d;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 199 struct f2fs_dir_entry *res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 200
bdbc90fa55af632 Yunlong Song 2018-02-28 201 dentry_blk = (struct f2fs_dentry_block *)page_address(dentry_page);
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 202
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 203 make_dentry_ptr_block(dir, &d, dentry_blk);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 204 res = f2fs_find_target_dentry(&d, fname, max_slots);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 205 if (IS_ERR(res)) {
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 @206 dentry_page = ERR_CAST(res);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 207 res = NULL;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 208 }
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 209 return res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 210 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
1 year, 10 months
[linux-stable-rc:linux-5.4.y 1166/3868] drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: sparse: incorrect type in argument 1 (different base types)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
head: e72abf1f11a982a2a3fb555b5a9bd2eb2011dee8
commit: 99a1bdf6ae39501f5678c29bff6cb80906227519 [1166/3868] scsi: qla2xxx: Use explicit LOGO in target mode
config: xtensa-randconfig-s032-20201116 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-107-gaf3512a6-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi...
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-5.4.y
git checkout 99a1bdf6ae39501f5678c29bff6cb80906227519
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
drivers/scsi/qla2xxx/qla_iocb.c:2494:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] timeout @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2494:22: sparse: expected unsigned short [usertype] timeout
drivers/scsi/qla2xxx/qla_iocb.c:2494:22: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2495:28: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] control_flags @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2495:28: sparse: expected unsigned int [usertype] control_flags
drivers/scsi/qla2xxx/qla_iocb.c:2495:28: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2657:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2657:32: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:2657:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2893:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2893:32: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:2893:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2894:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] tx_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2894:32: sparse: expected unsigned short [usertype] tx_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:2894:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2897:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] rx_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2897:32: sparse: expected unsigned short [usertype] rx_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:2897:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2942:9: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] extended @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2942:9: sparse: expected unsigned short [usertype] extended
drivers/scsi/qla2xxx/qla_iocb.c:2942:9: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2943:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] status @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2943:25: sparse: expected unsigned short [usertype] status
drivers/scsi/qla2xxx/qla_iocb.c:2943:25: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2944:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] control_flags @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2944:32: sparse: expected unsigned short [usertype] control_flags
drivers/scsi/qla2xxx/qla_iocb.c:2944:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2946:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] cmd_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2946:32: sparse: expected unsigned short [usertype] cmd_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:2946:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2948:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] total_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2948:34: sparse: expected unsigned short [usertype] total_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:2948:34: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2950:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] req_bytecount @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2950:32: sparse: expected unsigned int [usertype] req_bytecount
drivers/scsi/qla2xxx/qla_iocb.c:2950:32: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2952:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] rsp_bytecount @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:2952:32: sparse: expected unsigned int [usertype] rsp_bytecount
drivers/scsi/qla2xxx/qla_iocb.c:2952:32: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:2957:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] length @@ got unsigned int [usertype] req_bytecount @@
drivers/scsi/qla2xxx/qla_iocb.c:2957:33: sparse: expected restricted __le32 [usertype] length
drivers/scsi/qla2xxx/qla_iocb.c:2957:33: sparse: got unsigned int [usertype] req_bytecount
drivers/scsi/qla2xxx/qla_iocb.c:2961:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] length @@ got unsigned int [usertype] rsp_bytecount @@
drivers/scsi/qla2xxx/qla_iocb.c:2961:33: sparse: expected restricted __le32 [usertype] length
drivers/scsi/qla2xxx/qla_iocb.c:2961:33: sparse: got unsigned int [usertype] rsp_bytecount
drivers/scsi/qla2xxx/qla_iocb.c:3011:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3011:31: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:3011:31: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3013:30: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] comp_status @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3013:30: sparse: expected unsigned short [usertype] comp_status
drivers/scsi/qla2xxx/qla_iocb.c:3013:30: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3018:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] cmd_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3018:32: sparse: expected unsigned short [usertype] cmd_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:3018:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3020:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] rsp_dsd_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3020:32: sparse: expected unsigned short [usertype] rsp_dsd_count
drivers/scsi/qla2xxx/qla_iocb.c:3020:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3021:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] cmd_byte_count @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3021:33: sparse: expected unsigned int [usertype] cmd_byte_count
drivers/scsi/qla2xxx/qla_iocb.c:3021:33: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3237:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] dseg_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3237:37: sparse: expected unsigned short [usertype] dseg_count
drivers/scsi/qla2xxx/qla_iocb.c:3237:37: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3240:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3240:39: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:3240:39: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3271:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] @@ got restricted __be32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3271:25: sparse: expected unsigned int [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3271:25: sparse: got restricted __be32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3273:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] fcp_cmnd_dseg_len @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3273:44: sparse: expected unsigned short [usertype] fcp_cmnd_dseg_len
drivers/scsi/qla2xxx/qla_iocb.c:3273:44: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3278:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] byte_count @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3278:37: sparse: expected unsigned int [usertype] byte_count
drivers/scsi/qla2xxx/qla_iocb.c:3278:37: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3308:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] dseg_count @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3308:37: sparse: expected unsigned short [usertype] dseg_count
drivers/scsi/qla2xxx/qla_iocb.c:3308:37: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3311:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3311:39: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:3311:39: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3329:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] byte_count @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3329:37: sparse: expected unsigned int [usertype] byte_count
drivers/scsi/qla2xxx/qla_iocb.c:3329:37: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3407:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] handle @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3407:26: sparse: expected unsigned int [usertype] handle
drivers/scsi/qla2xxx/qla_iocb.c:3407:26: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3409:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] nport_handle @@ got restricted __le16 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3409:40: sparse: expected unsigned short [usertype] nport_handle
drivers/scsi/qla2xxx/qla_iocb.c:3409:40: sparse: got restricted __le16 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3415:13: sparse: sparse: cast from restricted __le16
drivers/scsi/qla2xxx/qla_iocb.c:3414:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] handle_to_abort @@ got restricted __le32 [usertype] @@
drivers/scsi/qla2xxx/qla_iocb.c:3414:35: sparse: expected unsigned int [usertype] handle_to_abort
drivers/scsi/qla2xxx/qla_iocb.c:3414:35: sparse: got restricted __le32 [usertype]
drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: sparse: cast from restricted __le16
>> drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __le16 [usertype] req_que_no @@
>> drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: expected unsigned short [usertype] val
drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: got restricted __le16 [usertype] req_que_no
drivers/scsi/qla2xxx/qla_iocb.c:3418:32: sparse: sparse: too many warnings
vim +3418 drivers/scsi/qla2xxx/qla_iocb.c
5162cf0c4e3962b Giridhar Malavali 2011-11-18 3396
6d78e5576b9450a Joe Carnuccio 2014-09-25 3397 static void
4440e46d5db7b44 Armen Baloyan 2014-02-26 3398 qla24xx_abort_iocb(srb_t *sp, struct abort_entry_24xx *abt_iocb)
4440e46d5db7b44 Armen Baloyan 2014-02-26 3399 {
4440e46d5db7b44 Armen Baloyan 2014-02-26 3400 struct srb_iocb *aio = &sp->u.iocb_cmd;
25ff6af10562cfe Joe Carnuccio 2017-01-19 3401 scsi_qla_host_t *vha = sp->vha;
49cecca7dd49e29 Quinn Tran 2018-08-31 3402 struct req_que *req = sp->qpair->req;
4440e46d5db7b44 Armen Baloyan 2014-02-26 3403
4440e46d5db7b44 Armen Baloyan 2014-02-26 3404 memset(abt_iocb, 0, sizeof(struct abort_entry_24xx));
4440e46d5db7b44 Armen Baloyan 2014-02-26 3405 abt_iocb->entry_type = ABORT_IOCB_TYPE;
4440e46d5db7b44 Armen Baloyan 2014-02-26 3406 abt_iocb->entry_count = 1;
f3767225021a48f Himanshu Madhani 2018-02-01 3407 abt_iocb->handle = cpu_to_le32(MAKE_HANDLE(req->id, sp->handle));
49cecca7dd49e29 Quinn Tran 2018-08-31 3408 if (sp->fcport) {
4440e46d5db7b44 Armen Baloyan 2014-02-26 3409 abt_iocb->nport_handle = cpu_to_le16(sp->fcport->loop_id);
4440e46d5db7b44 Armen Baloyan 2014-02-26 3410 abt_iocb->port_id[0] = sp->fcport->d_id.b.al_pa;
4440e46d5db7b44 Armen Baloyan 2014-02-26 3411 abt_iocb->port_id[1] = sp->fcport->d_id.b.area;
4440e46d5db7b44 Armen Baloyan 2014-02-26 3412 abt_iocb->port_id[2] = sp->fcport->d_id.b.domain;
49cecca7dd49e29 Quinn Tran 2018-08-31 3413 }
49cecca7dd49e29 Quinn Tran 2018-08-31 3414 abt_iocb->handle_to_abort =
49cecca7dd49e29 Quinn Tran 2018-08-31 3415 cpu_to_le32(MAKE_HANDLE(aio->u.abt.req_que_no,
49cecca7dd49e29 Quinn Tran 2018-08-31 3416 aio->u.abt.cmd_hndl));
4440e46d5db7b44 Armen Baloyan 2014-02-26 3417 abt_iocb->vp_index = vha->vp_idx;
b027a5ace443f4f Darren Trapp 2018-01-15 @3418 abt_iocb->req_que_no = cpu_to_le16(aio->u.abt.req_que_no);
4440e46d5db7b44 Armen Baloyan 2014-02-26 3419 /* Send the command to the firmware */
4440e46d5db7b44 Armen Baloyan 2014-02-26 3420 wmb();
4440e46d5db7b44 Armen Baloyan 2014-02-26 3421 }
4440e46d5db7b44 Armen Baloyan 2014-02-26 3422
:::::: The code at line 3418 was first introduced by commit
:::::: b027a5ace443f4f1eb58648ab236025b7b0f6df9 scsi: qla2xxx: Fix queue ID for async abort with Multiqueue
:::::: TO: Darren Trapp <darren.trapp(a)cavium.com>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[linux-next:master 1015/6320] drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
by kernel test robot
Hi Samuel,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7c8ca8129ee9724cb1527895fe6dec942ef07f19
commit: 3952ec2ac55a5afcda84270fa203f17a6309af6b [1015/6320] ASoC: sun8i-codec: Protect the clock rate while streams are open
config: m68k-randconfig-r004-20201117 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 3952ec2ac55a5afcda84270fa203f17a6309af6b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
855 | void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:263:20: note: previous definition of 'clk_unprepare' was here
263 | static inline void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
>> drivers/clk/clk.c:936:5: error: redefinition of 'clk_prepare'
936 | int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:236:19: note: previous definition of 'clk_prepare' was here
236 | static inline int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
vim +/clk_unprepare +855 drivers/clk/clk.c
a6adc30ba7bef8d Dong Aisheng 2016-06-30 843
4dff95dc9477a34 Stephen Boyd 2015-04-30 844 /**
4dff95dc9477a34 Stephen Boyd 2015-04-30 845 * clk_unprepare - undo preparation of a clock source
4dff95dc9477a34 Stephen Boyd 2015-04-30 846 * @clk: the clk being unprepared
4dff95dc9477a34 Stephen Boyd 2015-04-30 847 *
4dff95dc9477a34 Stephen Boyd 2015-04-30 848 * clk_unprepare may sleep, which differentiates it from clk_disable. In a
4dff95dc9477a34 Stephen Boyd 2015-04-30 849 * simple case, clk_unprepare can be used instead of clk_disable to gate a clk
4dff95dc9477a34 Stephen Boyd 2015-04-30 850 * if the operation may sleep. One example is a clk which is accessed over
4dff95dc9477a34 Stephen Boyd 2015-04-30 851 * I2c. In the complex case a clk gate operation may require a fast and a slow
4dff95dc9477a34 Stephen Boyd 2015-04-30 852 * part. It is this reason that clk_unprepare and clk_disable are not mutually
4dff95dc9477a34 Stephen Boyd 2015-04-30 853 * exclusive. In fact clk_disable must be called before clk_unprepare.
4dff95dc9477a34 Stephen Boyd 2015-04-30 854 */
4dff95dc9477a34 Stephen Boyd 2015-04-30 @855 void clk_unprepare(struct clk *clk)
b2476490ef11134 Mike Turquette 2012-03-15 856 {
4dff95dc9477a34 Stephen Boyd 2015-04-30 857 if (IS_ERR_OR_NULL(clk))
4dff95dc9477a34 Stephen Boyd 2015-04-30 858 return;
b2476490ef11134 Mike Turquette 2012-03-15 859
a6adc30ba7bef8d Dong Aisheng 2016-06-30 860 clk_core_unprepare_lock(clk->core);
1e435256d625c20 Olof Johansson 2013-04-27 861 }
4dff95dc9477a34 Stephen Boyd 2015-04-30 862 EXPORT_SYMBOL_GPL(clk_unprepare);
1e435256d625c20 Olof Johansson 2013-04-27 863
4dff95dc9477a34 Stephen Boyd 2015-04-30 864 static int clk_core_prepare(struct clk_core *core)
4dff95dc9477a34 Stephen Boyd 2015-04-30 865 {
4dff95dc9477a34 Stephen Boyd 2015-04-30 866 int ret = 0;
b2476490ef11134 Mike Turquette 2012-03-15 867
a63347251907d7f Stephen Boyd 2015-05-06 868 lockdep_assert_held(&prepare_lock);
a63347251907d7f Stephen Boyd 2015-05-06 869
4dff95dc9477a34 Stephen Boyd 2015-04-30 870 if (!core)
4dff95dc9477a34 Stephen Boyd 2015-04-30 871 return 0;
b2476490ef11134 Mike Turquette 2012-03-15 872
4dff95dc9477a34 Stephen Boyd 2015-04-30 873 if (core->prepare_count == 0) {
9a34b45397e5a38 Marek Szyprowski 2017-08-21 874 ret = clk_pm_runtime_get(core);
4dff95dc9477a34 Stephen Boyd 2015-04-30 875 if (ret)
4dff95dc9477a34 Stephen Boyd 2015-04-30 876 return ret;
b2476490ef11134 Mike Turquette 2012-03-15 877
9a34b45397e5a38 Marek Szyprowski 2017-08-21 878 ret = clk_core_prepare(core->parent);
9a34b45397e5a38 Marek Szyprowski 2017-08-21 879 if (ret)
9a34b45397e5a38 Marek Szyprowski 2017-08-21 880 goto runtime_put;
9a34b45397e5a38 Marek Szyprowski 2017-08-21 881
4dff95dc9477a34 Stephen Boyd 2015-04-30 882 trace_clk_prepare(core);
1c155b3dfe08351 Ulf Hansson 2013-03-12 883
4dff95dc9477a34 Stephen Boyd 2015-04-30 884 if (core->ops->prepare)
4dff95dc9477a34 Stephen Boyd 2015-04-30 885 ret = core->ops->prepare(core->hw);
1c155b3dfe08351 Ulf Hansson 2013-03-12 886
4dff95dc9477a34 Stephen Boyd 2015-04-30 887 trace_clk_prepare_complete(core);
b2476490ef11134 Mike Turquette 2012-03-15 888
9a34b45397e5a38 Marek Szyprowski 2017-08-21 889 if (ret)
9a34b45397e5a38 Marek Szyprowski 2017-08-21 890 goto unprepare;
b2476490ef11134 Mike Turquette 2012-03-15 891 }
b2476490ef11134 Mike Turquette 2012-03-15 892
4dff95dc9477a34 Stephen Boyd 2015-04-30 893 core->prepare_count++;
b2476490ef11134 Mike Turquette 2012-03-15 894
9461f7b33d11cbb Jerome Brunet 2018-06-19 895 /*
9461f7b33d11cbb Jerome Brunet 2018-06-19 896 * CLK_SET_RATE_GATE is a special case of clock protection
9461f7b33d11cbb Jerome Brunet 2018-06-19 897 * Instead of a consumer claiming exclusive rate control, it is
9461f7b33d11cbb Jerome Brunet 2018-06-19 898 * actually the provider which prevents any consumer from making any
9461f7b33d11cbb Jerome Brunet 2018-06-19 899 * operation which could result in a rate change or rate glitch while
9461f7b33d11cbb Jerome Brunet 2018-06-19 900 * the clock is prepared.
9461f7b33d11cbb Jerome Brunet 2018-06-19 901 */
9461f7b33d11cbb Jerome Brunet 2018-06-19 902 if (core->flags & CLK_SET_RATE_GATE)
9461f7b33d11cbb Jerome Brunet 2018-06-19 903 clk_core_rate_protect(core);
9461f7b33d11cbb Jerome Brunet 2018-06-19 904
4dff95dc9477a34 Stephen Boyd 2015-04-30 905 return 0;
9a34b45397e5a38 Marek Szyprowski 2017-08-21 906 unprepare:
9a34b45397e5a38 Marek Szyprowski 2017-08-21 907 clk_core_unprepare(core->parent);
9a34b45397e5a38 Marek Szyprowski 2017-08-21 908 runtime_put:
9a34b45397e5a38 Marek Szyprowski 2017-08-21 909 clk_pm_runtime_put(core);
9a34b45397e5a38 Marek Szyprowski 2017-08-21 910 return ret;
b2476490ef11134 Mike Turquette 2012-03-15 911 }
b2476490ef11134 Mike Turquette 2012-03-15 912
a6adc30ba7bef8d Dong Aisheng 2016-06-30 913 static int clk_core_prepare_lock(struct clk_core *core)
a6adc30ba7bef8d Dong Aisheng 2016-06-30 914 {
a6adc30ba7bef8d Dong Aisheng 2016-06-30 915 int ret;
a6adc30ba7bef8d Dong Aisheng 2016-06-30 916
a6adc30ba7bef8d Dong Aisheng 2016-06-30 917 clk_prepare_lock();
a6adc30ba7bef8d Dong Aisheng 2016-06-30 918 ret = clk_core_prepare(core);
a6adc30ba7bef8d Dong Aisheng 2016-06-30 919 clk_prepare_unlock();
a6adc30ba7bef8d Dong Aisheng 2016-06-30 920
a6adc30ba7bef8d Dong Aisheng 2016-06-30 921 return ret;
a6adc30ba7bef8d Dong Aisheng 2016-06-30 922 }
a6adc30ba7bef8d Dong Aisheng 2016-06-30 923
4dff95dc9477a34 Stephen Boyd 2015-04-30 924 /**
4dff95dc9477a34 Stephen Boyd 2015-04-30 925 * clk_prepare - prepare a clock source
4dff95dc9477a34 Stephen Boyd 2015-04-30 926 * @clk: the clk being prepared
4dff95dc9477a34 Stephen Boyd 2015-04-30 927 *
4dff95dc9477a34 Stephen Boyd 2015-04-30 928 * clk_prepare may sleep, which differentiates it from clk_enable. In a simple
4dff95dc9477a34 Stephen Boyd 2015-04-30 929 * case, clk_prepare can be used instead of clk_enable to ungate a clk if the
4dff95dc9477a34 Stephen Boyd 2015-04-30 930 * operation may sleep. One example is a clk which is accessed over I2c. In
4dff95dc9477a34 Stephen Boyd 2015-04-30 931 * the complex case a clk ungate operation may require a fast and a slow part.
4dff95dc9477a34 Stephen Boyd 2015-04-30 932 * It is this reason that clk_prepare and clk_enable are not mutually
4dff95dc9477a34 Stephen Boyd 2015-04-30 933 * exclusive. In fact clk_prepare must be called before clk_enable.
4dff95dc9477a34 Stephen Boyd 2015-04-30 934 * Returns 0 on success, -EERROR otherwise.
4dff95dc9477a34 Stephen Boyd 2015-04-30 935 */
4dff95dc9477a34 Stephen Boyd 2015-04-30 @936 int clk_prepare(struct clk *clk)
b2476490ef11134 Mike Turquette 2012-03-15 937 {
035a61c314eb3da Tomeu Vizoso 2015-01-23 938 if (!clk)
4dff95dc9477a34 Stephen Boyd 2015-04-30 939 return 0;
035a61c314eb3da Tomeu Vizoso 2015-01-23 940
a6adc30ba7bef8d Dong Aisheng 2016-06-30 941 return clk_core_prepare_lock(clk->core);
7ef3dcc8145263c James Hogan 2013-07-29 942 }
4dff95dc9477a34 Stephen Boyd 2015-04-30 943 EXPORT_SYMBOL_GPL(clk_prepare);
035a61c314eb3da Tomeu Vizoso 2015-01-23 944
:::::: The code at line 855 was first introduced by commit
:::::: 4dff95dc9477a34de77d24c59dcf1dc593687fcf clk: Remove forward declared function prototypes
:::::: TO: Stephen Boyd <sboyd(a)codeaurora.org>
:::::: CC: Stephen Boyd <sboyd(a)codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
drivers/iio/adc/at91_adc.c:450:16: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9c87c9f41245baa3fc4716cf39141439cf405b01
commit: 4027860dcc4cd0c45c36bae21e45bee5a17f2f0f iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <rong.a.chen(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/iio/adc/at91_adc.c:450:16: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if (status & AT91_ADC_ISR_PENS) {
^
vim +450 drivers/iio/adc/at91_adc.c
84882b060301c35 Alexandre Belloni 2014-04-15 417
84882b060301c35 Alexandre Belloni 2014-04-15 418 static irqreturn_t at91_adc_9x5_interrupt(int irq, void *private)
c8b11de0404d318 Josh Wu 2013-10-08 419 {
c8b11de0404d318 Josh Wu 2013-10-08 420 struct iio_dev *idev = private;
c8b11de0404d318 Josh Wu 2013-10-08 421 struct at91_adc_state *st = iio_priv(idev);
c8b11de0404d318 Josh Wu 2013-10-08 422 u32 status = at91_adc_readl(st, st->registers->status_register);
c8b11de0404d318 Josh Wu 2013-10-08 423 const uint32_t ts_data_irq_mask =
c8b11de0404d318 Josh Wu 2013-10-08 424 AT91_ADC_IER_XRDY |
c8b11de0404d318 Josh Wu 2013-10-08 425 AT91_ADC_IER_YRDY |
c8b11de0404d318 Josh Wu 2013-10-08 426 AT91_ADC_IER_PRDY;
c8b11de0404d318 Josh Wu 2013-10-08 427
d4f51956ac8ad30 Ludovic Desroches 2014-10-09 428 if (status & GENMASK(st->num_channels - 1, 0))
c8b11de0404d318 Josh Wu 2013-10-08 429 handle_adc_eoc_trigger(irq, idev);
c8b11de0404d318 Josh Wu 2013-10-08 430
c8b11de0404d318 Josh Wu 2013-10-08 431 if (status & AT91_ADC_IER_PEN) {
c8b11de0404d318 Josh Wu 2013-10-08 432 at91_adc_writel(st, AT91_ADC_IDR, AT91_ADC_IER_PEN);
c8b11de0404d318 Josh Wu 2013-10-08 433 at91_adc_writel(st, AT91_ADC_IER, AT91_ADC_IER_NOPEN |
c8b11de0404d318 Josh Wu 2013-10-08 434 ts_data_irq_mask);
c8b11de0404d318 Josh Wu 2013-10-08 435 /* Set up period trigger for sampling */
c8b11de0404d318 Josh Wu 2013-10-08 436 at91_adc_writel(st, st->registers->trigger_register,
c8b11de0404d318 Josh Wu 2013-10-08 437 AT91_ADC_TRGR_MOD_PERIOD_TRIG |
c8b11de0404d318 Josh Wu 2013-10-08 438 AT91_ADC_TRGR_TRGPER_(st->ts_sample_period_val));
c8b11de0404d318 Josh Wu 2013-10-08 439 } else if (status & AT91_ADC_IER_NOPEN) {
c8b11de0404d318 Josh Wu 2013-10-08 440 at91_adc_writel(st, st->registers->trigger_register, 0);
c8b11de0404d318 Josh Wu 2013-10-08 441 at91_adc_writel(st, AT91_ADC_IDR, AT91_ADC_IER_NOPEN |
c8b11de0404d318 Josh Wu 2013-10-08 442 ts_data_irq_mask);
c8b11de0404d318 Josh Wu 2013-10-08 443 at91_adc_writel(st, AT91_ADC_IER, AT91_ADC_IER_PEN);
c8b11de0404d318 Josh Wu 2013-10-08 444
c8b11de0404d318 Josh Wu 2013-10-08 445 input_report_key(st->ts_input, BTN_TOUCH, 0);
c8b11de0404d318 Josh Wu 2013-10-08 446 input_sync(st->ts_input);
c8b11de0404d318 Josh Wu 2013-10-08 447 } else if ((status & ts_data_irq_mask) == ts_data_irq_mask) {
c8b11de0404d318 Josh Wu 2013-10-08 448 /* Now all touchscreen data is ready */
c8b11de0404d318 Josh Wu 2013-10-08 449
c8b11de0404d318 Josh Wu 2013-10-08 @450 if (status & AT91_ADC_ISR_PENS) {
c8b11de0404d318 Josh Wu 2013-10-08 451 /* validate data by pen contact */
c8b11de0404d318 Josh Wu 2013-10-08 452 at91_ts_sample(st);
c8b11de0404d318 Josh Wu 2013-10-08 453 } else {
c8b11de0404d318 Josh Wu 2013-10-08 454 /* triggered by event that is no pen contact, just read
c8b11de0404d318 Josh Wu 2013-10-08 455 * them to clean the interrupt and discard all.
c8b11de0404d318 Josh Wu 2013-10-08 456 */
c8b11de0404d318 Josh Wu 2013-10-08 457 at91_adc_readl(st, AT91_ADC_TSXPOSR);
c8b11de0404d318 Josh Wu 2013-10-08 458 at91_adc_readl(st, AT91_ADC_TSYPOSR);
c8b11de0404d318 Josh Wu 2013-10-08 459 at91_adc_readl(st, AT91_ADC_TSPRESSR);
c8b11de0404d318 Josh Wu 2013-10-08 460 }
c8b11de0404d318 Josh Wu 2013-10-08 461 }
0e589d5fb3172b0 Maxime Ripard 2012-05-11 462
0e589d5fb3172b0 Maxime Ripard 2012-05-11 463 return IRQ_HANDLED;
0e589d5fb3172b0 Maxime Ripard 2012-05-11 464 }
0e589d5fb3172b0 Maxime Ripard 2012-05-11 465
:::::: The code at line 450 was first introduced by commit
:::::: c8b11de0404d318c4a67bf6b9066663b9d93786c iio: at91: introduce touch screen support in iio adc driver
:::::: TO: Josh Wu <josh.wu(a)atmel.com>
:::::: CC: Jonathan Cameron <jic23(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[radeon-alex:amd-staging-drm-next 593/598] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5: warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property'
by kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head: 11e500d2892a2b18e438c12e1e992b241aaf1c8b
commit: 110d586ba77ed573eb7464ca69b6490ec0b70c5f [593/598] drm/amd/display: Expose new CRC window property
config: arm64-randconfig-r034-20201115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ace9653c11c6308401dcda2e8b26bf97e6e66e30)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git fetch --no-tags radeon-alex amd-staging-drm-next
git checkout 110d586ba77ed573eb7464ca69b6490ec0b70c5f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5: warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
^
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
^
static
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5: warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
^
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
^
static
2 warnings generated.
vim +/amdgpu_dm_crtc_atomic_set_property +5374 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
5372
5373 #ifdef CONFIG_DEBUG_FS
> 5374 int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
5375 struct drm_crtc_state *crtc_state,
5376 struct drm_property *property,
5377 uint64_t val)
5378 {
5379 struct drm_device *dev = crtc->dev;
5380 struct amdgpu_device *adev = drm_to_adev(dev);
5381 struct dm_crtc_state *dm_new_state =
5382 to_dm_crtc_state(crtc_state);
5383
5384 if (property == adev->dm.crc_win_x_start_property)
5385 dm_new_state->crc_window.x_start = val;
5386 else if (property == adev->dm.crc_win_y_start_property)
5387 dm_new_state->crc_window.y_start = val;
5388 else if (property == adev->dm.crc_win_x_end_property)
5389 dm_new_state->crc_window.x_end = val;
5390 else if (property == adev->dm.crc_win_y_end_property)
5391 dm_new_state->crc_window.y_end = val;
5392 else
5393 return -EINVAL;
5394
5395 return 0;
5396 }
5397
> 5398 int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
5399 const struct drm_crtc_state *state,
5400 struct drm_property *property,
5401 uint64_t *val)
5402 {
5403 struct drm_device *dev = crtc->dev;
5404 struct amdgpu_device *adev = drm_to_adev(dev);
5405 struct dm_crtc_state *dm_state =
5406 to_dm_crtc_state(state);
5407
5408 if (property == adev->dm.crc_win_x_start_property)
5409 *val = dm_state->crc_window.x_start;
5410 else if (property == adev->dm.crc_win_y_start_property)
5411 *val = dm_state->crc_window.y_start;
5412 else if (property == adev->dm.crc_win_x_end_property)
5413 *val = dm_state->crc_window.x_end;
5414 else if (property == adev->dm.crc_win_y_end_property)
5415 *val = dm_state->crc_window.y_end;
5416 else
5417 return -EINVAL;
5418
5419 return 0;
5420 }
5421 #endif
5422
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: drivers/net/ethernet/freescale/gianfar.c:580 gfar_parse_group() warn: 'grp->regs' not released on lines: 517.
by Dan Carpenter
On Tue, Nov 17, 2020 at 01:41:15AM +0000, Leo Li wrote:
> > ee873fda3bec7c6 drivers/net/ethernet/freescale/gianfar.c Claudiu Manoil
> > 2013-01-29 513 gfar_irq(grp, ER)->irq =
> > irq_of_parse_and_map(np, 2);
> > fea0f6650979a4f drivers/net/ethernet/freescale/gianfar.c Mark Brown
> > 2015-11-26 514 if (!gfar_irq(grp, TX)->irq ||
> > fea0f6650979a4f drivers/net/ethernet/freescale/gianfar.c Mark Brown
> > 2015-11-26 515 !gfar_irq(grp, RX)->irq ||
> > fea0f6650979a4f drivers/net/ethernet/freescale/gianfar.c Mark Brown
> > 2015-11-26 516 !gfar_irq(grp, ER)->irq)
> > 46ceb60ca80fa07 drivers/net/gianfar.c Sandeep Gopalpet 2009-11-
> > 02 517 return -EINVAL;
> >
> > This should unmap "grp->regs".
>
> This variable is unmapped in the caller with a wholesale cleanup function unmap_group_regs(). Probably a false positive for smatch?
>
Yeah. Thanks. Smatch doesn't consider that the variable might be freed
in the caller.
regards,
dan carpenter
1 year, 10 months